fix(codegen)!: Column type for slices#447
Merged
kodiakhq[bot] merged 4 commits intomainfrom Dec 7, 2022
Merged
Conversation
⏱️ Benchmark results
|
34dea94 to
3582ed1
Compare
erezrokah
approved these changes
Dec 1, 2022
Member
erezrokah
left a comment
There was a problem hiding this comment.
This looks good, added a non blocking comment.
Please merge this as fix(codegen)! as this is a breaking change
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
6dc685e to
9fc7fe0
Compare
yevgenypats
approved these changes
Dec 7, 2022
erezrokah
added a commit
to erezrokah/plugin-sdk
that referenced
this pull request
Dec 7, 2022
This reverts commit 7474c90.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[]*stringwill becomeschema.TypeStringArray[]*int(8|16|32|64)will becomeschema.TypeIntArrayUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)BEGIN_COMMIT_OVERRIDE
fix(codegen): Column type for slices
END_COMMIT_OVERRIDE