Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e9f29ff
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9c25670
Choose a head ref
  • 7 commits
  • 19 files changed
  • 6 contributors

Commits on Apr 26, 2023

  1. fix: TransformWithStruct/DefaultNameTransformer change for invalid co…

    …lumn names (#820)
    
    Closes cloudquery/cloudquery#10274
    
    I went for the simple approach of not accepting the json tag value if it's going to result in an invalid column name.
    disq authored Apr 26, 2023
    1 Configuration menu
    Copy the full SHA
    01e6649 View commit details
    Browse the repository at this point in the history
  2. feat: Add table description to Arrow schema metadata (#824)

    Before this change, only table name was supported as arrow Schema metadata.
    hermanschaaf authored Apr 26, 2023
    1 Configuration menu
    Copy the full SHA
    1a8072f View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. feat(arrow): Streamline Apache Arrow extension types (#823)

    ### Common
    
    Use pointer receivers:
    1. For Array types: to have all functions have the same receiver type
    (other functions do have pointer receivers, so updating `String()`
    method receiver is natural, see `net.IPNet` as a reference.
    2. For `Type` implementations: we do return a pointer from `NewXYZType`
    function, so it's only natural to define the receiver as pointer as
    well.
    
    ### `Inet`
    
    #### `InetBuilder`
    
    1. Now accepts `*net.IPNet` (pointer) in `Append`, `UnsafeAppend` &
    `AppendValues`
    3. `AppendValues` now accounts for `valid` param
    
    #### `InetArray`
    
    1. `String` method uses `%q` format as mainstream Apache Arrow types
    2. Added `Value(i int) *net.IPNet` function
    4. `GetOneForMarshal` utilizes `Value` implementation
    
    ### `JSON`
    
    #### `JSONBuilder`
    
    1. Marshaling with `json.DisableHTMLEscape()` option per #622
    2. `AppendValues` now accounts for `valid` param
    3. `UnmarshalJSON` implementation is streamlined with helper
    `Unmarshal(dec *json.Decoder) error` function (as mainstream Apache
    Arrow types)
    
    #### `JSONArray`
    
    1. `String` method uses `%q` format as mainstream Apache Arrow types
    2. Added `Value(i int) any` function that will unmarshal the stored data
    & return the concrete type
    3. Use `json.UnmarshalNoEscape` per #622
    5. `GetOneForMarshal` now doesn't perform unmarshaling and, instead,
    returns the stored `json.RawMessage`
    
    ### `Mac`
    
    #### `MacBuilder`
    
    1. `AppendValues` now accounts for `valid` param
    
    #### `MacArray`
    
    1. `String` method uses `%q` format as mainstream Apache Arrow types
    2. Added `Value(i int) net.HardwareAddr` function
    
    ### `UUID`
    
    #### `UUIDBuilder`
    
    1. `AppendValues` now accounts for `valid` param
    2. Use `uuid.Must` func instead of panic in code
    
    ### `UUIDArray`
    
    1. `String` method uses `%q` format as mainstream Apache Arrow types
    2. Added `Value(i int) uuid.UUID` func
    3. Use `uuid.Must` func instead of panic in code
    candiduslynx authored Apr 27, 2023
    1 Configuration menu
    Copy the full SHA
    f32fac3 View commit details
    Browse the repository at this point in the history
  2. feat(test): Add double migration test (#827)

    We saw some bugs when the migration code wasn't reliable and, if we ran
    safe migration after forced one, there would be conflicts reported
    (where they shouldn't have been).
    This extra test ensures that the destination is in sync what it scans
    from database and what is taken from spec.
    candiduslynx authored Apr 27, 2023
    1 Configuration menu
    Copy the full SHA
    4cd3872 View commit details
    Browse the repository at this point in the history
  3. 1 Configuration menu
    Copy the full SHA
    ffb97b0 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. 1 Configuration menu
    Copy the full SHA
    bc14251 View commit details
    Browse the repository at this point in the history
  2. chore(main): Release v2.5.0 (#826)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ##
    [2.5.0](v2.4.0...v2.5.0)
    (2023-04-28)
    
    
    ### Features
    
    * Add table description to Arrow schema metadata
    ([#824](#824))
    ([1a8072f](1a8072f))
    * **arrow:** Streamline Apache Arrow extension types
    ([#823](#823))
    ([f32fac3](f32fac3))
    * **test:** Add double migration test
    ([#827](#827))
    ([4cd3872](4cd3872))
    * Time values are truncated uniformly
    ([#825](#825))
    ([ffb97b0](ffb97b0))
    
    
    ### Bug Fixes
    
    * TransformWithStruct/DefaultNameTransformer change for invalid column
    names ([#820](#820))
    ([01e6649](01e6649))
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    cq-bot authored Apr 28, 2023
    1 Configuration menu
    Copy the full SHA
    9c25670 View commit details
    Browse the repository at this point in the history
Loading