feat(test): Add double migration test#827
Merged
candiduslynx merged 2 commits intomainfrom Apr 27, 2023
Merged
Conversation
yevgenypats
suggested changes
Apr 27, 2023
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
can we just add it to an already existing force test?
⏱️ Benchmark resultsComparing with f32fac3
|
Contributor
Author
I think this should be done here as we want to ensure the full consistency in a simple way. |
bda7bc1 to
0704777
Compare
hermanschaaf
approved these changes
Apr 27, 2023
Contributor
|
I don't mind where it's done, as long as it is done; this test is a great addition to the test suite imo 👍 |
yevgenypats
approved these changes
Apr 27, 2023
candiduslynx
pushed a commit
that referenced
this pull request
Apr 28, 2023
🤖 I have created a release *beep* *boop* --- ## [2.5.0](v2.4.0...v2.5.0) (2023-04-28) ### Features * Add table description to Arrow schema metadata ([#824](#824)) ([1a8072f](1a8072f)) * **arrow:** Streamline Apache Arrow extension types ([#823](#823)) ([f32fac3](f32fac3)) * **test:** Add double migration test ([#827](#827)) ([4cd3872](4cd3872)) * Time values are truncated uniformly ([#825](#825)) ([ffb97b0](ffb97b0)) ### Bug Fixes * TransformWithStruct/DefaultNameTransformer change for invalid column names ([#820](#820)) ([01e6649](01e6649)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw some bugs when the migration code wasn't reliable and, if we ran safe migration after forced one, there would be conflicts reported (where they shouldn't have been).
This extra test ensures that the destination is in sync what it scans from database and what is taken from spec.