fix(aws): Fixed aws_ecs_clusters fetch to include cluster settings
#9101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
approved these changes
Mar 15, 2023
Member
hermanschaaf
left a comment
There was a problem hiding this comment.
Thanks @KMConner, great catch! I've also added the other missing types to the request, so hopefully we've got it all now
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
🤖 I have created a release *beep* *boop* --- ## [15.4.0](plugins-source-aws-v15.3.0...plugins-source-aws-v15.4.0) (2023-03-15) ### Features * **aws:** Add AWS EC2 AccountAttributes ([#8937](#8937)) ([90b9b3b](90b9b3b)) * **aws:** Add AWS Organizations Delegated Services ([#8938](#8938)) ([349cf0d](349cf0d)) * **aws:** Add Compute Optimizer Resource ([#8930](#8930)) ([da8cc77](da8cc77)) * **aws:** Add EC2 image launch permissions resource (`aws_ec2_image_launch_permissions`) ([#8689](#8689)) ([025786f](025786f)) * **aws:** Add Support for VPC Service Permissions ([#8808](#8808)) ([05d3342](05d3342)) ### Bug Fixes * **aws-resources-functions:** Save function configuration instead of failing on `AccessDenied` or `AccessDeniedException` errors in `aws_lambda_functions` ([#8870](#8870)) ([ec0b9fd](ec0b9fd)) * **aws:** Fix description for `aws_organizations_delegated_administrators` ([#8935](#8935)) ([2dc6675](2dc6675)) * **aws:** Fixed `aws_ecs_clusters` fetch to include cluster settings ([#9101](#9101)) ([6bc7933](6bc7933)) * **aws:** Log Error On Skipped Multiplexer ([#8799](#8799)) ([ea30c54](ea30c54)) * **deps:** Update module github.com/aws/aws-sdk-go-v2 to v1.17.6 ([#8882](#8882)) ([5fa0031](5fa0031)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.16 ([#8883](#8883)) ([82ffe4d](82ffe4d)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/ec2/imds to v1.12.24 ([#8885](#8885)) ([674fec4](674fec4)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.56 ([#8886](#8886)) ([8a3db4b](8a3db4b)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/internal/ini to v1.3.31 ([#8889](#8889)) ([f8fdb07](f8fdb07)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/internal/v4a to v1.0.22 ([#8890](#8890)) ([3c5b412](3c5b412)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/accessanalyzer to v1.19.6 ([#8891](#8891)) ([b90fb07](b90fb07)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/acm to v1.17.6 ([#8892](#8892)) ([65d5c27](65d5c27)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/amp to v1.16.5 ([#8893](#8893)) ([0adec38](0adec38)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/amplify to v1.13.5 ([#8894](#8894)) ([1f171cc](1f171cc)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigateway to v1.16.6 ([#8895](#8895)) ([dd84bc9](dd84bc9)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigatewayv2 to v1.13.6 ([#8896](#8896)) ([5699e4b](5699e4b)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/applicationautoscaling to v1.17.6 ([#8897](#8897)) ([1729bed](1729bed)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudhsmv2 to v1.14.5 ([#8898](#8898)) ([f453645](f453645)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatch to v1.25.5 ([#8899](#8899)) ([34cbb8d](34cbb8d)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to v1.20.6 ([#8900](#8900)) ([a19edb4](a19edb4)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/codebuild to v1.20.6 ([#8901](#8901)) ([319ef28](319ef28)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/codepipeline to v1.14.5 ([#8907](#8907)) ([9751c0a](9751c0a)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cognitoidentity to v1.15.5 ([#8908](#8908)) ([3bc3e3a](3bc3e3a)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider to v1.22.5 ([#8909](#8909)) ([f5dd4cc](f5dd4cc)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/configservice to v1.29.6 ([#8910](#8910)) ([6475fbc](6475fbc)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/dax to v1.12.5 ([#8911](#8911)) ([f7a6c1d](f7a6c1d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.43.0 ([#8949](#8949)) ([31dfc63](31dfc63)) * Update endpoints ([#8942](#8942)) ([806e490](806e490)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There exists
settingsfield inaws_ecs_clusterstable.However, this field is always empty because settings field is not included in AWS API response by default.
(See https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_DescribeClusters.html for more information.)
So, I fixed API request parameters to include settings field.