fix(sqlite-migrate): Use int when getting pk column information#6848
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Jan 17, 2023
Merged
fix(sqlite-migrate): Use int when getting pk column information#6848kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
int when getting pk column information#6848kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
shimonp21
approved these changes
Jan 17, 2023
Contributor
shimonp21
left a comment
There was a problem hiding this comment.
Tested manually - Approving :)
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 17, 2023
🤖 I have created a release *beep* *boop* --- ## [1.1.6](plugins-destination-sqlite-v1.1.5...plugins-destination-sqlite-v1.1.6) (2023-01-17) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.2 ([#6695](#6695)) ([694ab9f](694ab9f)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.25.0 ([#6745](#6745)) ([9c41854](9c41854)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.25.1 ([#6805](#6805)) ([9da0ce2](9da0ce2)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.26.0 ([#6839](#6839)) ([6ccda8d](6ccda8d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.27.0 ([#6856](#6856)) ([545799b](545799b)) * **sqlite-migrate:** Use `int` when getting `pk` column information ([#6848](#6848)) ([8ed1d94](8ed1d94)) * **sqlite:** Set module in logs to `sqlite-dest` instead of `pg-dest` ([#6764](#6764)) ([6cfda91](6cfda91)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLite migration always fails on tables that have multiple PKs. The reason is that
pkintable_infois either0for non PKs or the 1 based index of the column within the PKs (usually 1 for a single PK, but can be 2, 3, etc.)See https://www.sqlite.org/pragma.html#pragma_table_info.
If you remove the fix you'll get the following error: