fix(sqlite-migrate): Use int when getting pk column information (#6848)

erezrokah · web-flow · commit 8ed1d946061b · 2023-01-17T09:04:00.000Z
#### Summary SQLite migration always fails on tables that have multiple PKs. The reason is that `pk` in `table_info` is either `0` for non PKs or the 1 based index of the column within the PKs (usually 1 for a single PK, but can be 2, 3, etc.) See https://www.sqlite.org/pragma.html#pragma_table_info. If you remove the fix you'll get the following error: ``` failed to get table table_1 columns types: sql: Scan error on column index 5, name "pk": sql/driver: couldn't convert 2 into type bool ``` <!--
diff --git a/plugins/destination/sqlite/client/client_test.go b/plugins/destination/sqlite/client/client_test.go
@@ -1,9 +1,13 @@
 package client
 
 import (
+	"context"
 	"testing"
 
 	"github.com/cloudquery/plugin-sdk/plugins/destination"
+	"github.com/cloudquery/plugin-sdk/schema"
+	"github.com/cloudquery/plugin-sdk/specs"
+	"github.com/rs/zerolog"
 )
 
 func TestPlugin(t *testing.T) {
@@ -15,3 +19,33 @@ func TestPlugin(t *testing.T) {
 		},
 		destination.PluginTestSuiteTests{})
 }
+
+func TestPluginMigrateMultiplePKs(t *testing.T) {
+	table := schema.Table{
+		Name: "table_1",
+		Columns: []schema.Column{
+			{Name: "id", Type: schema.TypeUUID, CreationOptions: schema.ColumnCreationOptions{PrimaryKey: true}},
+			{Name: "name", Type: schema.TypeString, CreationOptions: schema.ColumnCreationOptions{PrimaryKey: true}},
+			{Name: "age", Type: schema.TypeInt},
+		},
+	}
+	p := destination.NewPlugin("sqlite", "development", New)
+	ctx := context.Background()
+
+	spec := Spec{
+		ConnectionString: ":memory:",
+	}
+
+	// Init the plugin so we can call migrate
+	if err := p.Init(ctx, zerolog.Logger{}, specs.Destination{Name: "cq_test_migrate_multiple_pks", Spec: spec}); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := p.Migrate(ctx, []*schema.Table{&table}); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := p.Migrate(ctx, []*schema.Table{&table}); err != nil {
+		t.Fatal(err)
+	}
+}
diff --git a/plugins/destination/sqlite/client/migrate.go b/plugins/destination/sqlite/client/migrate.go
@@ -20,7 +20,7 @@ type columnInfo struct {
 	typ          string
 	notNull      bool
 	defaultValue any
-	pk           bool
+	pk           int
 }
 
 type tableInfo struct {

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ type columnInfo struct {`
`20`	`20`	`typ string`
`21`	`21`	`notNull bool`
`22`	`22`	`defaultValue any`
`23`		`- pk bool`
	`23`	`+ pk int`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`type tableInfo struct {`