Skip to content

feat(aws): KMS Key policies#6562

Merged
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom
disq:feat/aws_kms_key_policies
Jan 10, 2023
Merged

feat(aws): KMS Key policies#6562
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom
disq:feat/aws_kms_key_policies

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Jan 10, 2023

Implements #6559

@disq disq requested a review from bbernays January 10, 2023 09:24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 10, 2023

This PR has the following changes to source plugin(s) tables:

  • Table aws_kms_key_policies was added

@disq disq linked an issue Jan 10, 2023 that may be closed by this pull request
Support for AWS KMS Key Policies #6559
Closed
hermanschaaf
hermanschaaf reviewed Jan 10, 2023
View reviewed changes
plugins/source/aws/resources/services/kms/key_policies.go
c := meta.(*client.Client)
svc := c.Services().Kms

const policyName = "default"
Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite weird that the only valid name is default 🤷

Copy link
Copy Markdown
Member Author

@disq disq Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what the doc says... We could've left it off to add it later if needed maybe (but then the PK change would've been breaking)

Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, it's what the API doc says. Just weird that they did it that way 😄

hermanschaaf
hermanschaaf approved these changes Jan 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✨

@erezrokah erezrokah added automerge Automatically merge once required checks pass priority merge and removed priority merge labels Jan 10, 2023
@kodiakhq kodiakhq bot merged commit d8571aa into cloudquery:main Jan 10, 2023
@cq-bot cq-bot mentioned this pull request Jan 10, 2023
Merged
@disq disq deleted the feat/aws_kms_key_policies branch January 10, 2023 11:20
kodiakhq bot pushed a commit that referenced this pull request Jan 10, 2023
@cq-bot
chore(main): Release plugins-source-aws v9.2.0 (#6328)
804be3a 
🤖 I have created a release *beep* *boop*
---


## [9.2.0](plugins-source-aws-v9.1.1...plugins-source-aws-v9.2.0) (2023-01-10)


### Features

* **aws:** KMS Key policies ([#6562](#6562)) ([d8571aa](d8571aa)), closes [#6559](#6559)
* Move AWS to use built-in transformations (no codegen) ([#6337](#6337)) ([926d278](926d278))


### Bug Fixes

* **aws:** Enable Partial Resolution of Lambda ([#6391](#6391)) ([e96a410](e96a410))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.8 ([#6393](#6393)) ([ffba44f](ffba44f))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.47 ([#6395](#6395)) ([71ec9b9](71ec9b9))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/accessanalyzer to v1.19.0 ([#6396](#6396)) ([f19a34c](f19a34c))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/account to v1.8.0 ([#6397](#6397)) ([98a7681](98a7681))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/acm to v1.17.0 ([#6398](#6398)) ([f59f6bd](f59f6bd))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/amp to v1.16.0 ([#6399](#6399)) ([128ae76](128ae76))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigateway to v1.16.0 ([#6400](#6400)) ([4570f15](4570f15))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigatewayv2 to v1.13.0 ([#6401](#6401)) ([ca3b156](ca3b156))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/applicationautoscaling to v1.16.0 ([#6360](#6360)) ([afa651e](afa651e))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/applicationautoscaling to v1.17.0 ([#6402](#6402)) ([5c239ed](5c239ed))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apprunner to v1.16.0 ([#6403](#6403)) ([a312c4b](a312c4b))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/appstream to v1.19.0 ([#6404](#6404)) ([1cd08e1](1cd08e1))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/appsync to v1.18.0 ([#6405](#6405)) ([76d4df5](76d4df5))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/athena to v1.22.0 ([#6406](#6406)) ([815a0f9](815a0f9))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/autoscaling to v1.26.0 ([#6407](#6407)) ([26e995c](26e995c))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/backup to v1.19.0 ([#6408](#6408)) ([01accc8](01accc8))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudformation to v1.25.0 ([#6409](#6409)) ([89ffac6](89ffac6))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudfront to v1.24.0 ([#6410](#6410)) ([74a96fb](74a96fb))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudhsmv2 to v1.14.0 ([#6411](#6411)) ([d12e25c](d12e25c))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudtrail to v1.22.0 ([#6412](#6412)) ([c1765b8](c1765b8))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatch to v1.24.0 ([#6413](#6413)) ([c6324f3](c6324f3))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to v1.17.4 ([#6359](#6359)) ([8ca9085](8ca9085))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to v1.18.0 ([#6414](#6414)) ([35b62ac](35b62ac))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/codebuild to v1.20.0 ([#6444](#6444)) ([b91ca03](b91ca03))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/codepipeline to v1.14.0 ([#6445](#6445)) ([bb7d3f2](bb7d3f2))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cognitoidentity to v1.15.0 ([#6446](#6446)) ([c93c305](c93c305))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider to v1.22.0 ([#6447](#6447)) ([4ffbfd5](4ffbfd5))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/configservice to v1.29.0 ([#6448](#6448)) ([2433cbe](2433cbe))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/databasemigrationservice to v1.23.0 ([#6449](#6449)) ([9c2bb7c](9c2bb7c))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/dax to v1.12.0 ([#6450](#6450)) ([da537c6](da537c6))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/directconnect to v1.18.0 ([#6451](#6451)) ([89e34fe](89e34fe))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/docdb to v1.20.0 ([#6452](#6452)) ([472536a](472536a))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/dynamodb to v1.18.0 ([#6453](#6453)) ([561db49](561db49))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ecr to v1.18.0 ([#6454](#6454)) ([ecdbe98](ecdbe98))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ecrpublic to v1.14.0 ([#6455](#6455)) ([7984da9](7984da9))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ecs to v1.23.0 ([#6456](#6456)) ([94b8b4c](94b8b4c))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/efs to v1.19.0 ([#6457](#6457)) ([a56841a](a56841a))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/eks to v1.27.0 ([#6458](#6458)) ([4a74a54](4a74a54))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticache to v1.26.0 ([#6459](#6459)) ([5c70e45](5c70e45))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticbeanstalk to v1.15.0 ([#6460](#6460)) ([3333cfb](3333cfb))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing to v1.15.0 ([#6461](#6461)) ([d72d213](d72d213))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 to v1.19.0 ([#6462](#6462)) ([57ba804](57ba804))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticsearchservice to v1.18.0 ([#6463](#6463)) ([e282e84](e282e84))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elastictranscoder to v1.14.0 ([#6464](#6464)) ([163a581](163a581))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/emr to v1.22.0 ([#6465](#6465)) ([f149f08](f149f08))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/eventbridge to v1.17.0 ([#6473](#6473)) ([188848f](188848f))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/firehose to v1.16.0 ([#6474](#6474)) ([de60adb](de60adb))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/frauddetector to v1.21.0 ([#6475](#6475)) ([19b154a](19b154a))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/fsx to v1.28.0 ([#6476](#6476)) ([7b39554](7b39554))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/glacier to v1.14.0 ([#6477](#6477)) ([8d0887f](8d0887f))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/glue to v1.39.0 ([#6478](#6478)) ([4001267](4001267))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/guardduty to v1.17.0 ([#6479](#6479)) ([651dfe4](651dfe4))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/iam to v1.19.0 ([#6480](#6480)) ([30cf79d](30cf79d))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/identitystore to v1.16.0 ([#6481](#6481)) ([c7dd4a6](c7dd4a6))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/inspector to v1.13.0 ([#6482](#6482)) ([e628a51](e628a51))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/inspector2 to v1.11.0 ([#6483](#6483)) ([fe8fd70](fe8fd70))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/iot to v1.33.0 ([#6484](#6484)) ([d66ca25](d66ca25))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/kafka to v1.19.0 ([#6485](#6485)) ([acb2683](acb2683))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/kinesis to v1.17.0 ([#6486](#6486)) ([31b551f](31b551f))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/kms to v1.20.0 ([#6487](#6487)) ([5a8b81d](5a8b81d))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/lambda to v1.27.0 ([#6488](#6488)) ([de83eda](de83eda))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/lightsail to v1.25.0 ([#6489](#6489)) ([99ce478](99ce478))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/mq to v1.14.0 ([#6490](#6490)) ([d5b465c](d5b465c))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/mwaa to v1.14.0 ([#6491](#6491)) ([c565b0a](c565b0a))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/neptune to v1.19.0 ([#6492](#6492)) ([d373abd](d373abd))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/organizations to v1.18.0 ([#6495](#6495)) ([bbb2457](bbb2457))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/qldb to v1.15.0 ([#6496](#6496)) ([5f01dcf](5f01dcf))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/quicksight to v1.29.0 ([#6497](#6497)) ([6c6788c](6c6788c))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ram to v1.17.0 ([#6498](#6498)) ([306bcc5](306bcc5))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/rds to v1.39.0 ([#6499](#6499)) ([ed4cd10](ed4cd10))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/redshift to v1.27.0 ([#6500](#6500)) ([4c82e8b](4c82e8b))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/resourcegroups to v1.13.0 ([#6501](#6501)) ([9efd121](9efd121))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/route53 to v1.26.0 ([#6502](#6502)) ([135dc6b](135dc6b))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/route53domains to v1.14.0 ([#6503](#6503)) ([ba2aa9e](ba2aa9e))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/s3control to v1.29.0 ([#6505](#6505)) ([47fa203](47fa203))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/sagemaker to v1.62.0 ([#6506](#6506)) ([57207cf](57207cf))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/scheduler to v1.1.0 ([#6507](#6507)) ([a56a3e0](a56a3e0))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/secretsmanager to v1.18.0 ([#6508](#6508)) ([83f6116](83f6116))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/servicecatalog to v1.16.0 ([#6509](#6509)) ([1e69f8d](1e69f8d))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/servicecatalogappregistry to v1.16.0 ([#6510](#6510)) ([6a7f928](6a7f928))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/servicequotas to v1.14.0 ([#6511](#6511)) ([d12e3b8](d12e3b8))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ses to v1.15.0 ([#6512](#6512)) ([4f8863c](4f8863c))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/sesv2 to v1.16.0 ([#6513](#6513)) ([a4987ae](a4987ae))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/sfn to v1.17.0 ([#6514](#6514)) ([c8e7d9c](c8e7d9c))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ssm to v1.34.0 ([#6361](#6361)) ([2413dba](2413dba))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.18.0 ([#6339](#6339)) ([158365a](158365a))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.19.0 ([#6363](#6363)) ([ae6967c](ae6967c))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.20.0 ([#6376](#6376)) ([d6187ec](d6187ec))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.21.0 ([#6382](#6382)) ([5baea40](5baea40))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.22.0 ([#6516](#6516)) ([b7e4e73](b7e4e73))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.23.0 ([#6522](#6522)) ([ce24f1d](ce24f1d))
* Update endpoints ([#6327](#6327)) ([11d6973](11d6973))
* Update endpoints ([#6440](#6440)) ([499f421](499f421))
* Update endpoints ([#6558](#6558)) ([45c4753](45c4753))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erezrokah erezrokah erezrokah approved these changes

@bbernays bbernays Awaiting requested review from bbernays

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

+1 more reviewer

@hermanschaaf hermanschaaf hermanschaaf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for AWS KMS Key Policies

4 participants

@disq @hermanschaaf @erezrokah @cq-bot