fix(aws): Enable Partial Resolution of Lambda (#6391)

bbernays · web-flow · commit e96a41039456 · 2023-01-09T22:18:33.000Z
#### Summary

This enables CQ to store the results of `ListFunctions` even if the `GetFunction` fails because of a permission error. This was a fix that we had implemented in V0


&lt;!--
diff --git a/plugins/source/aws/resources/services/lambda/functions_fetch.go b/plugins/source/aws/resources/services/lambda/functions_fetch.go
@@ -47,6 +47,13 @@ func getFunction(ctx context.Context, meta schema.ClientMeta, resource *schema.R
 			}
 			return nil
 		}
+		// This is intended to handle the case where the user does not have GetFunction permission
+		// User should still get an error in the logs, but the data that was able to be fetched should be persisted
+		if client.IsAWSError(err, "AccessDenied") || client.IsAWSError(err, "AccessDeniedException") {
+			resource.Item = &lambda.GetFunctionOutput{
+				Configuration: &f,
+			}
+		}
 		return err
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,13 @@ func getFunction(ctx context.Context, meta schema.ClientMeta, resource *schema.R`
`47`	`47`	`}`
`48`	`48`	`return nil`
`49`	`49`	`}`
	`50`	`+ // This is intended to handle the case where the user does not have GetFunction permission`
	`51`	`+ // User should still get an error in the logs, but the data that was able to be fetched should be persisted`
	`52`	`+ if client.IsAWSError(err, "AccessDenied") \|\| client.IsAWSError(err, "AccessDeniedException") {`
	`53`	`+ resource.Item = &lambda.GetFunctionOutput{`
	`54`	`+ Configuration: &f,`
	`55`	`+ }`
	`56`	`+ }`
`50`	`57`	`return err`
`51`	`58`	`}`
`52`	`59`