Skip to content

feat(datadog): Migrate codegen to transformations#6424

Merged
kodiakhq[bot] merged 4 commits intomainfrom
datadog/codegen_to_transformations
Jan 6, 2023
Merged

feat(datadog): Migrate codegen to transformations#6424
kodiakhq[bot] merged 4 commits intomainfrom
datadog/codegen_to_transformations

Conversation

@yevgenypats
Copy link
Copy Markdown
Contributor

No description provided.

@yevgenypats yevgenypats requested review from a team and disq January 6, 2023 12:30
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2023

This PR has the following changes to source plugin(s) tables:

  • Table datadog_dashboard_lists: column added with name additional_properties and type JSON
  • Table datadog_dashboard_lists: column order changed for type
  • Table datadog_dashboards: column added with name additional_properties and type JSON
  • Table datadog_dashboards: column order changed for url
  • Table datadog_downtimes: column added with name additional_properties and type JSON
  • Table datadog_downtimes: column order changed for updater_id
  • Table datadog_global_variables: column added with name additional_properties and type JSON
  • Table datadog_global_variables: column order changed for value
  • Table datadog_hosts: column added with name additional_properties and type JSON
  • Table datadog_hosts: column order changed for up
  • Table datadog_incidents: column added with name additional_properties and type JSON
  • Table datadog_incidents: column order changed for type
  • Table datadog_monitors: column added with name additional_properties and type JSON
  • Table datadog_monitors: column order changed for type
  • Table datadog_notebooks: column added with name additional_properties and type JSON
  • Table datadog_notebooks: column order changed for type
  • Table datadog_permissions: column added with name additional_properties and type JSON
  • Table datadog_permissions: column order changed for type
  • Table datadog_role_permissions: column added with name additional_properties and type JSON
  • Table datadog_role_permissions: column order changed for type
  • Table datadog_role_users: column added with name additional_properties and type JSON
  • Table datadog_role_users: column order changed for type
  • Table datadog_roles: column added with name additional_properties and type JSON
  • Table datadog_roles: column order changed for type
  • Table datadog_synthetics: column added with name additional_properties and type JSON
  • Table datadog_synthetics: column added with name creator and type JSON
  • Table datadog_synthetics: column added with name steps and type JSON
  • Table datadog_synthetics: column order changed for type
  • Table datadog_user_organizations: column added with name additional_properties and type JSON
  • Table datadog_user_organizations: column order changed for type
  • Table datadog_user_permissions: column added with name additional_properties and type JSON
  • Table datadog_user_permissions: column order changed for type
  • Table datadog_users: column added with name additional_properties and type JSON
  • Table datadog_users: column order changed for type

@hermanschaaf
Copy link
Copy Markdown
Contributor

@yevgenypats I think this PR included changes to the crowdstrike plugin by accident as well

@yevgenypats yevgenypats force-pushed the datadog/codegen_to_transformations branch from 64f69a8 to a65f6fb Compare January 6, 2023 13:15
@vercel
Copy link
Copy Markdown

vercel bot commented Jan 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cloudquery-web 🔄 Building (Inspect) Jan 6, 2023 at 1:15PM (UTC)

@cq-bot cq-bot removed the crowdstrike label Jan 6, 2023
@disq
Copy link
Copy Markdown
Member

disq commented Jan 6, 2023

AdditionalProperties was always skipped in codegen, maybe do it here as well?

@yevgenypats
Copy link
Copy Markdown
Contributor Author

AdditionalProperties was always skipped in codegen, maybe do it here as well?

why was it skipped though?

@disq
Copy link
Copy Markdown
Member

disq commented Jan 6, 2023

AdditionalProperties was always skipped in codegen, maybe do it here as well?

why was it skipped though?

Not sure but it looks like an empty, undocumented map.

@hermanschaaf
Copy link
Copy Markdown
Contributor

AdditionalProperties seems useful enough to include - I think it will mean we always store extra fields returned by the API, even when they're not yet supported by the Go SDK.

@yevgenypats yevgenypats added the automerge Automatically merge once required checks pass label Jan 6, 2023
@kodiakhq kodiakhq bot merged commit 6ed64bc into main Jan 6, 2023
@kodiakhq kodiakhq bot deleted the datadog/codegen_to_transformations branch January 6, 2023 14:19
kodiakhq bot pushed a commit that referenced this pull request Jan 10, 2023
🤖 I have created a release *beep* *boop*
---


## [1.1.0](plugins-source-datadog-v1.0.5...plugins-source-datadog-v1.1.0) (2023-01-10)


### Features

* **datadog:** Migrate codegen to transformations ([#6424](#6424)) ([6ed64bc](6ed64bc))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.17.2 ([#6260](#6260)) ([805972a](805972a))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.18.0 ([#6339](#6339)) ([158365a](158365a))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.19.0 ([#6363](#6363)) ([ae6967c](ae6967c))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.20.0 ([#6376](#6376)) ([d6187ec](d6187ec))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.21.0 ([#6382](#6382)) ([5baea40](5baea40))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.22.0 ([#6516](#6516)) ([b7e4e73](b7e4e73))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.23.0 ([#6522](#6522)) ([ce24f1d](ce24f1d))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.24.1 ([#6553](#6553)) ([392b848](392b848))
* Remove broken `datadog_user_organizations` table ([#6561](#6561)) ([9cab6aa](9cab6aa))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit that referenced this pull request May 17, 2023
…10816)

This change:
 - restores the services codegen code accidentally removed in #6424. We are still relying on it for the generation of service interfaces and mocks
 - moves resolvers out of `_fetch.go` files into the main resource files, as is now standard practice
 - updates the contribution guide

There are no user-facing changes here, only refactoring and developer-facing changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants