chore(datadog): Move fetch functions, add back codegen for services#10816
Merged
kodiakhq[bot] merged 5 commits intomainfrom May 17, 2023
Merged
chore(datadog): Move fetch functions, add back codegen for services#10816kodiakhq[bot] merged 5 commits intomainfrom
kodiakhq[bot] merged 5 commits intomainfrom
Conversation
hermanschaaf
commented
May 16, 2023
| @@ -0,0 +1,188 @@ | |||
| package services | |||
Contributor
Author
There was a problem hiding this comment.
This file was just restored from the Git history, no changes
Contributor
Author
|
This relates to #10780, where it was reported that the contribution guide was out-of-date. Once we merge the services codegen back in and update the contribution guide, it should be possible to create new resources using the contribution guide again, so we can post an update in that ticket. |
1 task
candiduslynx
suggested changes
May 16, 2023
Contributor
candiduslynx
left a comment
There was a problem hiding this comment.
needs to point to plugin-sdk/v2, others are nits
| ### Before you Start | ||
| When adding support for new APIs, you may need to add a new service to the client. To do this: | ||
| 1. open `codegen/services/clients.go` and add the client from the Datadog SDK to the list of clients | ||
| 2. run `make gen-mocks` to generate the service interface and mocks |
Contributor
There was a problem hiding this comment.
Suggested change
| 2. run `make gen-mocks` to generate the service interface and mocks | |
| 2. Run `make gen-mocks` to generate the service interface and mocks |
Contributor
Author
There was a problem hiding this comment.
Updated, thanks for the suggestion
| "strings" | ||
| "text/template" | ||
|
|
||
| "github.com/cloudquery/plugin-sdk/caser" |
Contributor
There was a problem hiding this comment.
Suggested change
| "github.com/cloudquery/plugin-sdk/caser" | |
| "github.com/cloudquery/plugin-sdk/v2/caser" |
candiduslynx
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change:
_fetch.gofiles into the main resource files, as is now standard practiceThere are no user-facing changes here, only refactoring and developer-facing changes.