fix(aws): Migrate Grafana dashboards#2621
Merged
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom Oct 11, 2022
Merged
Conversation
erezrokah
approved these changes
Oct 11, 2022
disq
commented
Oct 11, 2022
| CASE WHEN EXISTS (SELECT 1 FROM information_schema.columns WHERE column_name='region' AND table_name=tbl) THEN 'region' ELSE E'\'unavailable\'' END, | ||
| CASE WHEN EXISTS (SELECT 1 FROM information_schema.columns WHERE column_name='tags' AND table_name=tbl) THEN 'tags' ELSE '''{}''::jsonb' END, | ||
| CASE WHEN EXISTS (SELECT 1 FROM information_schema.columns WHERE column_name='fetch_date' AND table_name=tbl) THEN 'fetch_date' ELSE 'NULL::timestamp' END, | ||
| CASE WHEN EXISTS (SELECT 1 FROM information_schema.columns WHERE column_name IN ('tags','tag_list','tag_set') AND table_name=tbl) THEN (SELECT column_name FROM information_schema.columns WHERE column_name IN ('tags','tag_list','tag_set') AND table_name=tbl LIMIT 1) ELSE '''{}''::jsonb' END, |
Member
Author
There was a problem hiding this comment.
Here new functionality was added to mitigate the issue with #2026
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
🤖 I have created a release *beep* *boop* --- ## [2.2.0](plugins-source-aws-v2.1.0...plugins-source-aws-v2.2.0) (2022-10-12) ### Features * Add support for EC2 reserved instances ([#1912](#1912)) ([42120a2](42120a2)) * Add Support for HSMv2 Clusters and Backups ([#2530](#2530)) ([b448bc6](b448bc6)) * Add Support For KMS Aliases ([#2528](#2528)) ([2e422dc](2e422dc)) ### Bug Fixes * **aws:** Migrate Grafana dashboards ([#2621](#2621)) ([438e439](438e439)) * **docs:** Add more info on adding Resource ([#2603](#2603)) ([9a29bbd](9a29bbd)) * Update AWS plugin to SDK v0.13.5 ([#2661](#2661)) ([a835034](a835034)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2183
All
cq_tablereferences were renamed to_cq_tablebecause we don't want the user to get confused about when to use the_cq(id, sync time...) and when it'scq_etc.I couldn't get the
route_assocvariable to work, but I don't think it was being used for anything meaningful except for the route table query.0c01533(#2621) fixes it by removingroute_assocandroute_tablevariables and using the subnet id directly.In my test env,
aws_ec2_route_tables.associations[].SubnetIdisnullfor some reason... could be a different issue or might need more testing.