feat: Add support for EC2 reserved instances#1912
Merged
kodiakhq[bot] merged 9 commits intomainfrom Oct 11, 2022
Merged
Conversation
Closed
Closed
disq
requested changes
Oct 7, 2022
plugins/source/aws/resources/services/ec2/reserved_instances_fetch.go
Outdated
Show resolved
Hide resolved
plugins/source/aws/resources/services/ec2/reserved_instances_fetch.go
Outdated
Show resolved
Hide resolved
bbernays
previously requested changes
Oct 7, 2022
Collaborator
bbernays
left a comment
There was a problem hiding this comment.
I think you need to add the function to plugins/source/aws/resources/plugin/tables.go and then add the docs
disq
approved these changes
Oct 10, 2022
plugins/source/aws/resources/services/ec2/reserved_instances_mock_test.go
Outdated
Show resolved
Hide resolved
…loudquery into feat-aws-reserved-instances
yevgenypats
approved these changes
Oct 10, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
🤖 I have created a release *beep* *boop* --- ## [2.2.0](plugins-source-aws-v2.1.0...plugins-source-aws-v2.2.0) (2022-10-12) ### Features * Add support for EC2 reserved instances ([#1912](#1912)) ([42120a2](42120a2)) * Add Support for HSMv2 Clusters and Backups ([#2530](#2530)) ([b448bc6](b448bc6)) * Add Support For KMS Aliases ([#2528](#2528)) ([2e422dc](2e422dc)) ### Bug Fixes * **aws:** Migrate Grafana dashboards ([#2621](#2621)) ([438e439](438e439)) * **docs:** Add more info on adding Resource ([#2603](#2603)) ([9a29bbd](9a29bbd)) * Update AWS plugin to SDK v0.13.5 ([#2661](#2661)) ([a835034](a835034)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for fetching EC2 reserved instances.
It is meant to address #1815, but please note that since this change is being applied to (the as-of-yet unreleased) CloudQuery v2, it will require upgrading to the new version once it is released.
I couldn't see a way to paginate through these results, so I hope that the API returns the full resultset for each region in the first call.