Skip to content

fix: ProgressBar output fix#2163

Merged
yevgenypats merged 2 commits intocloudquery:mainfrom
amanenk:fix_cli_output
Sep 30, 2022
Merged

fix: ProgressBar output fix#2163
yevgenypats merged 2 commits intocloudquery:mainfrom
amanenk:fix_cli_output

Conversation

@amanenk
Copy link
Copy Markdown
Contributor

@amanenk amanenk commented Sep 30, 2022 •
edited
Loading

Summary

progress bar now looks next:

Loading specs from directory:  .
Starting sync for:  aws -> [postgresql]
/ Syncing resources... (24/-, 4 resources/s) [6s] Fetch completed successfully.
Summary: Resources: 24, Failed Writes: 0, Fetch Errors: 0, Fetch Warnings: 0

Process finished with the exit code 0

before has resources/sec/min like on example below

Loading specs from directory:  .
Starting sync for:  gcp -> [postgresql]
- Syncing resources... (0/-, 0 resources/sec/min) [1s] Fetch completed successfully.
Summary: Resources: 0, Failed Writes: 0, Fetch Errors: 0, Fetch Warnings: 0

Process finished with the exit code 0

there is no way for now to remove /- after number but I have created an issue on their repo

@cq-bot cq-bot added the cli label Sep 30, 2022
@amanenk amanenk marked this pull request as ready for review September 30, 2022 14:31
@yevgenypats yevgenypats merged commit 85fbd58 into cloudquery:main Sep 30, 2022
@cq-bot cq-bot mentioned this pull request Sep 30, 2022
Merged
yevgenypats pushed a commit that referenced this pull request Sep 30, 2022
@cq-bot
chore(main): Release cli v1.3.0-pre.1 (#2164)
321aae9 
🤖 I have created a release *beep* *boop*
---


##
[1.3.0-pre.1](cli-v1.2.1-pre.1...cli-v1.3.0-pre.1)
(2022-09-30)


### Features

* **cli:** Use SourceClient and DestinationClient directly
([#2165](#2165))
([e594e61](e594e61))


### Bug Fixes

* ProgressBar output fix
([#2163](#2163))
([85fbd58](85fbd58))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@cq-bot cq-bot mentioned this pull request Sep 30, 2022
Merged
@erezrokah
Copy link
Copy Markdown
Member

erezrokah commented Oct 2, 2022

So I opened #1828 a while back and fixed it in #1829, but it was reverted in #2089.

cc @yevgenypats maybe we should consider bringing that fix back?

@erezrokah erezrokah mentioned this pull request Oct 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disq disq disq approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amanenk @erezrokah @disq @yevgenypats @cq-bot