Merged
Conversation
Spinner is already available in a progressbar library we use (https://github.com/schollz/progressbar). Also it incoproates the same spinners available in https://github.com/briandowns/spinner Also, this fixes a bug where cursor was disappearing in the spinner library
hermanschaaf
approved these changes
Sep 27, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
I also tested it out locally, looks good 👍
yevgenypats
pushed a commit
that referenced
this pull request
Sep 27, 2022
🤖 I have created a release *beep* *boop* --- ## [1.2.0-pre.1](cli-v1.1.0-pre.1...cli-v1.2.0-pre.1) (2022-09-27) ### Features * Remove spinner ([#2089](#2089)) ([5915181](5915181)) * Update SDK to v0.10.1 ([#2100](#2100)) ([d968032](d968032)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Member
|
The spinner we use displays a lot of redundant information and can't be configured, see screenshot for example:
I could find a way to remove This is described in #1828. |
Member
|
Re-opened #1828 for further discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spinner is already available in a progressbar
library we use (https://github.com/schollz/progressbar).
Also it incoproates the same spinners available in https://github.com/briandowns/spinner
Also, this fixes a bug where cursor was disappearing in the spinner library