test: Add test to validate progress reporting to API#21116
Merged
Conversation
disq
approved these changes
Jul 24, 2025
Member
Author
|
This test discovered another data race will fix it too |
20ff480 to
1eef07d
Compare
Member
Author
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
#### Summary Should fix the data race in #21116. Instead of using the `Done()` channel we can call the debounced function one last time. The data race is a known issue in the package, see vnteamopen/godebouncer#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #21108.
This was a bit tricky as we need to list and download plugins from the real API, and mock the progress reporting endpoint as we don't really have a sync run to report progress for.