fix: Concurrent map access when reporting remote progress#21108
Merged
kodiakhq[bot] merged 2 commits intomainfrom Jul 24, 2025
Merged
fix: Concurrent map access when reporting remote progress#21108kodiakhq[bot] merged 2 commits intomainfrom
kodiakhq[bot] merged 2 commits intomainfrom
Conversation
disq
approved these changes
Jul 24, 2025
erezrokah
commented
Jul 24, 2025
| Errors: int64(totals.Errors), | ||
| Warnings: int64(totals.Warnings), | ||
| Status: &status, | ||
| TableProgress: &statsPerTable, |
Member
Author
There was a problem hiding this comment.
The progress reporting runs in a separate Go routine than the sync one, hence the race
murarustefaan
approved these changes
Jul 24, 2025
erezrokah
pushed a commit
that referenced
this pull request
Jul 24, 2025
🤖 I have created a release *beep* *boop* --- ## [6.24.2](cli-v6.24.1...cli-v6.24.2) (2025-07-24) ### Bug Fixes * Concurrent map access when reporting remote progress ([#21108](#21108)) ([189a8c3](189a8c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah
added a commit
that referenced
this pull request
Jul 24, 2025
<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> #### Summary Follow up to #21108. This was a bit tricky as we need to list and download plugins from the real API, and mock the progress reporting endpoint as we don't really have a sync run to report progress for. <!-- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](https://github.com/cloudquery/cloudquery/blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Run `make lint` to ensure the proposed changes follow the coding style 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Run `make test` to ensure the proposed changes pass the tests 🧪 - [ ] If changing a source plugin run `make gen` to ensure docs are up to date 📝 - [ ] Ensure the status checks below are successful ✅ ---> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our race detection tests didn't catch this since we only report remote progress for sync runs API keys
cloudquery/cli/cmd/sync_v3.go
Line 89 in 0e0deec
I'll follow up with a test later