feat: Enable StateClient usage under docker plugins. #18880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
reviewed
Aug 8, 2024
cli/cmd/sync.go
Outdated
| managedplugin.WithTeamName(teamName), | ||
| managedplugin.WithLicenseFile(licenseFile), | ||
| } | ||
| if isThereADockerSourcePluginWithBackend { |
Member
There was a problem hiding this comment.
Shouldn't we do this only for destinations that are used as state?
Member
There was a problem hiding this comment.
Also a follow PR can be to update the logic to consider if the OS is Windows per #18039
Contributor
Author
There was a problem hiding this comment.
I made the following changes:
- UseTCP is more strict; only enabling it when the destination is used as state
- I propagated the state that a source
shouldReplaceLocalhostall the way toReplaceVariables. Before, it was replacing if a source had aRegistryDocker, which is not ideal because it doesn't necessarily need to use state. I don't think it's a bug because if it doesn't use a backend it probably doesn't need any replacing, but it's more correct now. - Added tests where possible.
Regarding the Windows edge case, I'd fix it separately (in another PR, as you say)
Contributor
Author
There was a problem hiding this comment.
(I re-ran the syncs in the OP; they still work)
erezrokah
approved these changes
Aug 9, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
🤖 I have created a release *beep* *boop* --- ## [6.4.0](cli-v6.3.0...cli-v6.4.0) (2024-08-13) ### Features * Enable StateClient usage under docker plugins. ([#18880](#18880)) ([2d542da](2d542da)) * Enable user to override `invocation_id` ([#18878](#18878)) ([3af7f5e](3af7f5e)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.12.7 ([#18865](#18865)) ([32a17d8](32a17d8)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.59.0 ([#18881](#18881)) ([8f7667f](8f7667f)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.60.0 ([#18922](#18922)) ([7626636](7626636)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StateClients currently don't work in docker-based plugins because they cannot connect to destination sockets.This CLI change detects that a source has:
Dockerregistry settingbackend_optionssetAnd in this case it makes the following config changes:
host.docker.internalextra host to the docker create configurationAs a result, normal syncs continue to work exactly the same as before, but syncs that suffered from this config problem now work seamlessly with the new settings:
(Note that I'm using an unreleased pb-go replace)