feat: Enable user to override invocation_id
#18878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
reviewed
Aug 7, 2024
disq
reviewed
Aug 7, 2024
disq
reviewed
Aug 7, 2024
disq
reviewed
Aug 7, 2024
disq
approved these changes
Aug 8, 2024
cli/cmd/root.go
Outdated
| f := cmd.PersistentFlags().VarPF(telemetryLevel, "telemetry-level", "", "Telemetry level (none, errors, stats, all)") | ||
| f.DefValue = "all" | ||
|
|
||
| iUUID := cmd.PersistentFlags().VarPF(&invocationUUID, "invocation-uuid", "", "useful for when using Open Telemetry integration for tracing and logging to be able to correlate logs and traces through many services") |
Member
There was a problem hiding this comment.
Very long description? Maybe just "override invocation UUID"?
erezrokah
reviewed
Aug 8, 2024
erezrokah
reviewed
Aug 8, 2024
erezrokah
reviewed
Aug 8, 2024
erezrokah
reviewed
Aug 8, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
🤖 I have created a release *beep* *boop* --- ## [6.4.0](cli-v6.3.0...cli-v6.4.0) (2024-08-13) ### Features * Enable StateClient usage under docker plugins. ([#18880](#18880)) ([2d542da](2d542da)) * Enable user to override `invocation_id` ([#18878](#18878)) ([3af7f5e](3af7f5e)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.12.7 ([#18865](#18865)) ([32a17d8](32a17d8)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.59.0 ([#18881](#18881)) ([8f7667f](8f7667f)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.60.0 ([#18922](#18922)) ([7626636](7626636)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When users want to connect traces to upstream calls they can use this to pass in an
invocation_idthat will be included in all logs and metrics