Merged
Conversation
roneli
suggested changes
Aug 30, 2021
Contributor
roneli
left a comment
There was a problem hiding this comment.
Looks good, not sure about the callback and maybe we should improve how the console UI reacts based on fetchcallback error.
e230a4e to
4fcf8c8
Compare
roneli
reviewed
Sep 2, 2021
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
Synced local file(s) with [cloudquery/.github](https://github.com/cloudquery/.github). --- This PR was created automatically by the [repo-file-sync-action](https://github.com/BetaHuhn/repo-file-sync-action) workflow run [#2527388580](https://github.com/cloudquery/.github/actions/runs/2527388580)
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
Synced local file(s) with [cloudquery/.github](https://github.com/cloudquery/.github). --- This PR was created automatically by the [repo-file-sync-action](https://github.com/BetaHuhn/repo-file-sync-action) workflow run [#2604403893](https://github.com/cloudquery/.github/actions/runs/2604403893)
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on cloudquery/cq-provider-sdk#76