This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Merged
Conversation
roneli
suggested changes
Aug 18, 2021
Contributor
roneli
left a comment
There was a problem hiding this comment.
Found some edge cases we missed, I really liked the implementation
roneli
approved these changes
Aug 20, 2021
Contributor
roneli
left a comment
There was a problem hiding this comment.
looking good, we just need to address the two final comments I believe, I will have another look at it after and we will be able to merge the PR.
1d30190 to
f9a15d5
Compare
roneli
suggested changes
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
More information regarding backwards compatibility testing: