feat!: Migrate Azure plugin to v2 by erezrokah · Pull Request #1754 · cloudquery/cloudquery

erezrokah · 2022-09-06T14:53:51Z

Summary

Uses codegen via go templates instead of mock-gen

Use the following steps to ensure your PR is ready to be reviewed

Read the contribution guidelines 🧑‍🎓
Test locally on your own infrastructure
Run go fmt to format your code 🖊
Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
Update or add tests 🧪
Ensure the status checks below are successful ✅

erezrokah · 2022-09-06T14:54:30Z

plugins/source/azure/client/services/ad.go

@@ -1,60 +0,0 @@
-//go:generate mockgen -destination=./mocks/ad_applications.go -package=mocks . ADApplicationsClient


Wasn't used

erezrokah · 2022-09-06T14:55:38Z

plugins/source/azure/client/services/authorization.go

@@ -1,4 +1,4 @@
-//go:generate mockgen -destination=./mocks/authorization.go -package=mocks . RoleAssignmentsClient,RoleDefinitionsClient
+//go:generate mockgen -destination=./mocks/authorization.go -package=mocks . AuthorizationRoleAssignmentsClient,AuthorizationRoleDefinitionsClient


Since all mocks are in the same package mocks we prefix clients with the service name to avoid collisions

erezrokah · 2022-09-06T14:56:45Z

plugins/source/azure/client/services/container.go

@@ -1,16 +1,18 @@
-//go:generate mockgen -destination=./mocks/containerregistry.go -package=mocks . ContainerRegistriesClient,ContainerReplicationsClient
+//go:generate mockgen -destination=./mocks/containerregistry.go -package=mocks . ContainerRegistriesClient,ContainerReplicationsClient,ContainerManagedClustersClient


Instead of containerregistry.go and containerservice.go I put both in the same container.go file

erezrokah · 2022-09-06T14:57:00Z

plugins/source/azure/client/services/containerservice.go

@@ -1,25 +0,0 @@
-//go:generate mockgen -destination=./mocks/containerservice.go -package=mocks . ManagedClustersClient


Moved to container.go file

erezrokah · 2022-09-06T14:58:32Z

plugins/source/azure/client/services/eventhub.go


-type EventHubClient interface {
+type EventHubClient struct {
+	Namespaces EventHubNamespacesClient


Some services didn't have the proper nesting so made code generation hard due to inconsistencies.
It was easier to fix the services than to create more templates

erezrokah · 2022-09-06T15:03:27Z

plugins/source/azure/client/services/front_door.go


-type FrontDoorClient interface {
+type FrontDoorClient struct {
+	Doors FrontDoorDoorsClient


The naming convention sometimes creates redundancy but I kept it to simplify code generation

erezrokah · 2022-09-06T15:04:12Z

plugins/source/azure/client/services/mocks/ad_applications.go

-// Source: github.com/cloudquery/cloudquery/plugins/source/azure/client/services (interfaces: ADApplicationsClient)
-
-// Package mocks is a generated GoMock package.
-package mocks


Wasn't used

erezrokah · 2022-09-06T15:04:53Z

plugins/source/azure/client/services/mocks/ad_groups.go

@@ -1,51 +0,0 @@
-// Code generated by MockGen. DO NOT EDIT.


Wasn't used

erezrokah · 2022-09-06T15:05:04Z

plugins/source/azure/client/services/mocks/ad_service_principals.go

@@ -1,51 +0,0 @@
-// Code generated by MockGen. DO NOT EDIT.


Wasn't used

erezrokah · 2022-09-06T15:05:14Z

plugins/source/azure/client/services/mocks/ad_users.go

@@ -1,51 +0,0 @@
-// Code generated by MockGen. DO NOT EDIT.


Wasn't used

erezrokah · 2022-09-06T15:08:44Z

plugins/source/azure/client/services/monitor.go

 		LogProfiles:        logProfiles,
 		ActivityLogs:       activityLogs,
 		DiagnosticSettings: diagnosticSettings,
+		Resources:          resourcesClient,


Moved resourcesClient from plugins/source/azure/client/services/resources.go as it's only used to get DiagnosticSettings.
I added a resources table under monitor package and made DiagnosticSettings a relation (more below)

erezrokah · 2022-09-06T15:09:35Z

plugins/source/azure/client/services/redis.go


-type RedisClient interface {
+type RedisClient struct {
+	ResourceTypes RedisResourceTypesClient


As others created the proper nesting

erezrokah · 2022-09-06T15:10:11Z

plugins/source/azure/client/services/resources.go

 	ls.Authorizer = auth
 	return ResourcesClient{
-		Groups:      groups,
-		Resources:   client,


Resources moved to plugins/source/azure/client/services/monitor.go as it's not used to get anything under the resources package

erezrokah · 2022-09-06T15:10:52Z

plugins/source/azure/client/services/search.go


 type SearchClient struct {
-	Service SearchServiceClient
+	Services SearchServicesClient


As in other places this change is to keep naming conventions consistent between services

erezrokah · 2022-09-06T15:12:14Z

plugins/source/azure/client/services/sql.go


-//go:generate mockgen -destination=./mocks/sql_server.go -package=mocks . SQLServerClient,SQLFirewallClient,SQLServerAdminClient,SQLServerBlobAuditingPolicies,SQLServerDevOpsAuditSettingsClient,SQLServerVulnerabilityAssessmentsClient,EncryptionProtectorsClient,SQLVirtualNetworkRulesClient,ServerSecurityAlertPoliciesClient
-type SQLServerClient interface {
+//go:generate mockgen -destination=./mocks/sql.go -package=mocks . SQLServersClient,SQLFirewallsClient,SQLServerAdminsClient,SQLServerBlobAuditingPoliciesClient,SQLServerDevOpsAuditSettingsClient,SQLServerVulnerabilityAssessmentsClient,SQLEncryptionProtectorsClient,SQLVirtualNetworkRulesClient,ServerSecurityAlertPoliciesClient,SQLDatabasesClient,SQLDatabaseBlobAuditingPoliciesClient,SQLDatabaseThreatDetectionPoliciesClient,SQLDatabaseVulnerabilityAssessmentsClient,SQLDatabaseVulnerabilityAssessmentScansClient,SQLTransparentDataEncryptionsClient,SQLBackupLongTermRetentionPoliciesClient,SQLManagedInstancesClient,SQLManagedInstanceVulnerabilityAssessmentsClient,SQLManagedInstanceEncryptionProtectorsClient,SQLManagedDatabasesClient,SQLManagedDatabaseVulnerabilityAssessmentsClient,SQLManagedDatabaseVulnerabilityAssessmentScansClient


Moved all the go:generate stuff to the same place.

The sql package has a lot of custom code so I didn't simplify it yet

erezrokah · 2022-09-06T15:16:51Z

plugins/source/azure/client/services/subscriptions.go

 		SubscriptionID: subscriptionId,
 		Subscriptions:  s,
 		Tenants:        t,
+		Locations:      s,


account/locations.go (see here) used the SubscriptionsClient which was a bit confusing.

I moved it under subscriptions/locations.go and added a separate SubscriptionsLocationsClient to make code generation easier and keep everything in a similar structure

erezrokah · 2022-09-06T15:18:31Z

plugins/source/azure/client/services/web.go

 	return WebClient{
-		Apps: apps,
+		Apps:             apps,
+		SiteAuthSettings: apps,


Again I created a new WebSiteAuthSettingsClient to keep things consistent instead of having auth settings use the apps client (see here)

erezrokah · 2022-09-06T15:19:07Z

plugins/source/azure/codegen/main.go

+	if len(os.Args) > 1 {
+		filter = os.Args[1]
+	}
+	pattern := regexp.MustCompile("(?i)" + filter)


Found it useful to be able to generate only a part of the resources

erezrokah · 2022-09-06T15:20:44Z

plugins/source/azure/codegen/main.go

+	providerResources := make(map[string]providerResource)
+	providerPackages := make(map[string]bool)
+
+	for _, r := range codegen.AllResources() {


I tried to keep this file as simple as possible and leave all resource creating logic under recipes/base.go

erezrokah · 2022-09-06T15:22:56Z

plugins/source/azure/codegen/recipes/base.go

+	Destination string
+}
+
+type Resource struct {


This is what is passes to the template engine

erezrokah · 2022-09-06T15:24:03Z

plugins/source/azure/codegen/recipes/base.go

+	imports           []string
+}
+
+type resourceDefinition struct {


This is the resource configuration. Has some duplication with Resource but I thought it would be easier to separate the 2 as Resource is a transformed version of resourceDefinition

erezrokah · 2022-09-06T15:24:38Z

plugins/source/azure/codegen/recipes/base.go

+
+func needsSubscriptionId(table *codegen.TableDefinition) bool {
+	for _, column := range table.Columns {
+		if column.Name == "subscription_id" {


Some resources have subscription_id column returned from the API so no need to resolve it

erezrokah · 2022-09-06T15:26:13Z

plugins/source/azure/codegen/recipes/compute.go

+				{
+					azureStruct:    &compute.Disk{},
+					listFunction:   "List",
+					mockListResult: "DiskList",


Some APIs have inconsistent naming so we need to override them in the tests

erezrokah · 2022-09-06T15:28:21Z

plugins/source/azure/codegen/recipes/keyvault.go

+				{
+					azureStruct:          &hsmKeyValue.ManagedHsm{},
+					listFunction:         "ListBySubscription",
+					listFunctionArgs:     []string{"&maxResults"},


Some list functions need additional arguments

erezrokah · 2022-09-06T15:29:03Z

plugins/source/azure/codegen/recipes/cosmosdb.go

+					listHandler:        valueHandler,
+					subServiceOverride: "Accounts",
+					mockListResult:     "DatabaseAccountsListResult",
+					relations:          []string{"MongoDBDatabases(),SQLDatabases()"},


MongoDBDatabases and SQLDatabases are generated below

erezrokah · 2022-09-06T15:29:47Z

plugins/source/azure/codegen/recipes/cosmosdb.go

+					listFunction:       "ListMongoDBDatabases",
+					listHandler:        valueHandler,
+					subServiceOverride: "MongoDBDatabases",
+					listFunctionArgsInit: []string{`account := parent.Item.(documentdb.DatabaseAccountGetResults)


We get the account id and name from the parent so we can list the relation

erezrokah · 2022-09-06T15:30:25Z

plugins/source/azure/codegen/recipes/mariadb.go

+				{
+					azureStruct:  &mariadb.Server{},
+					listFunction: "List",
+					listHandler:  valueHandler,


Some APIs return a paginated list and some a non paginated list. valueHandler is a handler for the non paginated list

erezrokah · 2022-09-06T15:31:18Z

plugins/source/azure/codegen/recipes/monitor.go

+					}`},
+					mockListResult:           "EventDataCollection",
+					mockListFunctionArgs:     []string{"regexMatcher{filterRe}", `""`},
+					mockListFunctionArgsInit: []string{"filterRe := regexp.MustCompile(`eventTimestamp ge '\\d{4}-\\d\\d-\\d\\dT\\d\\d:\\d\\d:\\d\\d(\\.\\d+)Z' and eventTimestamp le '\\d{4}-\\d\\d-\\d\\dT\\d\\d:\\d\\d:\\d\\d(\\.\\d+)Z'`)"},


This is a bit ugly since we want to match a timestamp in the tests

erezrokah · 2022-09-06T15:32:19Z

plugins/source/azure/codegen/recipes/datalake.go

+					azureStruct:      &analytics.DataLakeAnalyticsAccount{},
+					listFunction:     "List",
+					listFunctionArgs: []string{`""`, `nil`, `nil`, `""`, `""`, `nil`},
+					getFunction:      "Get",


Example of a list/details pattern

erezrokah · 2022-09-06T15:34:04Z

plugins/source/azure/codegen/recipes/security.go

+						Type:     schema.TypeBool,
+						Resolver: "resolveEnabled",
+					}},
+					helpers: []string{`func resolveEnabled(ctx context.Context, meta schema.ClientMeta, resource *schema.Resource, c schema.Column) error {


This is a bit tricky as there are multiple types of settings, only 2 has the Enabled field so we need a custom resolved that checks for the type

erezrokah · 2022-09-18T06:45:02Z

2. Im worried about resolvers auto generation as it makes it harder to change and contribute in some places (Im ok with mock tests where it's vanila generation). I don't think we need to change anything now and it will be interesting to compare the developer experience as we go in azure where we generate everything vs all other plugins where we generate only the tables. So just something to keep and eye on.

Yes I agree and I think another iteration that makes sense for Azure (and also other plugins), is when we have inconsistent APIs and this makes auto generation hard, instead of having a _fetch with custom code, move the custom code under the services package and wrap it with an easy to generate API, for example:
https://github.com/erezrokah/cloudquery/blob/1171096bd4e56850cffb8119a326e96c1a04def6/plugins/source/azure/client/services/storage.go#L57
https://github.com/erezrokah/cloudquery/blob/1171096bd4e56850cffb8119a326e96c1a04def6/plugins/source/azure/client/services/web.go#L52
That should make code gen easier see https://github.com/erezrokah/cloudquery/blob/1171096bd4e56850cffb8119a326e96c1a04def6/plugins/source/azure/resources/services/web/publishing_profiles.go#L52 vs

cloudquery/plugins/source/azure/resources/services/web/apps.go

Line 560 in af9129e

    
           func fetchWebAppPublishingProfiles(ctx context.Context, meta schema.ClientMeta, parent *schema.Resource, res chan<- interface{}) error {

, or https://github.com/erezrokah/cloudquery/blob/1171096bd4e56850cffb8119a326e96c1a04def6/plugins/source/azure/resources/services/storage/accounts.go#L234 vs

cloudquery/plugins/source/azure/resources/services/storage/accounts.go

Line 863 in af9129e

storageClient := meta.(*client.Client).Services().Storage

erezrokah · 2022-09-18T06:52:25Z

do_not_run_extensions_on_overprovisioned_v_ms
ResourceURI in multiple places (needs to be referred as "ResourceURI" in SQL)
azure_compute_virtual_machine_scale_sets.host is missing, no way to get to the vm id? but azure_compute_virtual_machine_extensions contains compute_virtual_machine_id and no reference to scale set.

Thanks @disq, I'm going to do a fast follow PR with these fixed as this PR is already huge

🤖 I have created a release *beep* *boop* --- ## [0.14.0-pre.0](plugins/source/azure-v0.13.4-pre.0...plugins/source/azure/v0.14.0-pre.0) (2022-09-21) ### ⚠ BREAKING CHANGES * Migrate Azure plugin to v2 (#1754) * Fix Azure credential chain (#1283) ### Features * Add website, docs and blog to our main repo ([#1159](#1159)) ([dd69948](dd69948)) * Added azure cdn profiles ([#1460](#1460)) ([cc154c5](cc154c5)) * Migrate Azure plugin to v2 ([#1754](#1754)) ([ee9bef2](ee9bef2)) ### Bug Fixes * **deps:** Update golang.org/x/sync digest to 7fc1605 ([#1652](#1652)) ([daafae1](daafae1)) * **deps:** Update module github.com/Azure/azure-sdk-for-go/sdk/azcore to v1.1.2 ([#1664](#1664)) ([5390e13](5390e13)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.10 ([#1474](#1474)) ([b142e13](b142e13)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.11 ([#1491](#1491)) ([5140bef](5140bef)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.12 ([#1503](#1503)) ([a740719](a740719)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.9 ([#1286](#1286)) ([67ac422](67ac422)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.3 ([#1858](#1858)) ([9e3ace7](9e3ace7)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.4 ([#1862](#1862)) ([5d141cf](5d141cf)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.1 ([#1865](#1865)) ([474bb70](474bb70)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.2 ([#1872](#1872)) ([49ed26d](49ed26d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.3 ([#1886](#1886)) ([7435d59](7435d59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.4 ([#1889](#1889)) ([63a5362](63a5362)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.9 ([#1891](#1891)) ([3469f20](3469f20)) * Fix Azure credential chain ([#1283](#1283)) ([c2aadf7](c2aadf7)) * Generate Azure date.time as Timestamps ([#1885](#1885)) ([92d41a1](92d41a1)) * Regenerate Azure resources ([#1875](#1875)) ([7411a27](7411a27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [1.0.0-pre.0](plugins-source-azure-v0.14.2-pre.0...plugins-source-azure-v1.0.0-pre.0) (2022-09-26) ### ⚠ BREAKING CHANGES * Migrate Azure plugin to v2 (#1754) * Fix Azure credential chain (#1283) ### Features * Add website, docs and blog to our main repo ([#1159](#1159)) ([dd69948](dd69948)) * Added azure cdn profiles ([#1460](#1460)) ([cc154c5](cc154c5)) * Migrate Azure plugin to v2 ([#1754](#1754)) ([ee9bef2](ee9bef2)) ### Bug Fixes * Add missing `azure_keyvault_secrets` tables ([#1937](#1937)) ([491aa66](491aa66)) * **deps:** Update golang.org/x/sync digest to 7fc1605 ([#1652](#1652)) ([daafae1](daafae1)) * **deps:** Update module github.com/Azure/azure-sdk-for-go/sdk/azcore to v1.1.2 ([#1664](#1664)) ([5390e13](5390e13)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.10 ([#1474](#1474)) ([b142e13](b142e13)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.11 ([#1491](#1491)) ([5140bef](5140bef)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.12 ([#1503](#1503)) ([a740719](a740719)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.3 ([#1858](#1858)) ([9e3ace7](9e3ace7)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.4 ([#1862](#1862)) ([5d141cf](5d141cf)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.1 ([#1865](#1865)) ([474bb70](474bb70)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.2 ([#1872](#1872)) ([49ed26d](49ed26d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.3 ([#1886](#1886)) ([7435d59](7435d59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.4 ([#1889](#1889)) ([63a5362](63a5362)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.9 ([#1891](#1891)) ([3469f20](3469f20)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.0 ([#1997](#1997)) ([4fa40da](4fa40da)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.1 ([#2024](#2024)) ([8f88de4](8f88de4)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.2 ([#2044](#2044)) ([9b69b46](9b69b46)) * Fix Azure credential chain ([#1283](#1283)) ([c2aadf7](c2aadf7)) * Generate Azure date.time as Timestamps ([#1885](#1885)) ([92d41a1](92d41a1)) * Regenerate Azure resources ([#1875](#1875)) ([7411a27](7411a27)) * Update Azure codegen ([#1936](#1936)) ([4b739db](4b739db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

erezrokah commented Sep 6, 2022

View reviewed changes

erezrokah added 16 commits September 18, 2022 09:36

test: Finish tests

018859a

fix: Update SDK

3a34dce

doc: Add docs to website

e9a7d62

fix: Update to new SDK, fix configuration

fc41e62

refactor: Remove error wrapping

c5ce890

test: Fix tests

cf1041e

chore: Embed exmaple as yml file

0f5c4e8

chore: Update Sentry DSN

f1d7049

chore: Generate correct parent ID column names

da8c308

chore: Update SDK and regenerate resources

7194671

chore: Fix lint errors

0ad08c8

docs: Update docs

4c9c7a9

fix: Resources diagnostics settings

93b7f1f

fix: Always resolve subscription ID

6b40a9c

fix: Diagnostic settings column name

9ba44f9

chore: Remove unused code

1b44033

erezrokah force-pushed the chore/codegen_azure_v3 branch from 1171096 to 1b44033 Compare September 18, 2022 06:47

erezrokah merged commit ee9bef2 into cloudquery:main Sep 18, 2022

cq-bot mentioned this pull request Sep 18, 2022

chore(main): Release plugins/source/azure v0.14.0-pre.0 #1839

Merged

This was referenced Sep 19, 2022

chore: Bring back Azure tables #1874

Merged

fix: Regenerate Azure resources #1875

Merged

This was referenced Sep 22, 2022

chore(main): Release plugins-source-azure v0.15.0-pre.0 #1966

Closed

chore(main): Release plugins-source-azure v1.0.0-pre.0 #2086

Merged

This was referenced Oct 4, 2022

chore(main): Release plugins-source-azure v1.0.0 #2330

Merged

chore(main): Release plugins-source-azure v2.0.0 #2349

Closed

erezrokah deleted the chore/codegen_azure_v3 branch December 15, 2023 10:13

		@@ -1,60 +0,0 @@
		//go:generate mockgen -destination=./mocks/ad_applications.go -package=mocks . ADApplicationsClient

		@@ -1,4 +1,4 @@
		//go:generate mockgen -destination=./mocks/authorization.go -package=mocks . RoleAssignmentsClient,RoleDefinitionsClient
		//go:generate mockgen -destination=./mocks/authorization.go -package=mocks . AuthorizationRoleAssignmentsClient,AuthorizationRoleDefinitionsClient

		@@ -1,16 +1,18 @@
		//go:generate mockgen -destination=./mocks/containerregistry.go -package=mocks . ContainerRegistriesClient,ContainerReplicationsClient
		//go:generate mockgen -destination=./mocks/containerregistry.go -package=mocks . ContainerRegistriesClient,ContainerReplicationsClient,ContainerManagedClustersClient

		@@ -1,25 +0,0 @@
		//go:generate mockgen -destination=./mocks/containerservice.go -package=mocks . ManagedClustersClient

Conversation

erezrokah commented Sep 6, 2022

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erezrokah Sep 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erezrokah commented Sep 18, 2022

Uh oh!

erezrokah commented Sep 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

erezrokah Sep 6, 2022 •

edited

Loading