Skip to content

fix: Generate Azure date.time as Timestamps#1885

Merged
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
erezrokah:fix/azure_writes
Sep 21, 2022
Merged

fix: Generate Azure date.time as Timestamps#1885
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
erezrokah:fix/azure_writes

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah commented Sep 20, 2022 •
edited
Loading

Summary

Depends on cloudquery/plugin-sdk#139.
Fixes #1826

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Test locally on your own infrastructure
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@erezrokah erezrokah requested review from a team and amanenk and removed request for a team September 20, 2022 07:12
@github-actions github-actions bot added the azure label Sep 20, 2022
@erezrokah erezrokah mentioned this pull request Sep 20, 2022
Closed
5 tasks
@erezrokah erezrokah mentioned this pull request Sep 20, 2022
Closed
amanenk
amanenk approved these changes Sep 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@amanenk amanenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erezrokah
Copy link
Copy Markdown
Member Author

erezrokah commented Sep 21, 2022

I removed the code generation changes so this PR compiles until we release cloudquery/plugin-sdk#139 to unblock this fix.

Once we release the SDK PR I'll add the code gen changes that resulted in this PR

@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Sep 21, 2022
@kodiakhq kodiakhq bot merged commit 92d41a1 into cloudquery:main Sep 21, 2022
@cq-bot cq-bot mentioned this pull request Sep 21, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Sep 21, 2022
@cq-bot
chore(main): Release plugins/source/azure v0.14.0-pre.0 (#1839)
bd19a3a 
🤖 I have created a release *beep* *boop*
---


## [0.14.0-pre.0](plugins/source/azure-v0.13.4-pre.0...plugins/source/azure/v0.14.0-pre.0) (2022-09-21)


### ⚠ BREAKING CHANGES

* Migrate Azure plugin to v2 (#1754)
* Fix Azure credential chain (#1283)

### Features

* Add website, docs and blog to our main repo ([#1159](#1159)) ([dd69948](dd69948))
* Added azure cdn profiles ([#1460](#1460)) ([cc154c5](cc154c5))
* Migrate Azure plugin to v2 ([#1754](#1754)) ([ee9bef2](ee9bef2))


### Bug Fixes

* **deps:** Update golang.org/x/sync digest to 7fc1605 ([#1652](#1652)) ([daafae1](daafae1))
* **deps:** Update module github.com/Azure/azure-sdk-for-go/sdk/azcore to v1.1.2 ([#1664](#1664)) ([5390e13](5390e13))
* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.10 ([#1474](#1474)) ([b142e13](b142e13))
* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.11 ([#1491](#1491)) ([5140bef](5140bef))
* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.12 ([#1503](#1503)) ([a740719](a740719))
* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.9 ([#1286](#1286)) ([67ac422](67ac422))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.3 ([#1858](#1858)) ([9e3ace7](9e3ace7))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.4 ([#1862](#1862)) ([5d141cf](5d141cf))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.1 ([#1865](#1865)) ([474bb70](474bb70))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.2 ([#1872](#1872)) ([49ed26d](49ed26d))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.3 ([#1886](#1886)) ([7435d59](7435d59))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.4 ([#1889](#1889)) ([63a5362](63a5362))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.9 ([#1891](#1891)) ([3469f20](3469f20))
* Fix Azure credential chain ([#1283](#1283)) ([c2aadf7](c2aadf7))
* Generate Azure date.time as Timestamps ([#1885](#1885)) ([92d41a1](92d41a1))
* Regenerate Azure resources ([#1875](#1875)) ([7411a27](7411a27))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@erezrokah erezrokah mentioned this pull request Sep 21, 2022
Merged
6 tasks
erezrokah added a commit that referenced this pull request Sep 22, 2022
@erezrokah
fix: Update Azure codegen (#1936)
4b739db 
Fixes Azure code gen to handle custom types `date.time` and `uuid.UUID`
(the changes for `data.time` are included in
#1885)
This was referenced Sep 22, 2022
Closed
Merged
yevgenypats pushed a commit that referenced this pull request Sep 26, 2022
@cq-bot
chore(main): Release plugins-source-azure v1.0.0-pre.0 (#2086)
2d97b33 
🤖 I have created a release *beep* *boop*
---


##
[1.0.0-pre.0](plugins-source-azure-v0.14.2-pre.0...plugins-source-azure-v1.0.0-pre.0)
(2022-09-26)


### ⚠ BREAKING CHANGES

* Migrate Azure plugin to v2 (#1754)
* Fix Azure credential chain (#1283)

### Features

* Add website, docs and blog to our main repo
([#1159](#1159))
([dd69948](dd69948))
* Added azure cdn profiles
([#1460](#1460))
([cc154c5](cc154c5))
* Migrate Azure plugin to v2
([#1754](#1754))
([ee9bef2](ee9bef2))


### Bug Fixes

* Add missing `azure_keyvault_secrets` tables
([#1937](#1937))
([491aa66](491aa66))
* **deps:** Update golang.org/x/sync digest to 7fc1605
([#1652](#1652))
([daafae1](daafae1))
* **deps:** Update module github.com/Azure/azure-sdk-for-go/sdk/azcore
to v1.1.2
([#1664](#1664))
([5390e13](5390e13))
* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.10
([#1474](#1474))
([b142e13](b142e13))
* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.11
([#1491](#1491))
([5140bef](5140bef))
* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.12
([#1503](#1503))
([a740719](a740719))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.3
([#1858](#1858))
([9e3ace7](9e3ace7))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.4
([#1862](#1862))
([5d141cf](5d141cf))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.1
([#1865](#1865))
([474bb70](474bb70))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.2
([#1872](#1872))
([49ed26d](49ed26d))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.3
([#1886](#1886))
([7435d59](7435d59))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.4
([#1889](#1889))
([63a5362](63a5362))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.9
([#1891](#1891))
([3469f20](3469f20))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.0
([#1997](#1997))
([4fa40da](4fa40da))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.1
([#2024](#2024))
([8f88de4](8f88de4))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.2
([#2044](#2044))
([9b69b46](9b69b46))
* Fix Azure credential chain
([#1283](#1283))
([c2aadf7](c2aadf7))
* Generate Azure date.time as Timestamps
([#1885](#1885))
([92d41a1](92d41a1))
* Regenerate Azure resources
([#1875](#1875))
([7411a27](7411a27))
* Update Azure codegen
([#1936](#1936))
([4b739db](4b739db))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Oct 4, 2022
Merged
Closed
@erezrokah erezrokah deleted the fix/azure_writes branch December 15, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@yevgenypats yevgenypats yevgenypats approved these changes

@amanenk amanenk amanenk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug(v2): Failure to write some resources

3 participants

@erezrokah @yevgenypats @amanenk