fix: Don't error on ECR repositories when they're missing Lifecycle policies (aws_ecr_repository_lifecycle_policies)#14730
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Oct 19, 2023
Conversation
…olicies (`aws_ecr_repository_lifecycle_policies`)
bbernays
approved these changes
Oct 19, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
🤖 I have created a release *beep* *boop* --- ## [22.15.2](plugins-source-aws-v22.15.1...plugins-source-aws-v22.15.2) (2023-10-20) ### Bug Fixes * Don't error on ECR repositories when they're missing Lifecycle policies (`aws_ecr_repository_lifecycle_policies`) ([#14730](#14730)) ([352d46d](352d46d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
…olicies (`aws_ecr_repository_lifecycle_policies`) (cloudquery#14730) #### Summary Similar to cloudquery#14726 . We're calling `GetLifecyclePolicy` for every ECR repository in account and this API will throw an error if a Lifecycle is not configured for said ECR Repository. ``` 3:46PM ERR table resolver finished with error error="operation error ECR: GetLifecyclePolicy, https response error StatusCode: 400, RequestID:(redacted), LifecyclePolicyNotFoundException: Lifecycle policy does not exist for the repository with name '(redacted)' in the registry with id '(redacted)'" client=(redacted) module=aws-src table=aws_ecr_repository_lifecycle_policies ``` I don't think we should treat this as an error from Cloudquerys perspective. <!--
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
🤖 I have created a release *beep* *boop* --- ## [22.15.2](cloudquery/cloudquery@plugins-source-aws-v22.15.1...plugins-source-aws-v22.15.2) (2023-10-20) ### Bug Fixes * Don't error on ECR repositories when they're missing Lifecycle policies (`aws_ecr_repository_lifecycle_policies`) ([cloudquery#14730](cloudquery#14730)) ([352d46d](cloudquery@352d46d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Similar to #14726 . We're calling
GetLifecyclePolicyfor every ECR repository in account and this API will throw an error if a Lifecycle is not configured for said ECR Repository.I don't think we should treat this as an error from Cloudquerys perspective.