fix: Don't error on ECR repositories when they're missing Lifecycle policies (aws_ecr_repository_lifecycle_policies) (#14730)

AshCorr · web-flow · commit 352d46d78432 · 2023-10-19T22:49:56.000Z
#### Summary Similar to #14726 . We're calling `GetLifecyclePolicy` for every ECR repository in account and this API will throw an error if a Lifecycle is not configured for said ECR Repository. ``` 3:46PM ERR table resolver finished with error error="operation error ECR: GetLifecyclePolicy, https response error StatusCode: 400, RequestID:(redacted), LifecyclePolicyNotFoundException: Lifecycle policy does not exist for the repository with name '(redacted)' in the registry with id '(redacted)'" client=(redacted) module=aws-src table=aws_ecr_repository_lifecycle_policies ``` I don't think we should treat this as an error from Cloudquerys perspective. <!--
diff --git a/plugins/source/aws/resources/services/ecr/lifecycle_policy.go b/plugins/source/aws/resources/services/ecr/lifecycle_policy.go
@@ -38,6 +38,9 @@ func fetchRepositoryLifecyclePolicy(ctx context.Context, meta schema.ClientMeta,
 		options.Region = cl.Region
 	})
 	if err != nil {
+		if client.IsAWSError(err, "LifecyclePolicyNotFound") {
+			return nil
+		}
 		return err
 	}
 	res <- resp
