Skip to content

feat(resources): Add gcp_compute_osconfig_inventories table#13309

Merged
kodiakhq[bot] merged 5 commits intomainfrom
feat/gcp/osconfig-inventories
Aug 24, 2023
Merged

feat(resources): Add gcp_compute_osconfig_inventories table#13309
kodiakhq[bot] merged 5 commits intomainfrom
feat/gcp/osconfig-inventories

Conversation

@candiduslynx
Copy link
Copy Markdown
Contributor

@candiduslynx candiduslynx commented Aug 24, 2023 •
edited
Loading

Fixes #13301

Multiplex changes were made as listing inventories requires location param

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 24, 2023 •
edited
Loading

This PR has the following changes to source plugin(s) tables:

  • Table gcp_compute_osconfig_inventories was added

@erezrokah erezrokah self-assigned this Aug 24, 2023
erezrokah
erezrokah reviewed Aug 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @candiduslynx.
We usually don't discover a specific service locations during client initialization, since it doesn't allow users to filter those API calls. That is we will get the locations even if a user doesn't sync that table.

I would first try /locations/- or /locations/global to see if that works to return all instances, and if not, make instances a relation of locations, see example in https://github.com/cloudquery/cloudquery/blob/c51bd0bebb377329c99da7eb917c39f2ac49f294/plugins/source/gcp/resources/services/run/locations.go or https://github.com/cloudquery/cloudquery/blob/c51bd0bebb377329c99da7eb917c39f2ac49f294/plugins/source/gcp/resources/services/aiplatform/pipeline_locations.go

@erezrokah
Copy link
Copy Markdown
Member

erezrokah commented Aug 24, 2023 •
edited
Loading

I think the only place we've used ProjectLocationMultiplexEnabledServices until now is for an API that doesn't support listing those so we hard code them (see

cloudquery/plugins/source/gcp/resources/services/vision/products.go

Line 17 in c51bd0b

Multiplex: client.ProjectLocationMultiplexEnabledServices("vision.googleapis.com",
)

@candiduslynx candiduslynx force-pushed the feat/gcp/osconfig-inventories branch from c4df514 to 21b3396 Compare August 24, 2023 10:55
@candiduslynx candiduslynx changed the title feat(resources): Add gcp_osconfig_inventories table feat(resources): Add gcp_compute_osconfig_inventories table Aug 24, 2023
@candiduslynx candiduslynx requested a review from erezrokah August 24, 2023 11:15
@candiduslynx candiduslynx force-pushed the feat/gcp/osconfig-inventories branch from 1122dfe to 679d40e Compare August 24, 2023 11:18
@candiduslynx
Copy link
Copy Markdown
Contributor Author

candiduslynx commented Aug 24, 2023

@erezrokah I've moved the resource to be a child table of gcp_compute_zones

erezrokah
erezrokah reviewed Aug 24, 2023
View reviewed changes
@candiduslynx candiduslynx force-pushed the feat/gcp/osconfig-inventories branch from 679d40e to 5561619 Compare August 24, 2023 11:30
@candiduslynx candiduslynx requested a review from erezrokah August 24, 2023 11:30
erezrokah
erezrokah reviewed Aug 24, 2023
View reviewed changes
@candiduslynx candiduslynx force-pushed the feat/gcp/osconfig-inventories branch from 5561619 to 9e56da6 Compare August 24, 2023 11:33
@candiduslynx candiduslynx requested a review from erezrokah August 24, 2023 11:33
@candiduslynx candiduslynx added the automerge Automatically merge once required checks pass label Aug 24, 2023
@kodiakhq kodiakhq bot merged commit 08ea377 into main Aug 24, 2023
@kodiakhq kodiakhq bot deleted the feat/gcp/osconfig-inventories branch August 24, 2023 11:40
@cq-bot cq-bot mentioned this pull request Aug 24, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Aug 24, 2023
@cq-bot
chore(main): Release plugins-source-gcp v9.5.0 (#13161)
5619fb1 
🤖 I have created a release *beep* *boop*
---


## [9.5.0](plugins-source-gcp-v9.4.5...plugins-source-gcp-v9.5.0) (2023-08-24)


### This Release has the Following Changes to Tables
- Table `gcp_compute_osconfig_inventories` was added

### Features

* **resources:** Add `gcp_compute_osconfig_inventories` table ([#13309](#13309)) ([08ea377](08ea377))


### Bug Fixes

* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 5b83d4f ([#13203](#13203)) ([b0a4b8c](b0a4b8c))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.1 ([#13195](#13195)) ([a184c37](a184c37))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.2 ([#13262](#13262)) ([5c55aa3](5c55aa3))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.5 ([#13285](#13285)) ([e076abd](e076abd))
* **resources:** Link to Go docs in `gcp_storage_buckets` ([#13160](#13160)) ([3d40f5b](3d40f5b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erezrokah erezrokah erezrokah approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

@disq disq Awaiting requested review from disq

@hermanschaaf hermanschaaf Awaiting requested review from hermanschaaf

Assignees

@erezrokah erezrokah

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Add gcp_compute_osconfig_inventories to gcp source plugin

3 participants

@candiduslynx @erezrokah @cq-bot