fix(resources): Link to Go docs in gcp_storage_buckets#13160
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Aug 16, 2023
Merged
fix(resources): Link to Go docs in gcp_storage_buckets#13160kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
gcp_storage_buckets#13160kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
gcp_storage_bucketsgcp_storage_buckets
candiduslynx
approved these changes
Aug 16, 2023
Contributor
|
Maybe it should be |
Member
Author
This is a user facing change since if someone tries to generate the tables for the plugin they'll see a different description, hence the |
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
🤖 I have created a release *beep* *boop* --- ## [9.5.0](plugins-source-gcp-v9.4.5...plugins-source-gcp-v9.5.0) (2023-08-24) ### This Release has the Following Changes to Tables - Table `gcp_compute_osconfig_inventories` was added ### Features * **resources:** Add `gcp_compute_osconfig_inventories` table ([#13309](#13309)) ([08ea377](08ea377)) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 5b83d4f ([#13203](#13203)) ([b0a4b8c](b0a4b8c)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.1 ([#13195](#13195)) ([a184c37](a184c37)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.2 ([#13262](#13262)) ([5c55aa3](5c55aa3)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.5 ([#13285](#13285)) ([e076abd](e076abd)) * **resources:** Link to Go docs in `gcp_storage_buckets` ([#13160](#13160)) ([3d40f5b](3d40f5b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context in https://discord.com/channels/872925471417962546/1141351009545879612/1141361426284425246.
The GO SDK for buckets doesn't mimic the JSON API, they have a different object struct for some reason, see https://github.com/googleapis/google-cloud-go/blob/fbe78a28e01043b059e86c6e960d092b299ac9a4/storage/bucket.go#L753
Not sure why they wrap is and normalize some properties instead of retuning the raw bucket (which they have).
This PR links to the Go docs instead of the JSON API docs so it's easier to understand the data CloudQuery sync