fix: AWS foundational security controls for S3.8 query reference#13065
Merged
kodiakhq[bot] merged 5 commits intomainfrom Aug 15, 2023
Merged
fix: AWS foundational security controls for S3.8 query reference#13065kodiakhq[bot] merged 5 commits intomainfrom
kodiakhq[bot] merged 5 commits intomainfrom
Conversation
2 tasks
jsonpr
suggested changes
Aug 15, 2023
Contributor
jsonpr
left a comment
There was a problem hiding this comment.
Good update. Let's keep the control consistent with Foundational Security Best Practices Naming. In this case, S3 Block Public Access setting should be enabled at the bucket-level
That will require a change to https://github.com/cloudquery/cloudquery/blob/main/plugins/source/aws/policies/queries/s3/bucket_level_public_access_blocks.sql
jsonpr
approved these changes
Aug 15, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
🤖 I have created a release *beep* *boop* --- ## [22.7.0](plugins-source-aws-v22.6.0...plugins-source-aws-v22.7.0) (2023-08-21) ### Features * Instantiate services at sync time rather than during init phase of sync ([#13059](#13059)) ([99e6889](99e6889)) ### Bug Fixes * AWS foundational security controls for S3.8 query reference ([#13065](#13065)) ([7cde3d2](7cde3d2)), closes [#13064](#13064) * **deps:** Update AWS modules ([#13246](#13246)) ([49ee475](49ee475)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 5b83d4f ([#13203](#13203)) ([b0a4b8c](b0a4b8c)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.1 ([#13195](#13195)) ([a184c37](a184c37)) * Panic while fetching `aws_codecommit_repositories` ([#13223](#13223)) ([4d9bcc1](4d9bcc1)) * Remove unused query ([#13152](#13152)) ([f050699](f050699)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13064