Skip to content

bug: duplication in AWS foundational security controls for S3 #13064

@obormot

Description

@obormot

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently in cloudquery/plugins/source/aws/policies/foundational_security/s3.sql checks S3.1 and S3.8 refer to the same include file:

\set check_id 'S3.1'
\echo "Executing check S3.1"
\ir ../queries/s3/account_level_public_access_blocks.sql       <-- correct

\set check_id 'S3.2'
\echo "Executing check S3.2"
\ir ../queries/s3/publicly_readable_buckets.sql

[..skip..]

\set check_id 'S3.8'
\echo "Executing check S3.8"
\ir ../queries/s3/account_level_public_access_blocks.sql     <-- duplicate

Expected Behavior

According to https://docs.aws.amazon.com/securityhub/latest/userguide/s3-controls.html :

[S3.8] S3 Block Public Access setting should be enabled at the bucket-level

..so I believe the correct file to include should be s3/bucket_level_public_access_blocks.sql
ie. bucket instead of the (duplicated) account

CloudQuery (redacted) config

N/A

Steps To Reproduce

No response

CloudQuery (redacted) logs

N/A

CloudQuery version

(I actually don't know)

Additional Context

No response

Pull request (optional)

  • I can submit a pull request

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions