fix!: Fix Azure credential chain#1283
Merged
yevgenypats merged 5 commits intocloudquery:mainfrom Aug 15, 2022
Merged
Conversation
|
@hermanschaaf is attempting to deploy a commit to the cloudquery Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
7 tasks
erezrokah
approved these changes
Aug 15, 2022
This was referenced Aug 15, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
🤖 I have created a release *beep* *boop* --- ## [0.14.0-pre.0](plugins/source/azure-v0.13.4-pre.0...plugins/source/azure/v0.14.0-pre.0) (2022-09-21) ### ⚠ BREAKING CHANGES * Migrate Azure plugin to v2 (#1754) * Fix Azure credential chain (#1283) ### Features * Add website, docs and blog to our main repo ([#1159](#1159)) ([dd69948](dd69948)) * Added azure cdn profiles ([#1460](#1460)) ([cc154c5](cc154c5)) * Migrate Azure plugin to v2 ([#1754](#1754)) ([ee9bef2](ee9bef2)) ### Bug Fixes * **deps:** Update golang.org/x/sync digest to 7fc1605 ([#1652](#1652)) ([daafae1](daafae1)) * **deps:** Update module github.com/Azure/azure-sdk-for-go/sdk/azcore to v1.1.2 ([#1664](#1664)) ([5390e13](5390e13)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.10 ([#1474](#1474)) ([b142e13](b142e13)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.11 ([#1491](#1491)) ([5140bef](5140bef)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.12 ([#1503](#1503)) ([a740719](a740719)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.9 ([#1286](#1286)) ([67ac422](67ac422)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.3 ([#1858](#1858)) ([9e3ace7](9e3ace7)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.4 ([#1862](#1862)) ([5d141cf](5d141cf)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.1 ([#1865](#1865)) ([474bb70](474bb70)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.2 ([#1872](#1872)) ([49ed26d](49ed26d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.3 ([#1886](#1886)) ([7435d59](7435d59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.4 ([#1889](#1889)) ([63a5362](63a5362)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.9 ([#1891](#1891)) ([3469f20](3469f20)) * Fix Azure credential chain ([#1283](#1283)) ([c2aadf7](c2aadf7)) * Generate Azure date.time as Timestamps ([#1885](#1885)) ([92d41a1](92d41a1)) * Regenerate Azure resources ([#1875](#1875)) ([7411a27](7411a27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Sep 22, 2022
yevgenypats
pushed a commit
that referenced
this pull request
Sep 26, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.0-pre.0](plugins-source-azure-v0.14.2-pre.0...plugins-source-azure-v1.0.0-pre.0) (2022-09-26) ### ⚠ BREAKING CHANGES * Migrate Azure plugin to v2 (#1754) * Fix Azure credential chain (#1283) ### Features * Add website, docs and blog to our main repo ([#1159](#1159)) ([dd69948](dd69948)) * Added azure cdn profiles ([#1460](#1460)) ([cc154c5](cc154c5)) * Migrate Azure plugin to v2 ([#1754](#1754)) ([ee9bef2](ee9bef2)) ### Bug Fixes * Add missing `azure_keyvault_secrets` tables ([#1937](#1937)) ([491aa66](491aa66)) * **deps:** Update golang.org/x/sync digest to 7fc1605 ([#1652](#1652)) ([daafae1](daafae1)) * **deps:** Update module github.com/Azure/azure-sdk-for-go/sdk/azcore to v1.1.2 ([#1664](#1664)) ([5390e13](5390e13)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.10 ([#1474](#1474)) ([b142e13](b142e13)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.11 ([#1491](#1491)) ([5140bef](5140bef)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.12 ([#1503](#1503)) ([a740719](a740719)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.3 ([#1858](#1858)) ([9e3ace7](9e3ace7)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.4 ([#1862](#1862)) ([5d141cf](5d141cf)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.1 ([#1865](#1865)) ([474bb70](474bb70)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.2 ([#1872](#1872)) ([49ed26d](49ed26d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.3 ([#1886](#1886)) ([7435d59](7435d59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.4 ([#1889](#1889)) ([63a5362](63a5362)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.9 ([#1891](#1891)) ([3469f20](3469f20)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.0 ([#1997](#1997)) ([4fa40da](4fa40da)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.1 ([#2024](#2024)) ([8f88de4](8f88de4)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.2 ([#2044](#2044)) ([9b69b46](9b69b46)) * Fix Azure credential chain ([#1283](#1283)) ([c2aadf7](c2aadf7)) * Generate Azure date.time as Timestamps ([#1885](#1885)) ([92d41a1](92d41a1)) * Regenerate Azure resources ([#1875](#1875)) ([7411a27](7411a27)) * Update Azure codegen ([#1936](#1936)) ([4b739db](4b739db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1221
This changes the new Azure SDK to use the default credential chain, which steps through the authentication options in this order:
I believe this is the correct ordering (Environment should take precedence over CLI), and so am also proposing we update the old SDK auth to use the same ordering (minus ManagedIdentity):
This may be a breaking change for some users that have both environment variables and CLI auth set up in the same environment. In the long run I believe this is the correct behavior though: environment variables should be able to override any CLI variables, rather than the other way round.