feat(aws): Add Support for Network firewall resources Firewalls and TLSInspectionConfigurations#11776
Merged
kodiakhq[bot] merged 8 commits intocloudquery:mainfrom Jun 27, 2023
Merged
Conversation
This PR has the following changes to source plugin(s) tables:
|
disq
reviewed
Jun 27, 2023
| PreResourceResolver: getFirewall, | ||
| Multiplex: client.ServiceAccountRegionMultiplexer(tableName, "network-firewall"), | ||
| Transform: transformers.TransformWithStruct( | ||
| &models.FirewallWrapper{}, |
Member
There was a problem hiding this comment.
Why not use DescribeFirewallOutput instead (could ignore UpdateToken if it's not wanted?)
Collaborator
Author
There was a problem hiding this comment.
I was trying to follow the same format as the 2 existing networkfirewall resources...
Member
There was a problem hiding this comment.
If we're not merging data from 2 separate calls I think it's better to just use the existing structs. If the struct gets updated with new fields they will be explicitly shown when we update the dependency.
Collaborator
Author
There was a problem hiding this comment.
I agree that we lose the ability to automatically add new fields to this based on upgrading the SDK but:
- I would rather maintain consistency within this service as we already have 2 resources that follow this
wrappermodel - We can't unwrap the
DescribeFirewallOutputas the fields are not nested structs... So a new option for the transformer would be needed
disq
reviewed
Jun 27, 2023
plugins/source/aws/resources/services/networkfirewall/tls_inspection_configurations.go
Outdated
Show resolved
Hide resolved
disq
reviewed
Jun 27, 2023
| PreResourceResolver: getTLSInspectionConfigurations, | ||
| Multiplex: client.ServiceAccountRegionMultiplexer(tableName, "network-firewall"), | ||
| Transform: transformers.TransformWithStruct( | ||
| &models.TLSInspectionConfigurationWrapper{}, |
Member
There was a problem hiding this comment.
again why not use DescribeTLSInspectionConfigurationOutput instead?
hermanschaaf
approved these changes
Jun 27, 2023
Member
hermanschaaf
left a comment
There was a problem hiding this comment.
Agree we can probably get away without the extra model here, but since it's an internal refactor we can do later I don't see that as a blocker, LGTM
disq
approved these changes
Jun 27, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
🤖 I have created a release *beep* *boop* --- ## [19.1.0](plugins-source-aws-v19.0.0...plugins-source-aws-v19.1.0) (2023-06-27) ### This Release has the Following Changes to Tables - Table `aws_codeartifact_domains` was added - Table `aws_codeartifact_repositories` was added - Table `aws_codebuild_builds` was added - Table `aws_codebuild_source_credentials` was added - Table `aws_detective_graph_members` was added - Table `aws_detective_graphs` was added - Table `aws_ec2_hosts`: column added with name `asset_id` and type `utf8` - Table `aws_ec2_vpn_connections` was added - Table `aws_ecr_pull_through_cache_rules` was added - Table `aws_eks_cluster_addons` was added - Table `aws_eks_cluster_oidc_identity_provider_configs` was added - Table `aws_inspector2_findings`: column added with name `code_vulnerability_details` and type `json` - Table `aws_inspector2_findings`: column added with name `epss` and type `json` - Table `aws_mq_broker_users`: column added with name `replication_user` and type `bool` - Table `aws_mq_brokers`: column added with name `data_replication_metadata` and type `json` - Table `aws_mq_brokers`: column added with name `data_replication_mode` and type `utf8` - Table `aws_mq_brokers`: column added with name `pending_data_replication_metadata` and type `json` - Table `aws_mq_brokers`: column added with name `pending_data_replication_mode` and type `utf8` - Table `aws_networkfirewall_firewalls` was added - Table `aws_networkfirewall_tls_inspection_configurations` was added - Table `aws_redshift_clusters`: column added with name `custom_domain_certificate_arn` and type `utf8` - Table `aws_redshift_clusters`: column added with name `custom_domain_certificate_expiry_date` and type `timestamp[us, tz=UTC]` - Table `aws_redshift_clusters`: column added with name `custom_domain_name` and type `utf8` - Table `aws_servicediscovery_instances` was added - Table `aws_servicediscovery_namespaces` was added - Table `aws_servicediscovery_services` was added - Table `aws_signer_signing_profiles` was added - Table `aws_stepfunctions_executions`: column added with name `state_machine_alias_arn` and type `utf8` - Table `aws_stepfunctions_executions`: column added with name `state_machine_version_arn` and type `utf8` - Table `aws_stepfunctions_map_run_executions`: column added with name `state_machine_alias_arn` and type `utf8` - Table `aws_stepfunctions_map_run_executions`: column added with name `state_machine_version_arn` and type `utf8` - Table `aws_stepfunctions_state_machines`: column added with name `description` and type `utf8` - Table `aws_stepfunctions_state_machines`: column added with name `revision_id` and type `utf8` - Table `aws_transfer_servers`: column added with name `structured_log_destinations` and type `list<item: utf8, nullable>` - Table `aws_wellarchitected_lens_review_improvements` was added - Table `aws_wellarchitected_lens_reviews` was added - Table `aws_wellarchitected_lenses` was added - Table `aws_wellarchitected_share_invitations` was added - Table `aws_wellarchitected_workload_milestones` was added - Table `aws_wellarchitected_workload_shares` was added - Table `aws_wellarchitected_workloads` was added ### Features * Add AWS Well-Architected resources ([#11697](#11697)) ([83174fe](83174fe)), closes [#11664](#11664) * **aws-services:** Support newly added regions ([#11778](#11778)) ([afbf0ec](afbf0ec)) * **aws:** Add Support for `builds` and `source credentials` for AWS CodeBuild ([#11705](#11705)) ([4eed4dc](4eed4dc)) * **aws:** Add Support for AWS CodeArtifact Domains and Repositories ([#11698](#11698)) ([1838151](1838151)) * **aws:** Add Support for AWS Detective `Graphs` and `GraphMembers` ([#11767](#11767)) ([b40d97d](b40d97d)) * **aws:** Add support for AWS Signer Profiles ([#11765](#11765)) ([e03b797](e03b797)) * **aws:** Add Support for Cloud Map (servicediscovery) resources ([#11702](#11702)) ([0cefa8c](0cefa8c)) * **aws:** Add support for EC2 VPN Connections ([#11769](#11769)) ([0f0c340](0f0c340)) * **aws:** Add Support for ECR `PullThroughCacheRules` ([#11770](#11770)) ([9d72446](9d72446)) * **aws:** Add support for EKS `AddOns` and `IdentityProviderConfigs` ([#11764](#11764)) ([24c348d](24c348d)) * **aws:** Add Support for Network firewall resources `Firewalls` and `TLSInspectionConfigurations` ([#11776](#11776)) ([6e7ae44](6e7ae44)) * **aws:** Update all AWS dependencies ([#11783](#11783)) ([18d9fa7](18d9fa7)) ### Bug Fixes * **aws:** AppRunner Tag errors ([#11786](#11786)) ([d2d333d](d2d333d)) * **aws:** Ensure that all certificates are synced ([#11761](#11761)) ([7e5b201](7e5b201)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 0656028 ([#11739](#11739)) ([7a6ad49](7a6ad49)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 8366a22 ([#11717](#11717)) ([8eeff5b](8eeff5b)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 95d3199 ([#11708](#11708)) ([03f214f](03f214f)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f060192 ([#11730](#11730)) ([c7019c2](c7019c2)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f0dffc6 ([#11689](#11689)) ([18ac0e9](18ac0e9)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/accessanalyzer to v1.19.14 ([#11733](#11733)) ([ab8242f](ab8242f)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/account to v1.10.8 ([#11734](#11734)) ([94e285b](94e285b)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/acm to v1.17.13 ([#11735](#11735)) ([c763315](c763315)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.0 ([#11720](#11720)) ([7ef521d](7ef521d)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.1 ([#11722](#11722)) ([309be72](309be72)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.3 ([#11726](#11726)) ([f0ca611](f0ca611)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.4 ([#11753](#11753)) ([cd4fe1c](cd4fe1c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary