Skip to content

try fixing windows performance on gha#1014

Closed
mcalhoun wants to merge 1 commit intoallow-anon-artifactory-store-accessfrom
try-fixing-windows-perf
Closed

try fixing windows performance on gha#1014
mcalhoun wants to merge 1 commit intoallow-anon-artifactory-store-accessfrom
try-fixing-windows-perf

Conversation

@mcalhoun
Copy link
Contributor

@mcalhoun mcalhoun commented Feb 4, 2025 •
edited
Loading

what

  • Fixed Windows path handling in GitHub Actions workflows
  • Reordered workflow steps to ensure GNU tar is available before checkout
  • Updated the syntax for setting GitHub path on Windows environments

why

  • Previous Windows path syntax using $Env:GITHUB_PATH was causing failures
  • Using "%GITHUB_PATH%" provides better compatibility with Windows command prompt
  • Moving the GNU tar path addition before checkout ensures faster artifact handling

references

@mcalhoun Graphite App
Copy link
Contributor Author

mcalhoun commented Feb 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mcalhoun mcalhoun mentioned this pull request Feb 4, 2025
Merged
@mcalhoun mcalhoun marked this pull request as ready for review February 4, 2025 01:48
@mcalhoun mcalhoun requested a review from a team as a code owner February 4, 2025 01:48
@mergify mergify bot added the triage Needs triage label Feb 4, 2025
@mergify
Copy link

mergify bot commented Feb 4, 2025

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Feb 4, 2025
@mcalhoun mcalhoun force-pushed the allow-anon-artifactory-store-access branch 2 times, most recently from a0aef07 to 3ab84c8 Compare February 4, 2025 01:50
@mcalhoun mcalhoun force-pushed the try-fixing-windows-perf branch from e202f3a to 8c524e0 Compare February 4, 2025 01:50
@mcalhoun mcalhoun closed this Feb 4, 2025
@mcalhoun mcalhoun deleted the try-fixing-windows-perf branch February 4, 2025 02:27
@mergify mergify bot removed needs-cloudposse Needs Cloud Posse assistance triage Needs triage labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mcalhoun