Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 3, 2025
Merged
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
Contributor
📝 WalkthroughWalkthroughThis change removes the Visual Studio Code configuration file for YAML and MDX formatting. The pull request eliminates the in-memory key-value store implementation along with its unit tests, and updates the registry by removing the branch that handled the in-memory store creation. No public API changes were introduced. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Registry as StoreRegistry
Client->>Registry: Request store creation (storeType)
alt storeType=="in-memory"
Registry-->>Client: (Branch Removed)\nError or fallback response
else storeType=="artifactory" or "aws-ssm-parameter-store"
Registry->>Factory: Instantiate store
Factory-->>Registry: Return store instance
Registry-->>Client: Return store instance
end
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This was referenced Feb 4, 2025
|
These changes were released in v1.159.0. |
Cerebrovinny
pushed a commit
that referenced
this pull request
Feb 9, 2025
* deprecate in memory store * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
deprecate the
in-memorystorewhy
This was not a useful store as it doesn't persist across runs. It will be replaced by a
redisstore in a future PR.Summary by CodeRabbit
Chores
Refactor