Skip to content

fix(plugin): fix duplicating pgData on walrestore#9093

Merged
leonardoce merged 2 commits intocloudnative-pg:mainfrom
Endevir:fix/wal-restore-fullpath
Nov 12, 2025
Merged

fix(plugin): fix duplicating pgData on walrestore#9093
leonardoce merged 2 commits intocloudnative-pg:mainfrom
Endevir:fix/wal-restore-fullpath

Conversation

@Endevir
Copy link
Contributor

@Endevir Endevir commented Nov 6, 2025

This commit fixes incorrect walrestore path passed to plugins if destination path is already absolute.

Similar to #6964, but refers walrestore part.

Closes #9067

@Endevir Endevir requested a review from a team as a code owner November 6, 2025 14:52
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 6, 2025
@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.25 release-1.26 release-1.27 labels Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@dosubot dosubot bot added bug 🐛 Something isn't working ok to merge 👌 This PR can be merged labels Nov 6, 2025
@armru armru force-pushed the fix/wal-restore-fullpath branch from 6cd12f0 to 5509722 Compare November 10, 2025 14:39
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 10, 2025
@armru
Copy link
Member

armru commented Nov 10, 2025

/test limit=local

@github-actions
Copy link
Contributor

@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/19235327605

@leonardoce leonardoce force-pushed the fix/wal-restore-fullpath branch from 5509722 to e24fb9a Compare November 11, 2025 10:16
@leonardoce
Copy link
Contributor

I tested it manually several times and it works beautifully.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2025
Endevir and others added 2 commits November 12, 2025 10:35
This commit fixes incorrect walrestore path passed to plugins if destination path is already absolute.

Signed-off-by: Ivan Arkhipov <endevir@yandex-team.ru>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@leonardoce leonardoce force-pushed the fix/wal-restore-fullpath branch from e24fb9a to 4503e5b Compare November 12, 2025 09:35
@leonardoce
Copy link
Contributor

/test limit=local

@github-actions
Copy link
Contributor

@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/19292902306

@leonardoce leonardoce merged commit 70d884f into cloudnative-pg:main Nov 12, 2025
29 of 32 checks passed
cnpg-bot pushed a commit that referenced this pull request Nov 12, 2025
This commit fixes incorrect walrestore path passed to plugins if
destination path is already absolute.

See #6964
Closes #9067

Signed-off-by: Ivan Arkhipov <endevir@yandex-team.ru>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 70d884f)
cnpg-bot pushed a commit that referenced this pull request Nov 12, 2025
This commit fixes incorrect walrestore path passed to plugins if
destination path is already absolute.

See #6964
Closes #9067

Signed-off-by: Ivan Arkhipov <endevir@yandex-team.ru>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 70d884f)
leonardoce pushed a commit that referenced this pull request Nov 12, 2025
This commit fixes incorrect walrestore path passed to plugins if
destination path is already absolute.

See #6964
Closes #9067

Signed-off-by: Ivan Arkhipov <endevir@yandex-team.ru>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 70d884f)
mnencia pushed a commit that referenced this pull request Jan 20, 2026
This commit fixes incorrect walrestore path passed to plugins if
destination path is already absolute.

See #6964
Closes #9067

Signed-off-by: Ivan Arkhipov <endevir@yandex-team.ru>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 70d884f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-requested ◀️ This pull request should be backported to all supported releases bug 🐛 Something isn't working lgtm This PR has been approved by a maintainer ok to merge 👌 This PR can be merged release-1.25 release-1.26 release-1.27 size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Former master cannot perform pg_rewind after failover if plugin is used for WAL archiving

5 participants