fix(plugin): do not append pgData if walName already contains it#6964
Merged
fix(plugin): do not append pgData if walName already contains it#6964
Conversation
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
3 similar comments
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
|
This is just a quick fix with the intent of avoiding any side effects. |
leonardoce
approved these changes
Feb 25, 2025
Contributor
mnencia
approved these changes
Feb 25, 2025
Contributor
|
The E2e test run failed because of #6932 https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/13523799301 |
Member
|
/ok-to-merge E2E green on EDB fork |
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Endevir
pushed a commit
to Endevir/cloudnative-pg
that referenced
this pull request
Nov 6, 2025
…udnative-pg#6964) This patch prevents the plugin executor from appending `$PGDATA/pg_wal` two times when the archiving of a WAL file is requested. This was happening when archiving the ready WALs in a former primary. Fixes: cloudnative-pg#6965 Fixes: cloudnative-pg/plugin-barman-cloud#164 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
4 tasks
leonardoce
pushed a commit
that referenced
this pull request
Nov 12, 2025
This commit fixes incorrect walrestore path passed to plugins if destination path is already absolute. See #6964 Closes #9067 Signed-off-by: Ivan Arkhipov <endevir@yandex-team.ru> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
This commit fixes incorrect walrestore path passed to plugins if destination path is already absolute. See #6964 Closes #9067 Signed-off-by: Ivan Arkhipov <endevir@yandex-team.ru> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 70d884f)
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
This commit fixes incorrect walrestore path passed to plugins if destination path is already absolute. See #6964 Closes #9067 Signed-off-by: Ivan Arkhipov <endevir@yandex-team.ru> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 70d884f)
leonardoce
pushed a commit
that referenced
this pull request
Nov 12, 2025
This commit fixes incorrect walrestore path passed to plugins if destination path is already absolute. See #6964 Closes #9067 Signed-off-by: Ivan Arkhipov <endevir@yandex-team.ru> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 70d884f)
mnencia
pushed a commit
that referenced
this pull request
Jan 20, 2026
This commit fixes incorrect walrestore path passed to plugins if destination path is already absolute. See #6964 Closes #9067 Signed-off-by: Ivan Arkhipov <endevir@yandex-team.ru> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 70d884f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch prevents the plugin executor to append
$PGDATA/pg_waltwo timeswhen the archiving of a WAL file is requested.
This was happening when archiving the ready WALs in a former primary.
Fixes: #6965
Fixes: cloudnative-pg/plugin-barman-cloud#164