Skip to content

Fixes encoding issues not pulled in from dependency update#240

Merged
colbyfayock merged 1 commit intomainfrom
bug/235-encoding
Jul 24, 2023
Merged

Fixes encoding issues not pulled in from dependency update#240
colbyfayock merged 1 commit intomainfrom
bug/235-encoding

Conversation

@colbyfayock
Copy link
Collaborator

@colbyfayock colbyfayock commented Jul 24, 2023

Description

#232 didn't address the encoding issues due to a dependency update not occurring in the URL Loader library.

I forced a new update to deploy that change and this pulls in the update.

I also added a test to make sure it's working properly in this package.

Issue Ticket Number

Fixes #235

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@vercel
Copy link

vercel bot commented Jul 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview Jul 24, 2023 8:46pm

@colbyfayock colbyfayock merged commit df48538 into main Jul 24, 2023
@colbyfayock colbyfayock deleted the bug/235-encoding branch July 24, 2023 20:48
github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
@semantic-release-bot
chore(release): 4.16.2 [skip ci]
edf8397 
## [4.16.2](v4.16.1...v4.16.2) (2023-07-24)

### Bug Fixes

* Fixes encoding issues not pulled in from dependency update ([#240](#240)) ([df48538](df48538)), closes [#235](#235)
@github-actions
Copy link

github-actions bot commented Jul 24, 2023

🎉 This PR is included in version 4.16.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

lytro-dev pushed a commit to lytro-dev/next-image-delivery that referenced this pull request Dec 23, 2023
@00100011-dev
chore(release): 4.16.2 [skip ci]
5ca9b54 
## [4.16.2](cloudinary-community/next-cloudinary@v4.16.1...v4.16.2) (2023-07-24)

### Bug Fixes

* Fixes encoding issues not pulled in from dependency update ([#240](cloudinary-community/next-cloudinary#240)) ([df48538](cloudinary-community/next-cloudinary@df48538)), closes [#235](cloudinary-community/next-cloudinary#235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Images with spaces in filename are incorrectly parsed

1 participant

@colbyfayock