Fixes encoding and missing signature characters#232
Merged
colbyfayock merged 1 commit intomainfrom Jul 18, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🎉 This PR is included in version 4.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 21, 2023
colbyfayock
added a commit
that referenced
this pull request
Jul 24, 2023
# Description #232 didn't address the encoding issues due to a dependency update not occurring in the URL Loader library. I forced a new update to deploy that change and this pulls in the update. I also added a test to make sure it's working properly in this package. ## Issue Ticket Number Fixes #235 <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [ ] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] I have created an [issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket for this PR - [ ] I have checked to ensure there aren't other open [Pull Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the same update/change? - [ ] I have performed a self-review of my own code - [ ] I have run tests locally to ensure they all pass - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes needed to the documentation
lytro-dev
pushed a commit
to lytro-dev/next-image-delivery
that referenced
this pull request
Dec 23, 2023
# [4.15.0](cloudinary-community/next-cloudinary@v4.14.1...v4.15.0) (2023-07-18) ### Features * Fixes encoding and missing signature characters ([#232](cloudinary-community/next-cloudinary#232)) ([4b520ce](cloudinary-community/next-cloudinary@4b520ce)), closes [#219](cloudinary-community/next-cloudinary#219)
lytro-dev
pushed a commit
to lytro-dev/next-image-delivery
that referenced
this pull request
Dec 23, 2023
# Description cloudinary-community/next-cloudinary#232 didn't address the encoding issues due to a dependency update not occurring in the URL Loader library. I forced a new update to deploy that change and this pulls in the update. I also added a test to make sure it's working properly in this package. ## Issue Ticket Number Fixes #235 <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [ ] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] I have created an [issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket for this PR - [ ] I have checked to ensure there aren't other open [Pull Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the same update/change? - [ ] I have performed a self-review of my own code - [ ] I have run tests locally to ensure they all pass - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes needed to the documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue with double encoding
Decode Public ID to avoid double encoding cloudinary-util#60
Fixes issue where signature was not allowing special characters
-_Adding -_ and 32-length support for signature cloudinary-util#61
Issue Ticket Number
Fixes #219
Type of change
Checklist