Remove isolated environment from cpi and compiler cmd #673

fmoehler · 2024-11-19T15:33:32Z

This is the same as PR #663 . The creator of the PR is currently OOO. Therefore this PR is opened.

The bosh-cli wipes parts of the environment provided by the host-system which are in some cases essential for compilation of bosh-releases. This PR follows a conservative fix-approach by adding an option to opt-out of this default. This can (and maybe should) be extended by a fix of the “isolation” from the host-environment. For more details, see #660

Edit: We agreed to remove the isolated environment entirely

…nt of host-system;

anshrupani

looks good

aramprice · 2024-12-04T00:48:35Z

I'd prefer to keep this complexity out of the bosh cli since the issue this appears to be addressing could also be side-stepped by running the bosh CLI in a docker container.

Perhaps there is some broader issue I'm missing here though?

Regarding the code changes, it seems like there are a number of additions, specifically for nix, beyond a "don't isolate my environment" flag, I'm wondering if those need to be in the bosh-cli repo?

Regarding the feature I am concerned that allowing more variation in the local environment will increase the surface area we will have to consider when triaging issues with the CLI.

aramprice · 2024-12-12T01:42:13Z

cloud/cpi_cmd_runner.go

-			"PATH":              "/usr/local/bin:/usr/bin:/bin:/sbin",
+			"PATH":              os.Getenv("PATH"),


Perhaps a default value of "/usr/local/bin:/usr/bin:/bin:/sbin" should remain here and we allow an override with something like BOSH_CPI_COMAND_PATH.

aramprice · 2024-12-12T02:06:02Z

I think there are two core changes lurking in this PR

Allowing the current ENV to be passed to the CPI command

My inclination is for this logic to live exclusively in the bosh-cli codebase, and not rely on the bosh-utils' system.execCmdRunner.buildComplexCommand() handling of cmd.UseIsolatedEnv at all.

It seems like this change alone might be sufficient for the requestors needs.

Allowing the the PATH value passed to the CPI to be overridden

This could be handled by using BOSH_CPI_COMAND_PATH or defaulting to the existing value. However this is accomplished the CLI's default behavior should be the same (e.g. PATH=/usr/local/bin:/usr/bin:/bin:/sbin).

This might be a nice additional change if there is a need for a mostly isolated ENV except with modifications to PATH.

The other nix specific files don't belong in this repo.

Side note: bosh-cli appears to be the only project in the cloudfoundry org which sets system.Command.UseIsolatedEnv perhaps this capability could be removed if we handle the "isolated or not" logic into the bosh-cli?

FloThinksPi · 2024-12-12T17:01:01Z

@fmoehler @aramprice
indeed there are quite some files not relevant here imho. They should be removed like the nix files and envrc etc.
Also i think removal of some code parts is not neccecary e.g. the BOSH_CPI_USE_ISOLATED_ENV variable seems to be removed here. Dont know if thats intended this variable is also not documented in the bosh docs.

broader issue I'm missing here though?

The broader issue as far as i remember is that the isolation feature in case of create-release is somewhat pointless on systems other than ubuntu. It basically boils down to bosh-cli does not accept the environment variable the OS gives it - however then it proceeds calling OS packages (gcc etc.) and fails either not finding those as it looks not in the path the OS told the process to look in but in a hardcoded one. Or It cannot find the proper libraries development headers when compiling with GCC since it also does not pass the information the OS has given via ENV variables to the GCC process.

In this state afaik the current create-release with enabled isolation(default?) does not work on every linux/unix system that has all the needed tools/libraries installed, it just works on systems that have the tools installed how ubuntu places them into its filesystem specifically.

One way would also be to state that just ubuntu is supported and one should run this inside a ubuntu container/vm - however compared to whats needed to make it work on all unix systems it might be easy to enable all linux/unix systems when holding on to basic POSIX concepts - but the exclusion exists for windows it seems already #626

However now looking into the code i saw there is also BOSH_CPI_USE_ISOLATED_ENV - maybe it can be used to disable isolation of env entirely then building a bosh release would also work on a non ubuntu linux as bosh and all build tools behind it would respect the OS env. WDYT ?

Also disabling that feature and using all OS Envs would be ok as a solution maybe BOSH_CPI_USE_ISOLATED_ENV does this need to test that maybe.

This struct attribute is only ever set to `true` by the bosh-cli, and the value if this use case is in question, see: - cloudfoundry/bosh-cli#660 - cloudfoundry/bosh-cli#663 - cloudfoundry/bosh-cli#673 In addition the `UseIsolatedEnv` capability can be wholely handled within the `bosh-cli` codebase itself without the need for this featuer in `bosh-utils`.

jpalermo · 2024-12-19T15:51:21Z

We talked about this at the FIWG meeting.

We think a good direction is to just always enable the isolated environment within the bosh cli. Even removing the current flag that allows you to disable it. And then have the CLI pass in the full set of ENV variables that a CPI might need to run (PATH, LIBRARY_PATH, etc)

This might cause some breakages, but we can just deal with those if they arise.

jpalermo · 2025-01-16T16:54:24Z

@beyhan and @rkoster , do either of you remember what we talked about in the FIWG meeting regarding this? I can't find the video for the 12/19 meeting and my comment above only confuses me.

I think what my comment is saying is: "Always enable isolated environment, but then pass through ENV that includes PATH and things that might be needed"

But wouldn't it be more simple if we instead "Always disabled isolated environment, and then just let it use whatever is already in the ENV"?

beyhan · 2025-01-17T11:12:02Z

But wouldn't it be more simple if we instead "Always disabled isolated environment, and then just let it use whatever is already in the ENV"?

@jpalermo I can't follow what you mean. If we don't want to relay on the bosh-utils option UseIsolatedEnv we could just define a new option with UseHostOSEnv or UseOSEnv (because UseIsolatedEnv is a little bit confusing IMO and doesn't describe what happens really) and based on that option we decide in https://github.com/cloudfoundry/bosh-cli/blob/main/cloud/cpi_cmd_runner.go#L112-L122 whether we initialise the env as it is happening currently or use the OS env as done here https://github.com/cloudfoundry/bosh-utils/blob/c837f5a2ec9037ca1459b49dee470b9d6e4014a5/system/exec_cmd_runner.go#L85. Personally, I would prefer a solution which doesn't change the current behaviour for the default usage.

If allowing an override of the passed PATH value to the CPI is still needed we can talk about introducing a BOSH_CPI_COMAND_PATH as Aram suggest but it is not clear to me whether it is needed if OS env usage is implemented.

jpalermo · 2025-01-19T07:44:13Z

I'm just wondering if we actually get anything of value from UseIsolatedEnv.

We've had it configured this way since 2014, but it's not clear why we're doing this. The original commit doesn't describe any problem that it is solving. It seems like more of a "this sounds like a good idea" sort of thing.

Up until now, it hasn't really caused any major problems, other than the PR in 2022 to add the flag to disabled parts of isolated env (but PATH is still overridden).

But the BOSH_CPI_USE_ISOLATED_ENV and this new PR kind of show that the IsolatedEnv is problematic. And if we can't describe why we need it, does it really make sense to be adding a bunch of flags and conditional behavior to work around it?

Why not just rip isolated env out of the bosh-cli entirely?

a-hassanin · 2025-01-21T15:04:30Z

I'm just wondering if we actually get anything of value from UseIsolatedEnv.

We've had it configured this way since 2014, but it's not clear why we're doing this. The original commit doesn't describe any problem that it is solving. It seems like more of a "this sounds like a good idea" sort of thing.

Up until now, it hasn't really caused any major problems, other than the PR in 2022 to add the flag to disabled parts of isolated env (but PATH is still overridden).

But the BOSH_CPI_USE_ISOLATED_ENV and this new PR kind of show that the IsolatedEnv is problematic. And if we can't describe why we need it, does it really make sense to be adding a bunch of flags and conditional behavior to work around it?

Why not just rip isolated env out of the bosh-cli entirely?

If that is the case, i guess we can create a 2nd PR to just rip it out entirely (Y)

fmoehler · 2025-01-21T16:15:43Z

I also agree with @jpalermo , but am just wondering if removing this entirely could be a security risk? Don't really know if that is something to consider, just came to my mind.
If it is (or could be), then I think the initial solution (also including this change) to "hide" this feature behind a flag as proposed here is fine.

jpalermo · 2025-01-23T15:44:51Z

Update from FIWG meeting today. Plan is to just remove isolated environment from the cli and let it use whatever is in the ENV

jpalermo · 2025-01-30T22:06:35Z

cmd/opts/opts.go

 	StatePath               string `long:"state" value-name:"PATH" description:"State file path"`
 	Recreate                bool   `long:"recreate" description:"Recreate VM in deployment"`
 	RecreatePersistentDisks bool   `long:"recreate-persistent-disks" description:"Recreate persistent disks in the deployment"`
+	AvoidIsolatedEnv        bool   `long:"avoid-isolated-environment" short:"I" description:"Compile and run cpi-commands in a clean environment or not"`


This should be removed too right?

Of course! Thanks for pointing out. Removed!

aramprice

Adding a +1 to @jpalermo's comment about removing AvoidIsolatedEnv bool.

Looks good otherwise, thank you for the contribution!

This struct attribute is only ever set to `true` by the bosh-cli, and the value if this use case is in question, see: - cloudfoundry/bosh-cli#660 - cloudfoundry/bosh-cli#663 - cloudfoundry/bosh-cli#673 In addition the `UseIsolatedEnv` capability can be wholely handled within the `bosh-cli` codebase itself without the need for this featuer in `bosh-utils`.

I would like to change myself from reviewer to approver. You can find my contributions so far listed below: # Foundational Infrastructure: VM deployment lifecycle (BOSH) Contributions ### PRs Commented on/Reviewed: - 2024-12-12T22:52:53Z: [Remove `UseIsolatedEnv` from `system.Command`](cloudfoundry/bosh-utils#110) - 2025-01-28T10:33:14Z: [enable ipv6 in boshSysctl](cloudfoundry/bosh-agent#347) - 2025-02-10T07:47:30Z: [Extend bosh tagging for cpi](cloudfoundry/bosh#2603) - 2025-02-26T16:50:01Z: [When removing recursors for Noble usage, we accidentally also removed handlers](cloudfoundry/bosh-dns-release#107) ### Issues that may be relevant: - 2022-06-21T14:28:19Z: [Fix regression: Deployment manifests can contain yaml anchors](cloudfoundry/bosh#2386) - 2023-03-23T12:33:02Z: [Update aws.md](cloudfoundry/docs-bosh#788) - 2023-04-04T18:17:29Z: [Update post-stop.md](cloudfoundry/docs-bosh#789) - 2023-04-13T07:47:12Z: [Update dns.md](cloudfoundry/docs-bosh#790) - 2023-05-04T13:33:37Z: [correct the diskID for device path resolution](cloudfoundry/bosh-agent#309) - 2023-05-04T14:22:24Z: [Device path resolution times out for aws and ali](cloudfoundry/bosh-agent#310) - 2023-07-14T14:46:10Z: [introduce -v flag to show version information](cloudfoundry/bosh-azure-storage-cli#8) - 2023-07-18T13:19:16Z: [auto bump the azure storage cli](cloudfoundry/bosh#2455) - 2023-07-25T09:36:07Z: [update docs for azure storage account](cloudfoundry/docs-bosh#798) - 2023-10-26T10:00:07Z: [append global flags to deploy cmd](cloudfoundry/bosh-cli#633) - 2023-10-26T16:42:17Z: [Update configs.md](cloudfoundry/docs-bosh#806) - 2023-10-31T16:19:11Z: [enable global flags for deploy command](cloudfoundry/bosh-cli#634) - 2023-11-03T09:17:19Z: [bumped dependencies for nats-pure and ruby-prof to the most recent versions](cloudfoundry/bosh#2476) - 2023-11-07T16:55:08Z: [update documentation](cloudfoundry/docs-bosh#810) - 2023-11-09T12:57:03Z: [update global cli flags documentation](cloudfoundry/docs-bosh#811) - 2023-12-12T13:53:01Z: [Include deploy config documentation](cloudfoundry/docs-bosh#816) - 2023-12-13T16:33:11Z: [enable metrics for deploy config](cloudfoundry/bosh#2482) - 2024-01-11T13:37:42Z: [fix typo](cloudfoundry/docs-bosh#818) - 2024-01-11T13:44:44Z: [bosh scp command failing if used according to documentation](cloudfoundry/docs-bosh#819) - 2024-02-14T13:05:36Z: [use octavia endpoint instead of neutron for lb activites](cloudfoundry/bosh-openstack-cpi-release#268) - 2024-05-15T06:59:59Z: [bump fog openstack gem to new version 1.1.1 & enable application credential authentication](cloudfoundry/bosh-openstack-cpi-release#272) - 2024-07-05T15:11:06Z: [bump ruby-prof version from 1.6.3 to 1.7.0](cloudfoundry/bosh#2535) - 2024-08-07T13:25:05Z: [update gosigar version](cloudfoundry/bosh-dns-release#105) - 2024-08-09T07:11:03Z: [fix formatting for configure blobstore for gcp section](cloudfoundry/docs-bosh#848) - 2024-08-13T14:12:56Z: [introduce support for ceph blobstore](cloudfoundry/bosh-s3cli#43) - 2024-08-28T08:27:36Z: [Isolated environment is hard-coded for building bosh-releases](cloudfoundry/bosh-cli#660) - 2024-10-18T13:08:21Z: [Enable CPI Release golang](cloudfoundry/bosh-openstack-cpi-release#290) - 2024-11-11T12:11:36Z: [link should point to main branch and not master branch](cloudfoundry/docs-bosh#853) - 2024-11-13T20:34:24Z: [ensure that cpi uses the correct gem path during runtime](cloudfoundry/bosh-azure-cpi-release#702) - 2024-11-13T20:51:42Z: [revert fastjsonparser](cloudfoundry/bosh-azure-cpi-release#703) - 2024-11-13T21:04:07Z: ["Illegal instruction" error](cloudfoundry/bosh-azure-cpi-release#704) - 2024-11-19T15:33:32Z: [Remove isolated environment from cpi and compiler cmd](cloudfoundry/bosh-cli#673) - 2024-11-21T13:40:36Z: [Update pre-start.sh.erb in harden_ssh for noble stemcell](cloudfoundry/os-conf-release#70) - 2024-11-26T19:30:35Z: [enable dual stack support](cloudfoundry/bosh-aws-cpi-release#172) - 2024-12-05T10:11:36Z: [Metrics missing after upgrading to 280.1.10 ](cloudfoundry/bosh#2593) - 2024-12-19T09:57:45Z: [Disable error messages related to networks/network interface cards](cloudfoundry/bosh-agent#344) - 2024-12-19T10:12:41Z: [sysctl job disables ipv6 implicitly on jammy stemcells](cloudfoundry/os-conf-release#71) - 2025-01-09T15:42:13Z: [Enable dual stack with single nic](cloudfoundry/bosh-aws-cpi-release#174) - 2025-01-15T15:49:28Z: [Update 60-bosh-sysctl.conf](cloudfoundry/bosh-linux-stemcell-builder#407) - 2025-01-28T10:33:14Z: [enable ipv6 in boshSysctl](cloudfoundry/bosh-agent#347) - 2025-02-03T12:30:20Z: [set retry interval to avoid bosh workers sleeping forever in case of error](cloudfoundry/bosh#2599) - 2025-02-07T11:40:47Z: [Update kernel_ipv6.go](cloudfoundry/bosh-agent#348) - 2025-02-10T07:47:30Z: [Extend bosh tagging for cpi](cloudfoundry/bosh#2603) - 2025-02-10T08:48:50Z: [Azure Compute Gallery integration](cloudfoundry/bosh-azure-cpi-release#709) - 2025-02-10T08:50:20Z: [add ipv6 prefix](cloudfoundry/bosh-aws-cpi-release#176) ### Code contributions: - 2023-03-23T12:32:37Z: [Update aws.md](cloudfoundry/docs-bosh@14888a5) - 2023-04-04T18:17:16Z: [Update post-stop.md](cloudfoundry/docs-bosh@f8e4db2) - 2023-04-13T07:47:00Z: [Update dns.md](cloudfoundry/docs-bosh@a51e96f) - 2023-07-14T14:39:55Z: [introduce -v flag to show version information](cloudfoundry/bosh-azure-storage-cli@4fbf437) - 2023-07-18T13:15:27Z: [auto bump the azure storage cli](cloudfoundry/bosh@c3b1cd0) - 2023-07-18T13:19:24Z: [auto bump the azure storage cli](cloudfoundry/bosh@c3b1cd0) - 2023-07-19T07:56:16Z: [introduce -v flag to show version information](cloudfoundry/bosh-azure-storage-cli@4fbf437) - 2023-07-20T09:45:02Z: [add integration test](cloudfoundry/bosh-azure-storage-cli@844083d) - 2023-07-25T09:35:44Z: [update docs for azure storage account](cloudfoundry/docs-bosh@df2d802) - 2023-10-26T16:41:26Z: [Update configs.md](cloudfoundry/docs-bosh@db6957e) - 2023-11-07T16:51:19Z: [update documentation](cloudfoundry/docs-bosh@06ea871) - 2023-11-08T10:13:38Z: [add global flags to bosh deploy command](cloudfoundry/bosh-cli@cfbabbb) - 2023-11-09T12:25:46Z: [add excluding of deployments and tests](cloudfoundry/bosh-cli@55961e4) - 2023-11-09T12:56:53Z: [update global cli flags documentation](cloudfoundry/docs-bosh@2261b7a) - 2023-11-09T15:20:32Z: [add excluding of deployments and tests](cloudfoundry/bosh-cli@55961e4) - 2023-11-23T09:17:38Z: [color the cli output in case deployment flags are used](cloudfoundry/bosh-cli@f80c9e4) - 2023-11-23T09:19:37Z: [rename the search function](cloudfoundry/bosh-cli@d7ae88a) - 2023-11-23T16:00:47Z: [fix issues](cloudfoundry/bosh-cli@958d4aa) - 2023-11-23T16:31:41Z: [fix some more issues](cloudfoundry/bosh-cli@1a8d04d) - 2023-11-30T13:03:33Z: [Update cli-v2.md](cloudfoundry/docs-bosh@2d43295) - 2023-11-30T13:03:54Z: [Update deploy-config.md](cloudfoundry/docs-bosh@a378c26) - 2023-12-12T13:51:48Z: [Include deploy config documentation](cloudfoundry/docs-bosh@4c3a536) - 2023-12-18T14:04:27Z: [Introduce monitoring metrics for deploy config enablement](cloudfoundry/bosh@1874004) - 2023-12-18T16:21:04Z: [Update config_manager_spec.rb](cloudfoundry/bosh@0613612) - 2023-12-18T16:47:44Z: [Update config_manager.rb](cloudfoundry/bosh@21fd8e1) - 2024-01-03T08:26:56Z: [Update config_manager.rb](cloudfoundry/bosh@e66fea9) - 2024-01-11T13:30:21Z: [fix typo](cloudfoundry/docs-bosh@c5535da) - 2024-01-11T13:39:44Z: [We used bosh scp today and faced the issue mentioned here:](cloudfoundry/docs-bosh@6d2df8f) - 2024-05-15T06:57:25Z: [bump fog openstack gem to new version 1.1.1](cloudfoundry/bosh-openstack-cpi-release@367524f) - 2024-05-15T07:58:04Z: [enable application credential authentication](cloudfoundry/bosh-openstack-cpi-release@d12b287) - 2024-05-15T12:37:16Z: [Update cloud.rb](cloudfoundry/bosh-openstack-cpi-release@f4cee7a) - 2024-05-15T12:38:54Z: [Update cloud_spec.rb](cloudfoundry/bosh-openstack-cpi-release@dbdf465) - 2024-07-05T14:40:37Z: [bump ruby-prof version from 1.6.3 to 1.7.0](cloudfoundry/bosh@6365a5d) - 2024-07-09T12:37:17Z: [bump ruby-prof version from 1.6.3 to 1.7.0](cloudfoundry/bosh@6365a5d) - 2024-08-07T13:24:53Z: [update gosigar version](cloudfoundry/bosh-dns-release@c1be1b9) - 2024-08-08T08:33:14Z: [update gosigar version](cloudfoundry/bosh-dns-release@c1be1b9) - 2024-08-09T06:40:52Z: [fix formatting for configure blobstore for gcp section](cloudfoundry/docs-bosh@68d35c4) - 2024-11-11T12:11:17Z: [link should point to main branch and not master branch](cloudfoundry/docs-bosh@e919e42) - 2024-11-12T08:10:05Z: [ensure that cpi uses the correct gem path during runtime](cloudfoundry/bosh-azure-cpi-release@c49f723) - 2024-11-13T20:44:53Z: [revert fastjsonparser](cloudfoundry/bosh-azure-cpi-release@ed1bbcc) - 2024-11-13T20:49:18Z: [revert fastjsonparser](cloudfoundry/bosh-azure-cpi-release@ed1bbcc) - 2024-11-19T15:14:44Z: [Merge branch 'master' into revert-fastjsonparser](cloudfoundry/bosh-azure-cpi-release@f7f412d) - 2024-11-19T15:37:05Z: [Merge branch 'main' into optional_isolated_environment](cloudfoundry/bosh-cli@72c44e6) - 2024-11-19T15:39:06Z: [Update compiler.go](cloudfoundry/bosh-cli@2e81740) - 2024-11-19T19:35:33Z: [fix env_factory](cloudfoundry/bosh-cli@8867168) - 2024-11-19T19:44:10Z: [fix compiler.go](cloudfoundry/bosh-cli@eacc737) - 2024-11-21T10:25:08Z: [fix compiler.go](cloudfoundry/bosh-cli@eacc737) - 2024-11-21T13:40:25Z: [Update pre-start.sh.erb for noble stemcell](cloudfoundry/os-conf-release@2aab03c) - 2024-11-21T16:09:16Z: [add test for compiler.go](cloudfoundry/bosh-cli@8f84216) - 2024-12-18T08:57:31Z: [remove nix definitions](cloudfoundry/bosh-cli@bdf1b53) - 2024-12-19T09:54:34Z: [do not raise error in case more networks than network interface cards are applied](cloudfoundry/bosh-agent@3c63d2b) - 2024-12-30T12:22:59Z: [enable dual stack support on aws](cloudfoundry/bosh-aws-cpi-release@5cbfb80) - 2025-01-02T15:02:59Z: [enable dual stack support on aws](cloudfoundry/bosh-aws-cpi-release@5cbfb80) - 2025-01-08T08:39:04Z: [fix unit tests](cloudfoundry/bosh-agent@4e1db30) - 2025-01-08T12:32:44Z: [create tests](cloudfoundry/bosh-aws-cpi-release@463ff5e) - 2025-01-29T13:02:31Z: [remove isolated env](cloudfoundry/bosh-cli@ba77137) - 2025-01-29T13:11:25Z: [remove isolated env](cloudfoundry/bosh-cli@ba77137) - 2025-01-30T15:47:00Z: [Delete .tool-versions](cloudfoundry/bosh-cli@799e6e5) - 2025-01-31T09:49:58Z: [Update opts.go](cloudfoundry/bosh-cli@8bfb6a6) - 2025-02-03T12:26:38Z: [set retry interval to avoid bosh workers sleeping forever in case of error](cloudfoundry/bosh@23d5899) - 2025-02-06T15:54:40Z: [enable ipv6 in boshSysctl (cloudfoundry#347)](cloudfoundry/bosh-agent@a7d6a6b) - 2025-02-07T11:40:08Z: [Update kernel_ipv6.go](cloudfoundry/bosh-agent@a79e5fc) # Foundational Infrastructure: Ali Cloud VM deployment lifecycle (BOSH) Contributions ### PRs Commented on/Reviewed: ### Issues that may be relevant: - 2023-08-14T11:48:57Z: [Changing Tags from uppercase to lowercase ends in ](cloudfoundry/bosh-alicloud-cpi-release#162) - 2023-11-23T11:24:07Z: [update dependencies](cloudfoundry/bosh-alicloud-cpi-release#165) - 2023-11-28T17:20:05Z: [Update Documentation](cloudfoundry/bosh-alicloud-cpi-release#166) - 2024-11-28T12:56:51Z: [use bash from PATH](cloudfoundry/bosh-alicloud-cpi-release#174) - 2024-11-28T12:57:06Z: [bosh create-env terminates with: "cannot execute: required file not found"](cloudfoundry/bosh-alicloud-cpi-release#175) ### Code contributions: - 2023-11-23T11:23:20Z: [update dependencies](cloudfoundry/bosh-alicloud-cpi-release@7f50084) - 2023-11-28T17:18:16Z: [Update Documentation](cloudfoundry/bosh-alicloud-cpi-release@a72e168)

joergdw and others added 11 commits September 25, 2024 13:46

Add flake to provide a development-environment (a.k.a. “dev-shell”);

8ece8d1

🛠️ Make the binary roughly work.

405519b

🚧 Work in progress: Add and propagate new cli-option to use environme…

f2cc986

…nt of host-system;

add golang to toolversion

a0b97ee

add UseIsolatedEnv cli option

4aa40dc

rename to avoidIsolatedEnv cli

035c1f8

Propagate useIsolatedEnv through to cpi_cmd_runner.go;

93d81cb

🔧🧹 Fix tests and clean-up;

aa9fc86

Merge branch 'main' into optional_isolated_environment

72c44e6

Update compiler.go

2e81740

fix env_factory

8867168

fmoehler force-pushed the optional_isolated_environment branch 3 times, most recently from ede6eef to caa8b20 Compare November 21, 2024 10:16

fix compiler.go

eacc737

fmoehler force-pushed the optional_isolated_environment branch from caa8b20 to eacc737 Compare November 21, 2024 10:25

jpalermo requested review from a team, anshrupani and klakin-pivotal and removed request for a team November 21, 2024 15:59

add test for compiler.go

8f84216

anshrupani approved these changes Nov 25, 2024

View reviewed changes

aramprice reviewed Dec 12, 2024

View reviewed changes

This was referenced Dec 12, 2024

Rmove UseIsolatedEnv from system.Command cloudfoundry/bosh-utils#109

Closed

Remove UseIsolatedEnv from system.Command cloudfoundry/bosh-utils#110

Merged

remove nix definitions

bdf1b53

fmoehler force-pushed the optional_isolated_environment branch 2 times, most recently from f91edf3 to 75d86bc Compare January 29, 2025 13:07

remove isolated env

ba77137

fmoehler force-pushed the optional_isolated_environment branch from 75d86bc to ba77137 Compare January 29, 2025 13:11

fmoehler changed the title ~~Optional isolated environment~~ Remove isolated environment from cpi and compiler cmd Jan 29, 2025

jpalermo requested review from anshrupani and aramprice January 30, 2025 15:44

Delete .tool-versions

799e6e5

jpalermo reviewed Jan 30, 2025

View reviewed changes

aramprice approved these changes Jan 30, 2025

View reviewed changes

Update opts.go

8bfb6a6

jpalermo approved these changes Jan 31, 2025

View reviewed changes

jpalermo merged commit 49128cd into cloudfoundry:main Jan 31, 2025
5 checks passed

aramprice mentioned this pull request Jan 31, 2025

Isolated environment is hard-coded for building bosh-releases #660

Closed

fmoehler mentioned this pull request Mar 6, 2025

Update foundational-infrastructure.md cloudfoundry/community#1095

Merged

		"PATH": "/usr/local/bin:/usr/bin:/bin:/sbin",
		"PATH": os.Getenv("PATH"),

Remove isolated environment from cpi and compiler cmd #673

Remove isolated environment from cpi and compiler cmd #673

Uh oh!

Conversation

fmoehler commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anshrupani left a comment

Choose a reason for hiding this comment

Uh oh!

aramprice commented Dec 4, 2024

Uh oh!

aramprice Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aramprice commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FloThinksPi commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpalermo commented Dec 19, 2024

Uh oh!

jpalermo commented Jan 16, 2025

Uh oh!

beyhan commented Jan 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpalermo commented Jan 19, 2025

Uh oh!

a-hassanin commented Jan 21, 2025

Uh oh!

fmoehler commented Jan 21, 2025

Uh oh!

jpalermo commented Jan 23, 2025

Uh oh!

jpalermo Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

fmoehler Jan 31, 2025

Choose a reason for hiding this comment

Uh oh!

aramprice left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

fmoehler commented Nov 19, 2024 •

edited

Loading

aramprice Dec 12, 2024 •

edited

Loading

aramprice commented Dec 12, 2024 •

edited

Loading

FloThinksPi commented Dec 12, 2024 •

edited

Loading

beyhan commented Jan 17, 2025 •

edited

Loading

aramprice left a comment •

edited

Loading