Optional isolated environment #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt of host-system;
aramprice
added a commit
to cloudfoundry/bosh-utils
that referenced
this pull request
Dec 12, 2024
This struct attribute is only ever set to `true` by the bosh-cli, and the value if this use case is in question, see: - cloudfoundry/bosh-cli#660 - cloudfoundry/bosh-cli#663 - cloudfoundry/bosh-cli#673 In addition the `UseIsolatedEnv` capability can be wholely handled within the `bosh-cli` codebase itself without the need for this featuer in `bosh-utils`.
This was referenced Dec 12, 2024
aramprice
added a commit
to cloudfoundry/bosh-utils
that referenced
this pull request
Dec 12, 2024
This struct attribute is only ever set to `true` by the bosh-cli, and the value if this use case is in question, see: - cloudfoundry/bosh-cli#660 - cloudfoundry/bosh-cli#663 - cloudfoundry/bosh-cli#673 In addition the `UseIsolatedEnv` capability can be wholely handled within the `bosh-cli` codebase itself without the need for this featuer in `bosh-utils`.
aramprice
added a commit
to cloudfoundry/bosh-utils
that referenced
this pull request
Jan 31, 2025
This struct attribute is only ever set to `true` by the bosh-cli, and the value if this use case is in question, see: - cloudfoundry/bosh-cli#660 - cloudfoundry/bosh-cli#663 - cloudfoundry/bosh-cli#673 In addition the `UseIsolatedEnv` capability can be wholely handled within the `bosh-cli` codebase itself without the need for this featuer in `bosh-utils`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bosh-cli wipes parts of the environment provided by the host-system which are in some cases essential for compilation of bosh-releases. This PR follows a conservative fix-approach by adding an option to opt-out of this default. This can (and maybe should) be extended by a fix of the “isolation” from the host-environment. For more details, see #660