test: make custom build bundling tests more robust#9494
Merged
petebacondarwin merged 1 commit intomainfrom Jun 12, 2025
Merged
Conversation
It is possible that the bundleComplete event happens before `waitForBundleComplete()` is called in the tests. So do that first, capture the promise, trigger the update to the build, then await the promise.
|
Contributor
|
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-wrangler-9494Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-cloudflare-workers-bindings-extension-9494 -O ./cloudflare-workers-bindings-extension.0.0.0-v8feb08475.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8feb08475.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-create-cloudflare-9494 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-cloudflare-kv-asset-handler-9494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-miniflare-9494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-cloudflare-pages-shared-9494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-cloudflare-unenv-preset-9494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-cloudflare-vite-plugin-9494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-cloudflare-vitest-pool-workers-9494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-cloudflare-workers-editor-shared-9494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-cloudflare-workers-shared-9494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15465432513/npm-package-cloudflare-workflows-shared-9494Note that these links will no longer work once the GitHub Actions artifact expires. |
vicb
reviewed
Jun 10, 2025
| legacy: {}, | ||
| }; | ||
|
|
||
| let evCustomPromise = waitForBundleComplete(controller); |
Contributor
There was a problem hiding this comment.
Maybe add a comment to explain the ordering?
vicb
approved these changes
Jun 10, 2025
Contributor
vicb
left a comment
There was a problem hiding this comment.
LGTM - a code comment could help
dario-piotrowicz
approved these changes
Jun 10, 2025
jseba
added a commit
to jseba/workers-sdk
that referenced
this pull request
Jun 14, 2025
* 'main' of ssh://github.com/cloudflare/workers-sdk: (213 commits) fix(vite-plugin-cloudflare): allow unknown entrypoint on startup (cloudflare#9583) add warning about env not specified to potentially risky wrangler commands (cloudflare#9344) test: correctly delete test d1 databases (cloudflare#9598) Add details to v3 maintenance worflow error message (cloudflare#9602) drop unused `WRANGLER_UNENV_RESOLVE_PATHS` env var (cloudflare#9593) warn instead of erroring if no exposed ports. and remove unused dev_exposed_ports (cloudflare#9573) fix(wrangler): point to the right doc location (replaces cloudflare#9353) (cloudflare#9592) [vitest-pool-worker] Add `type: module` in package.json (cloudflare#9595) Enable HTML handling for HTML files in the public directory (cloudflare#9548) switch from go container to js (cloudflare#9588) containers: switch to Cloudflare container registry (cloudflare#9564) performance improvement: restart a mixed mode session only if the worker's remote bindings have changed (cloudflare#9536) ci: delete more orphaned resources from e2e tests (cloudflare#9580) test: remove `verifyBuildScript` logic from c3 e2e tests (cloudflare#9504) fix(vite-plugin): ensure node compat globals are injected before any imports (cloudflare#9581) feat(containers-shared): Move `isDockerfile` utility function to `containers-shared` (cloudflare#9577) allow `startWorker` to accept `false` as an `inspector` option (to disable the inspector server) (cloudflare#9550) Update capnp generated code from the workerd.capnp (cloudflare#9582) Bump `@cloudflare/unenv-preset` to 2.3.3 (cloudflare#9566) test: make custom build bundling tests more robust (cloudflare#9494) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible that the bundleComplete event happens before
waitForBundleComplete()is called in the tests. So do that first, capture the promise, trigger the update to the build, then await the promise.