Skip to content

fix(wrangler): point to the right doc location#9353

Closed
yeskunall wants to merge 7 commits intocloudflare:mainfrom
tau-engineering:patch-1
Closed

fix(wrangler): point to the right doc location#9353
yeskunall wants to merge 7 commits intocloudflare:mainfrom
tau-engineering:patch-1

Conversation

@yeskunall
Copy link
Copy Markdown
Contributor

@yeskunall yeskunall commented May 23, 2025 •
edited by emily-shen
Loading

Wrangler points to the wrong location to learn more about its telemetry. I believe this is a non-trivial change, so I directly opened a PR.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Minor fix that is not covered by e2e tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: it doesn’t look like there is any mention of this message in your public docs
  • Wrangler V3 Backport

It looks like the broken link does exist in v3 (v3-maintenance-9124). Can someone tell me how one would go about backporting this change?

PS: if I’m wrong about tests not being required, then please LMK. I’ll look into it.

💖

@yeskunall yeskunall requested a review from a team as a code owner May 23, 2025 14:52
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 23, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9b3c1b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk May 23, 2025
edmundhung
edmundhung approved these changes May 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We have a CI job that should help creating a backport PR on v3, so we should see a PR coming up soon.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk May 23, 2025
@edmundhung
Copy link
Copy Markdown
Member

edmundhung commented May 23, 2025

@yeskunall Can you add a changeset as suggested in #9353 (comment)?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 23, 2025 •
edited
Loading

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-wrangler-9353
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-cloudflare-workers-bindings-extension-9353 -O ./cloudflare-workers-bindings-extension.0.0.0-vef81ba573.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vef81ba573.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-create-cloudflare-9353 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-cloudflare-kv-asset-handler-9353

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-miniflare-9353

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-cloudflare-pages-shared-9353

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-cloudflare-unenv-preset-9353

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-cloudflare-vite-plugin-9353

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-cloudflare-vitest-pool-workers-9353

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-cloudflare-workers-editor-shared-9353

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-cloudflare-workers-shared-9353

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15417606777/npm-package-cloudflare-workflows-shared-9353

Note that these links will no longer work once the GitHub Actions artifact expires.

@yeskunall
Copy link
Copy Markdown
Contributor Author

yeskunall commented May 23, 2025 •
edited
Loading

Hey Edmund, commenting to LYK that I saw your message. AFK soon, but I’ll create a changeset as suggested once I’m back. Thanks for your patience!

@yeskunall yeskunall requested a review from edmundhung May 24, 2025 05:02
@petebacondarwin
Copy link
Copy Markdown
Contributor

petebacondarwin commented May 24, 2025

Thank you! We have a CI job that should help creating a backport PR on v3, so we should see a PR coming up soon.

I don't think that job can create a backport branch if the PR is on a fork. I will need to be done manually.

@emily-shen emily-shen mentioned this pull request Jun 3, 2025
Merged
@emily-shen emily-shen enabled auto-merge June 3, 2025 13:47
@CarmenPopoviciu CarmenPopoviciu disabled auto-merge June 5, 2025 10:02
@petebacondarwin petebacondarwin added this pull request to the merge queue Jun 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jun 9, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9353

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9353

miniflare

npm i https://pkg.pr.new/miniflare@9353

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9353

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9353

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9353

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9353

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9353

wrangler

npm i https://pkg.pr.new/wrangler@9353

commit: 9b3c1b1

@petebacondarwin petebacondarwin self-assigned this Jun 13, 2025
@petebacondarwin
Copy link
Copy Markdown
Contributor

petebacondarwin commented Jun 13, 2025

Closing in favour of this on internal branch: #9592

@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 13, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 13, 2025
@petebacondarwin @yeskunall
fix(wrangler): point to the right doc location (replaces #9353) (#9592)
49f5ac7 
* fix: point to the right doc location

* fix(wrangler): update tests

* chore: add changeset

---------

Co-authored-by: Kunall Banerjee <hey@kimchiii.space>
jseba added a commit to jseba/workers-sdk that referenced this pull request Jun 14, 2025
@jseba
Merge branch 'main' of ssh://github.com/cloudflare/workers-sdk into HEAD
50e2835 
* 'main' of ssh://github.com/cloudflare/workers-sdk: (213 commits)
  fix(vite-plugin-cloudflare): allow unknown entrypoint on startup (cloudflare#9583)
  add warning about env not specified to potentially risky wrangler commands (cloudflare#9344)
  test: correctly delete test d1 databases (cloudflare#9598)
  Add details to v3 maintenance worflow error message (cloudflare#9602)
  drop unused `WRANGLER_UNENV_RESOLVE_PATHS` env var (cloudflare#9593)
  warn instead of erroring if no exposed ports. and remove unused dev_exposed_ports (cloudflare#9573)
  fix(wrangler): point to the right doc location (replaces cloudflare#9353) (cloudflare#9592)
  [vitest-pool-worker] Add `type: module` in package.json (cloudflare#9595)
  Enable HTML handling for HTML files in the public directory (cloudflare#9548)
  switch from go container to js (cloudflare#9588)
  containers: switch to Cloudflare container registry (cloudflare#9564)
  performance improvement: restart a mixed mode session only if the worker's remote bindings have changed (cloudflare#9536)
  ci: delete more orphaned resources from e2e tests (cloudflare#9580)
  test: remove `verifyBuildScript` logic from c3 e2e tests (cloudflare#9504)
  fix(vite-plugin): ensure node compat globals are injected before any imports (cloudflare#9581)
  feat(containers-shared): Move `isDockerfile` utility function to `containers-shared` (cloudflare#9577)
  allow `startWorker` to accept `false` as an `inspector` option (to disable the inspector server) (cloudflare#9550)
  Update capnp generated code from the workerd.capnp (cloudflare#9582)
  Bump `@cloudflare/unenv-preset` to 2.3.3 (cloudflare#9566)
  test: make custom build bundling tests more robust (cloudflare#9494)
  ...
@lrapoport-cf lrapoport-cf mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@edmundhung edmundhung Awaiting requested review from edmundhung

Assignees

@petebacondarwin petebacondarwin

Labels

None yet

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yeskunall @edmundhung @petebacondarwin @workers-devprod