Skip to content

Make Ctrl+C triggered during the skills-install prompt dismiss it permanently#14172

Merged
dario-piotrowicz merged 1 commit into
mainfrom
dario/14036/install-skills-sigint-negative
Jun 5, 2026
Merged

Make Ctrl+C triggered during the skills-install prompt dismiss it permanently#14172
dario-piotrowicz merged 1 commit into
mainfrom
dario/14036/install-skills-sigint-negative

Conversation

@dario-piotrowicz

Copy link
Copy Markdown
Member

Fixes #14036

Previously, pressing Ctrl+C (SIGINT) during the "Would you like to install Cloudflare skills?" prompt terminated the process without writing the metadata file, causing the prompt to reappear on every subsequent wrangler invocation. A SIGINT handler is now registered around the prompt so that the metadata file is written with accepted: "SIGINT" before the process exits, preventing the prompt from being shown again.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: self-explanatory behavior

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Jun 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ebe1e28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch
@cloudflare/wrangler-bundler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

ask-bonk[bot]

This comment was marked as outdated.

@ask-bonk

This comment was marked as outdated.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/14036/install-skills-sigint-negative branch from 80960f0 to 0832c4e Compare June 3, 2026 18:37
@pkg-pr-new

pkg-pr-new Bot commented Jun 3, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/cloudflare/workers-sdk/create-cloudflare@14172

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/deploy-helpers@14172

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/kv-asset-handler@14172

miniflare

npm i https://pkg.pr.new/cloudflare/workers-sdk/miniflare@14172

@cloudflare/pages-shared

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/pages-shared@14172

@cloudflare/unenv-preset

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/unenv-preset@14172

@cloudflare/vite-plugin

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/vite-plugin@14172

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/vitest-pool-workers@14172

@cloudflare/workers-auth

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/workers-auth@14172

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/workers-editor-shared@14172

@cloudflare/workers-utils

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/workers-utils@14172

wrangler

npm i https://pkg.pr.new/cloudflare/workers-sdk/wrangler@14172

@cloudflare/wrangler-bundler

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/wrangler-bundler@14172

commit: ebe1e28

@dario-piotrowicz dario-piotrowicz force-pushed the dario/14036/install-skills-sigint-negative branch from 0832c4e to 05071f1 Compare June 3, 2026 21:04
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review June 3, 2026 23:02
@workers-devprod workers-devprod requested review from a team and jamesopstad and removed request for a team June 3, 2026 23:02
@workers-devprod

workers-devprod commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/14036/install-skills-sigint-negative branch from 05071f1 to ebe1e28 Compare June 3, 2026 23:59

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jun 4, 2026
@petebacondarwin petebacondarwin removed the request for review from jamesopstad June 5, 2026 11:49
@dario-piotrowicz dario-piotrowicz merged commit f387256 into main Jun 5, 2026
58 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/14036/install-skills-sigint-negative branch June 5, 2026 11:51
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jun 5, 2026
dario-piotrowicz added a commit that referenced this pull request Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

maybeInstallCloudflareSkillsGlobally writes banner to stdout in non-interactive non-CI shells, breaking JSON output

3 participants