Revert "Make Ctrl+C triggered during the skills-install prompt dismiss it permanently (#14172)"#14222
Conversation
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
This resolves the backward-compat concern. The prompt-skip logic at line 60-64 checks only for the existence of the metadata file ( For the telemetry path (line 653, 700), a stale The revert is clean and exact:
No logic bugs, no security issues, no API-behavior regressions. The revert accomplishes its stated goal without introducing problems. LGTM |
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
@cloudflare/wrangler-bundler
commit: |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
This reverts PR #14172
My reasoning for reverting the PR is that this feature is becoming more complex and problematic than initially thought, as commented by @petebacondarwin #14199 (review)
(On top of that the user that we wanted to support with this turned out not to be a fan of this approach)
Additionally seems like edge cases and issues with this feature keep popping up (in particular in scenarios where TTY is not super clear). Also various users (like @MattIPv4 and @Cherry) have shared various concerns with it.
So here I want to revert the latest change so that it doesn't get released tomorrow, afterwards we should regroup (@MattieTK) and decide whether we want to double down on this feature or consider alternative options.
(Note: #14220 should get the feature in a good enough position, however as CherryJimbo put it, this might also still include other edge cases that are not obvious now and create a cat-and-mouse game with maintenance)