Improve compatibility with V8 13.3#3440
Merged
erikcorry merged 1 commit intoerikcorry/v8-13.3from Jan 30, 2025
Merged
Conversation
Contributor
erikcorry
commented
Jan 30, 2025
- Adjust isolate group creation to allow building with and without shared pointer cage
- Update V8 defines in compile_flags.txt based on bazel aquery output – we currently build V8 without perfetto support. Ideally we'd have an external, auto-generated file with the set of definitions that matter for embedders, but for now this needs to be maintained manually.
- Fix some of the deprecation warnings from V8 13.3.
- Change comment on updating Chromium zlib, this is more of a chore than a necessity.
- Adjust isolate group creation to allow building with and without shared pointer cage - Update V8 defines in compile_flags.txt based on bazel aquery output – we currently build V8 without perfetto support. Ideally we'd have an external, auto-generated file with the set of definitions that matter for embedders, but for now this needs to be maintained manually. - Fix some of the deprecation warnings from V8 13.3. - Change comment on updating Chromium zlib, this is more of a chore than a necessity.
fhanau
added a commit
that referenced
this pull request
Jan 30, 2025
- Adjust isolate group creation to allow building with and without shared pointer cage - Update V8 defines in compile_flags.txt based on bazel aquery output – we currently build V8 without perfetto support. Ideally we'd have an external, auto-generated file with the set of definitions that matter for embedders, but for now this needs to be maintained manually. - Fix some of the deprecation warnings from V8 13.3. - Change comment on updating Chromium zlib, this is more of a chore than a necessity. Co-authored-by: Felix Hanau <felix@cloudflare.com>
fhanau
added a commit
that referenced
this pull request
Jan 30, 2025
- Adjust isolate group creation to allow building with and without shared pointer cage - Update V8 defines in compile_flags.txt based on bazel aquery output – we currently build V8 without perfetto support. Ideally we'd have an external, auto-generated file with the set of definitions that matter for embedders, but for now this needs to be maintained manually. - Fix some of the deprecation warnings from V8 13.3. - Change comment on updating Chromium zlib, this is more of a chore than a necessity. Co-authored-by: Felix Hanau <felix@cloudflare.com>
fhanau
added a commit
that referenced
this pull request
Jan 30, 2025
* Roll V8 to 13.3 * Try to get highway bindings right * Update abseil, zlib and icu to match V8 13.3. * Improve compatibility with V8 13.3 (#3440) - Adjust isolate group creation to allow building with and without shared pointer cage - Update V8 defines in compile_flags.txt based on bazel aquery output – we currently build V8 without perfetto support. Ideally we'd have an external, auto-generated file with the set of definitions that matter for embedders, but for now this needs to be maintained manually. - Fix some of the deprecation warnings from V8 13.3. - Change comment on updating Chromium zlib, this is more of a chore than a necessity. * Fix V8 macOS build --------- Co-authored-by: Felix Hanau <felix@cloudflare.com>
gabivlj
pushed a commit
to gabivlj/workerd
that referenced
this pull request
Jun 18, 2025
* Roll V8 to 13.3 * Try to get highway bindings right * Update abseil, zlib and icu to match V8 13.3. * Improve compatibility with V8 13.3 (cloudflare#3440) - Adjust isolate group creation to allow building with and without shared pointer cage - Update V8 defines in compile_flags.txt based on bazel aquery output – we currently build V8 without perfetto support. Ideally we'd have an external, auto-generated file with the set of definitions that matter for embedders, but for now this needs to be maintained manually. - Fix some of the deprecation warnings from V8 13.3. - Change comment on updating Chromium zlib, this is more of a chore than a necessity. * Fix V8 macOS build --------- Co-authored-by: Felix Hanau <felix@cloudflare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.