Skip to content

Roll V8 to 13.3#3417

Merged
fhanau merged 5 commits intomainfrom
erikcorry/v8-13.3
Jan 30, 2025
Merged

Roll V8 to 13.3#3417
fhanau merged 5 commits intomainfrom
erikcorry/v8-13.3

Conversation

@erikcorry
Copy link
Contributor

No description provided.

@erikcorry erikcorry requested review from a team as code owners January 28, 2025 15:43
@erikcorry erikcorry marked this pull request as draft January 28, 2025 15:44
@erikcorry erikcorry requested review from fhanau and removed request for ObsidianMinor and dom96 January 28, 2025 15:44
@github-actions
Copy link

github-actions bot commented Jan 28, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@fhanau
Copy link
Contributor

fhanau commented Jan 28, 2025

Versions of zlib, absl and ICU (in build/deps/v8.bzl) should be updated based on git diff origin/13.2-lkgr origin/13.3-lkgr -- DEPS

@fhanau fhanau force-pushed the erikcorry/v8-13.3 branch from f509c7b to a98655d Compare January 30, 2025 20:12
erikcorry and others added 3 commits January 30, 2025 16:34
- Adjust isolate group creation to allow building with and without shared
  pointer cage
- Update V8 defines in compile_flags.txt based on bazel aquery output –
  we currently build V8 without perfetto support. Ideally we'd have an
  external, auto-generated file with the set of definitions that matter for
  embedders, but for now this needs to be maintained manually.
- Fix some of the deprecation warnings from V8 13.3.
- Change comment on updating Chromium zlib, this is more of a chore than a
  necessity.

Co-authored-by: Felix Hanau <felix@cloudflare.com>
@fhanau fhanau force-pushed the erikcorry/v8-13.3 branch from a98655d to 9b5d733 Compare January 30, 2025 21:38
@fhanau
Copy link
Contributor

fhanau commented Jan 30, 2025

Dropped the build --@v8//:v8_enable_pointer_compression_shared_cage=False – it caused the macOS build to fail.

@fhanau fhanau marked this pull request as ready for review January 30, 2025 21:43
@fhanau fhanau merged commit 316068f into main Jan 30, 2025
17 checks passed
@fhanau fhanau deleted the erikcorry/v8-13.3 branch January 30, 2025 23:50
gabivlj pushed a commit to gabivlj/workerd that referenced this pull request Jun 18, 2025
* Roll V8 to 13.3

* Try to get highway bindings right

* Update abseil, zlib and icu to match V8 13.3.

* Improve compatibility with V8 13.3 (cloudflare#3440)

- Adjust isolate group creation to allow building with and without shared
  pointer cage
- Update V8 defines in compile_flags.txt based on bazel aquery output –
  we currently build V8 without perfetto support. Ideally we'd have an
  external, auto-generated file with the set of definitions that matter for
  embedders, but for now this needs to be maintained manually.
- Fix some of the deprecation warnings from V8 13.3.
- Change comment on updating Chromium zlib, this is more of a chore than a
  necessity.

* Fix V8 macOS build

---------

Co-authored-by: Felix Hanau <felix@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants