Record official extension telemetry by williammartin · Pull Request #13205 · cli/cli

williammartin · 2026-04-17T13:13:08Z

Description

Initially, we did not record any command_invocation telemetry when an extension was invoked because we didn't know if the extension was private or not. We still don't do a check for privacy (though we could do the same as on #13204 and background it, but that's a follow up) but we do emit telemetry if the extension is official since we know those are public.

babakks

LGTM, but with some questions.

babakks · 2026-04-17T13:46:15Z

+# `stack` is registered in extensions.OfficialExtensions. Since no real
+# extension is installed, the hidden stub runs and, in a non-TTY session,
+# prints install instructions without prompting.
+exec gh stack
+stderr 'gh extension install github/gh-stack'


Just note that this test will fail at some point when the extension repo is deleted.

I don't think it should ever be deleted. It should rather be archived.

babakks · 2026-04-17T13:49:05Z

+	if !extensions.IsOfficial(ext.Name()) {
+		cmdutil.DisableTelemetry(cmd)
+	}


question: edge case: user have already installed a gh-stack extension from a different source (i.e. not github/gh-stack), and now we collect telemetry on that. Note that since the extension has already been installed, we don't register the top-level stub command.

Updated so that we also check the owner. In practice someone could have a GHES repo at github/gh-stack but I'm willing to take those odds.

babakks · 2026-04-17T13:51:36Z

+// Comparison is case-insensitive because extension names come from
+// filenames and installed extensions preserve whatever casing was used at
+// install time.
+func IsOfficial(name string) bool {


What if the user already has a private extension named STACK?

Mmm good question, I assumed badly that gh STACK would just go to stack. Sweet catch.

babakks · 2026-04-17T13:52:16Z

+		{
+			name:    "mixed-case name still matches",
+			extName: "STACK",
+			want:    true,
+		},


Yeah, I'm talking about this case. This should be false IMO.

Copilot

Pull request overview

This PR enables command_invocation telemetry for official GitHub-owned extensions (and their hidden stub commands) while keeping telemetry disabled by default for third-party extensions to avoid leaking potentially sensitive user-chosen extension names.

Changes:

Added an extensions.IsOfficial(name) helper to identify official extension command names.
Updated extension command construction to only disable telemetry for non-official extensions.
Added unit and acceptance coverage to ensure official extension stubs emit telemetry while third-party extensions do not.

Show a summary per file

File	Description
pkg/extensions/official.go	Adds `IsOfficial` helper for checking official extension command names (case-sensitive).
pkg/extensions/official_test.go	Adds unit tests for `IsOfficial`.
pkg/cmd/root/extension.go	Conditionally disables telemetry only for non-official extensions.
pkg/cmd/root/extension_test.go	Adds unit test asserting telemetry is enabled only for official extension command names.
acceptance/testdata/telemetry/telemetry-for-official-extension-stub.txtar	New acceptance test ensuring official extension stub invocation records telemetry.
acceptance/testdata/telemetry/no-telemetry-for-extension.txtar	Clarifies acceptance test rationale for suppressing telemetry for third-party extensions.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 6/6 changed files
Comments generated: 0

babakks

LGTM! Thanks. 🚀

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.90.0` → `v2.92.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.92.0`](https://github.com/cli/cli/releases/tag/v2.92.0): GitHub CLI 2.92.0 [Compare Source](cli/cli@v2.91.0...v2.92.0) #### Support GitHub Enterprise Cloud (GHEC) in `skill` commandset Now `gh skill` subcommands (`install`, `preview`, `publish`, `search`, `update`) are able to work with [GHEC](https://docs.github.com/en/enterprise-cloud@latest/admin/overview/about-github-enterprise-cloud) hosts with data residency. #### Add `--allow-hidden-dirs` flag to `skill preview` Following the addition of `--allow-hidden-dirs` to `skill install` in the previous release, now the flag is also supported in `skill preview`, allowing users to preview skills located in hidden (dot-prefixed) directories such as `.claude/skills/`, `.agents/skills/`, and `.github/skills/`. #### What's Changed ##### ✨ Features - feat(skills): add --allow-hidden-dirs flag to preview command by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13265](cli/cli#13265) - feat(skills): support GHEC with data residency hosts by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13264](cli/cli#13264) ##### 🐛 Fixes - Fix SetSampleRate not updating sample\_rate dimension by [@williammartin](https://github.com/williammartin) in [#13259](cli/cli#13259) - Fix log terminal injection by [@williammartin](https://github.com/williammartin) in [#13272](cli/cli#13272) - Add "Resource not accessible" to ProjectsV2IgnorableError by [@maxbeizer](https://github.com/maxbeizer) in [#13281](cli/cli#13281) ##### 📚 Docs & Chores - fix: using variable interpolation \`${{ in deployment.yml... by [@orbisai0security](https://github.com/orbisai0security) in [#13258](cli/cli#13258) - docs: correct typo in Linux Homebrew copy by [@cassidyjames](https://github.com/cassidyjames) in [#13273](cli/cli#13273) - Install skills flat by Name, not namespaced InstallName by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13266](cli/cli#13266) - chore: fix zsh completion on debian by [@babakks](https://github.com/babakks) in [#13274](cli/cli#13274) - Add trust disclaimer to extension help text by [@travellertales](https://github.com/travellertales) in [#13296](cli/cli#13296) - Bump Go to 1.26.2 by [@github-actions](https://github.com/github-actions)\[bot] in [#13301](cli/cli#13301) #####

Dependencies - chore(deps): bump github.com/mattn/go-isatty from 0.0.20 to 0.0.21 by [@dependabot](https://github.com/dependabot)\[bot] in [#13161](cli/cli#13161) - chore(deps): bump github.com/google/go-containerregistry from 0.21.4 to 0.21.5 by [@dependabot](https://github.com/dependabot)\[bot] in [#13162](cli/cli#13162) - chore(deps): bump charm.land/lipgloss/v2 from 2.0.2 to 2.0.3 by [@dependabot](https://github.com/dependabot)\[bot] in [#13163](cli/cli#13163) - chore(deps): bump charm.land/bubbletea/v2 from 2.0.2 to 2.0.6 by [@dependabot](https://github.com/dependabot)\[bot] in [#13206](cli/cli#13206) - chore(deps): bump github.com/gdamore/tcell/v2 from 2.13.8 to 2.13.9 by [@dependabot](https://github.com/dependabot)\[bot] in [#13241](cli/cli#13241) - chore(deps): bump github.com/mattn/go-isatty from 0.0.21 to 0.0.22 by [@dependabot](https://github.com/dependabot)\[bot] in [#13298](cli/cli#13298) #### New Contributors - [@orbisai0security](https://github.com/orbisai0security) made their first contribution in [#13258](cli/cli#13258) - [@cassidyjames](https://github.com/cassidyjames) made their first contribution in [#13273](cli/cli#13273) - [@travellertales](https://github.com/travellertales) made their first contribution in [#13296](cli/cli#13296) **Full Changelog**: <cli/cli@v2.91.0...v2.92.0> ### [`v2.91.0`](https://github.com/cli/cli/releases/tag/v2.91.0): GitHub CLI 2.91.0 [Compare Source](cli/cli@v2.90.0...v2.91.0) #### GitHub CLI now collects pseudonymous telemetry To better understand how features are used in practice, especially as agentic adoption grows, GitHub CLI now sends pseudonymous telemetry. See [Telemetry](https://cli.github.com/telemetry) for more details on what's collected, why, and how to opt out. #### Support more agents in `gh skill` Thanks to community feedback, `gh` now supports a large number of agent hosts. Run `gh skill install --help` for the list of available agents. #### Improve skill discovery `gh skill install` now adds the `--allow-hidden-dirs` flag to support discovering skills in hidden (dot-prefixed) directories such as `.claude/skills/`, `.agents/skills/`, and `.github/skills/`. #### Detect skills re-published from other sources GitHut CLI now detects if the skill to be installed is re-published from an upstream source and offers the option to install it from there. The `--upstream` flag is also added for non-interactive use cases. #### What's Changed ##### ✨ Features - Add support for installation in multiple agent hosts in `gh skills install` by [@tommaso-moro](https://github.com/tommaso-moro) in [#13209](cli/cli#13209) - Add --allow-hidden-dirs flag to gh skill install by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13213](cli/cli#13213) - Make skill discovery less strict: support nested `skills/` directories by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13235](cli/cli#13235) - feat(skills): detect re-published skills and offer upstream install by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13236](cli/cli#13236) ##### 🐛 Fixes - Fix `skills publish --fix` to not publish by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13237](cli/cli#13237) - fix(skills): match skills by install name in preview command by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13249](cli/cli#13249) ##### 📚 Docs & Chores - Remove misleading text by [@tommaso-moro](https://github.com/tommaso-moro) in [#13203](cli/cli#13203) - Add sampled command telemetry by [@williammartin](https://github.com/williammartin) in [#13191](cli/cli#13191) - Do not send telemetry for aliases by [@williammartin](https://github.com/williammartin) in [#13192](cli/cli#13192) - Add skills specific telemetry by [@williammartin](https://github.com/williammartin) in [#13204](cli/cli#13204) - Record CI context in telemetry by [@williammartin](https://github.com/williammartin) in [#13210](cli/cli#13210) - Record official extension telemetry by [@williammartin](https://github.com/williammartin) in [#13205](cli/cli#13205) - Add telemetry command by [@williammartin](https://github.com/williammartin) in [#13253](cli/cli#13253) - Log when there is no telemetry by [@williammartin](https://github.com/williammartin) in [#13255](cli/cli#13255) - docs(skills): add gh and gh-skill agent skills by [@BagToad](https://github.com/BagToad) in [#13244](cli/cli#13244) - Enable telemetry without env var by [@williammartin](https://github.com/williammartin) in [#13254](cli/cli#13254) **Full Changelog**: <cli/cli@v2.90.0...v2.91.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).

williammartin requested a review from a team April 17, 2026 13:13

williammartin requested a review from a team as a code owner April 17, 2026 13:13

williammartin requested review from babakks and removed request for a team April 17, 2026 13:13

williammartin force-pushed the wm/record-official-extension-telemetry branch from 3d75cad to 69f02c9 Compare April 17, 2026 13:14

williammartin marked this pull request as draft April 17, 2026 13:16

williammartin force-pushed the wm/record-official-extension-telemetry branch from 69f02c9 to 82608b2 Compare April 17, 2026 13:27

williammartin marked this pull request as ready for review April 17, 2026 13:27

williammartin requested a review from BagToad April 17, 2026 13:27

babakks reviewed Apr 17, 2026

View reviewed changes

williammartin force-pushed the wm/record-official-extension-telemetry branch from 82608b2 to 405aeb4 Compare April 17, 2026 15:52

Base automatically changed from wm/skills-telemetry to trunk April 17, 2026 17:59

Copilot AI review requested due to automatic review settings April 20, 2026 09:53

williammartin force-pushed the wm/record-official-extension-telemetry branch from 405aeb4 to e1cfff3 Compare April 20, 2026 09:53

Copilot started reviewing on behalf of williammartin April 20, 2026 09:53 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

williammartin requested a review from babakks April 20, 2026 09:59

williammartin force-pushed the wm/record-official-extension-telemetry branch from e1cfff3 to b562a9c Compare April 20, 2026 10:01

babakks approved these changes Apr 20, 2026

View reviewed changes

Comment thread pkg/extensions/official.go Outdated

BagToad approved these changes Apr 20, 2026

View reviewed changes

Record official extension telemetry

c50fb79

williammartin force-pushed the wm/record-official-extension-telemetry branch from b562a9c to c50fb79 Compare April 21, 2026 09:48

williammartin enabled auto-merge April 21, 2026 09:48

williammartin merged commit e52070e into trunk Apr 21, 2026
11 checks passed

williammartin deleted the wm/record-official-extension-telemetry branch April 21, 2026 09:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Record official extension telemetry#13205

Record official extension telemetry#13205
williammartin merged 1 commit into
trunkfrom
wm/record-official-extension-telemetry

williammartin commented Apr 17, 2026 •

edited

Loading

Uh oh!

babakks left a comment

Uh oh!

babakks Apr 17, 2026

Uh oh!

BagToad Apr 17, 2026

Uh oh!

babakks Apr 17, 2026

Uh oh!

williammartin Apr 20, 2026

Uh oh!

babakks Apr 17, 2026

Uh oh!

williammartin Apr 17, 2026

Uh oh!

williammartin Apr 20, 2026

Uh oh!

babakks Apr 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

babakks left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

williammartin commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

babakks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

babakks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

williammartin commented Apr 17, 2026 •

edited

Loading