Skip to content

Clean up project item-list query addition changes#12714

Merged
williammartin merged 4 commits intotrunkfrom
wm-add-dto-comment
Feb 18, 2026
Merged

Clean up project item-list query addition changes#12714
williammartin merged 4 commits intotrunkfrom
wm-add-dto-comment

Conversation

@williammartin
Copy link
Member

@williammartin williammartin commented Feb 18, 2026

Description

Applies some requested changes from #12696

Copilot AI review requested due to automatic review settings February 18, 2026 16:24
@williammartin williammartin requested a review from a team as a code owner February 18, 2026 16:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates and cleans up a series of changes across the CLI, including feature-detection TODO markers, REST API version pinning, workflow dispatch run-details support, and GitHub Projects item-list filtering via a new --query flag, alongside workflow automation migrations.

Changes:

  • Add feature detection for Projects item filtering (--query) and Actions workflow-dispatch run details, and wire both into relevant commands/tests.
  • Pin REST API calls with X-GitHub-Api-Version: 2022-11-28 and update related tests.
  • Migrate multiple triage/stale/automation workflows to shared reusable workflows and update docs/templates accordingly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/search/searcher.go Adds required TODO marker above a feature-detection conditional.
pkg/cmd/workflow/run/run.go Adds feature-detected return_run_details, parses 200/204 responses, prints run URL/help accordingly.
pkg/cmd/workflow/run/run_test.go Expands workflow dispatch tests for 200-with-details vs 204 behavior and detector usage.
pkg/cmd/run/view/view.go Ensures --exit-status is respected when using --log/--log-failed.
pkg/cmd/run/view/view_test.go Adds coverage asserting non-zero exit behavior with --log/--log-failed.
pkg/cmd/repo/list/list.go Adds TODO marker above a repo feature-detection conditional.
pkg/cmd/repo/edit/edit.go Adds TODO markers above repo feature-detection conditionals.
pkg/cmd/release/upload/upload.go Clarifies --clobber behavior in help text and flag description.
pkg/cmd/release/list/http.go Adds TODO marker above immutable releases feature gate.
pkg/cmd/project/shared/queries/queries.go Adds ProjectsV2 items query support via split query structs + conversion to domain model; updates ProjectItems signature.
pkg/cmd/project/shared/queries/queries_test.go Updates existing tests for new ProjectItems signature and adds tests for query/no-query behavior.
pkg/cmd/project/item-list/item_list.go Adds --query flag with feature detection and passes query through to ProjectItems.
pkg/cmd/project/item-list/item_list_test.go Adds flag parsing and end-to-end item-list coverage for query supported/unsupported hosts.
pkg/cmd/pr/shared/finder.go Adds TODO marker above merge-queue feature gate.
pkg/cmd/pr/list/http.go Adds TODO markers around advanced issue search feature gates.
pkg/cmd/pr/edit/edit.go Adds TODO markers around actor-assignable feature gates.
pkg/cmd/issue/shared/lookup.go Adds TODO marker above state-reason feature gate.
pkg/cmd/issue/list/list.go Adds TODO marker above state-reason feature gate.
pkg/cmd/issue/list/http.go Adds TODO markers around advanced issue search feature gates.
pkg/cmd/issue/edit/edit.go Adds TODO marker around actor-assignable feature gate.
pkg/cmd/issue/create/create.go Adds TODO marker around actor-assignable feature gate.
pkg/cmd/issue/close/close.go Adds TODO marker around state-reason feature gate.
pkg/cmd/gist/edit/edit.go Adds usage examples to gh gist edit help.
pkg/cmd/factory/default_test.go Updates expectations to include the pinned REST API version header.
internal/featuredetection/feature_detection.go Extends detector with Projects and Actions feature detection.
internal/featuredetection/feature_detection_test.go Adds test coverage for new Projects and Actions feature detection.
internal/featuredetection/detector_mock.go Updates detector mocks to satisfy expanded Detector interface.
docs/triage.md Updates label naming guidance for triage processes.
api/client.go Introduces X-GitHub-Api-Version constants and applies header to GraphQL client options.
api/client_test.go Updates header assertions to include REST API version header.
api/http_client.go Adds the API version header to default HTTP client headers.
api/http_client_test.go Updates header assertions and debug output expectations for API version header.
.github/workflows/triage.yml Removes legacy discussion triage workflow in favor of shared workflows.
.github/workflows/triage-discussion-label.yml Adds reusable-workflow-based discuss-label processing with proper inputs/secrets.
.github/workflows/triage-issues.yml Adds shared-workflow-based issue triage automation.
.github/workflows/triage-pull-requests.yml Adds shared-workflow-based PR triage automation.
.github/workflows/triage-scheduled-tasks.yml Adds shared-workflow-based scheduled triage tasks (stale/no-response).
.github/workflows/stale-issues.yml Removes legacy stale issues workflow in favor of shared workflow.
.github/workflows/scripts/spam-detection/eval-prompts.yml Updates label names referenced in spam-detection eval prompts.
.github/workflows/scripts/check-help-wanted.sh Removes legacy script (functionality migrated to shared workflows).
.github/workflows/prauto.yml Removes legacy PR automation workflow.
.github/workflows/pr-help-wanted.yml Removes legacy PR help-wanted check workflow.
.github/workflows/issueauto.yml Removes legacy issue automation workflow.
.github/workflows/feature-request-comment.yml Removes legacy feature-request comment workflow.
.github/ISSUE_TEMPLATE/feedback.md Removes feedback issue template.
Comments suppressed due to low confidence (1)

pkg/cmd/project/item-list/item_list.go:48

  • Grammar typo in example text: "current users's project" should be "current user's project".
			# List the items in the current users's project "1"
			$ gh project item-list 1 --owner "@me"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@williammartin williammartin merged commit dd9ca9b into trunk Feb 18, 2026
11 checks passed
@williammartin williammartin deleted the wm-add-dto-comment branch February 18, 2026 16:58
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 25, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cli/cli](https://github.com/cli/cli) | minor | `v2.86.0` → `v2.87.3` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>cli/cli (cli/cli)</summary>

### [`v2.87.3`](https://github.com/cli/cli/releases/tag/v2.87.3): GitHub CLI 2.87.3

[Compare Source](cli/cli@v2.87.2...v2.87.3)

#### What's Changed

- Fix project mutation query variable usage by [@&#8203;williammartin](https://github.com/williammartin) in [#&#8203;12757](cli/cli#12757)

**Full Changelog**: <cli/cli@v2.87.2...v2.87.3>

### [`v2.87.2`](https://github.com/cli/cli/releases/tag/v2.87.2): GitHub CLI 2.87.2

[Compare Source](cli/cli@v2.87.1...v2.87.2)

#### ℹ️ Note

This release was cut primarily to resolve a publishing issue. We recommend reviewing [the v2.87.1 release notes](https://github.com/cli/cli/releases/tag/v2.87.1) for the complete set of latest features and fixes.

#### What's Changed

- chore(deps): bump golang.org/x/crypto from 0.47.0 to 0.48.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12659](cli/cli#12659)

**Full Changelog**: <cli/cli@v2.87.1...v2.87.2>

### [`v2.87.1`](https://github.com/cli/cli/releases/tag/v2.87.1): GitHub CLI 2.87.1

[Compare Source](cli/cli@v2.87.0...v2.87.1)

#### ⚠️ Incomplete Release

The v2.87.1 release experienced a failure in our workflow and is not fully published to the designated package managers/repositories. This is resolved in [v2.87.2](https://github.com/cli/cli/releases/tag/v2.87.2), so we recommend using that release instead.

#### What's Changed

- Remove license bundling debris by [@&#8203;williammartin](https://github.com/williammartin) in [#&#8203;12716](cli/cli#12716)
- fix(agent-task/capi): use a fixed CAPI API version by [@&#8203;babakks](https://github.com/babakks) in [#&#8203;12731](cli/cli#12731)

**Full Changelog**: <cli/cli@v2.87.0...v2.87.1>

### [`v2.87.0`](https://github.com/cli/cli/releases/tag/v2.87.0): GitHub CLI 2.87.0

[Compare Source](cli/cli@v2.86.0...v2.87.0)

#### `gh workflow run` immediately returns workflow run URL

One of our most requested features - with the latest changes in GitHub API, `gh workflow run` will immediately print the created workflow run URL.

#### Improved `gh auth login` experience in VM/WSL environments

We have observed rare cases of time drift between the wall and monotonic clocks, mostly in WSL or VM environments, causing failures during polling for the OAuth token. This new release implements measures to account for such situations.

If you continue to experience `gh auth login` issues in WSL, please comment in [#&#8203;9370](cli/cli#9370)

#### :copilot: Request Copilot Code Review from `gh` + performance improvements

`gh pr edit` now supports [Copilot Code Review](https://docs.github.com/en/copilot/using-github-copilot/code-review/using-copilot-code-review) as a reviewer. You can request a review from Copilot using the `--add-reviewer @&#8203;copilot` flag or interactively by selecting reviewers in the prompts.

This release also introduces a new search experience for selecting reviewers and assignees in `gh pr edit`. Instead of loading all collaborators and teams upfront, results are now fetched based on inputs to a new search option. Initial options are suggestions based on those involved with the pull request already.

```
? Reviewers  [Use arrows to move, space to select, <right> to all, <left> to none, type to filter]
  [ ]  Search (7472 more)
  [x]  BagToad (Kynan Ware)
> [x]  Copilot (AI)
```

This experience will follow in `gh pr create` and `gh issue` for assignees in a later release.

#### What's Changed

##### ✨ Features

- Bundle licenses at release time by [@&#8203;williammartin](https://github.com/williammartin) in [#&#8203;12625](cli/cli#12625)
- Add `--query` flag to `project item-list` by [@&#8203;williammartin](https://github.com/williammartin) in [#&#8203;12696](cli/cli#12696)
- feat(workflow run): retrieve workflow dispatch run details by [@&#8203;babakks](https://github.com/babakks) in [#&#8203;12695](cli/cli#12695)
- Pin REST API version to 2022-11-28 by [@&#8203;williammartin](https://github.com/williammartin) in [#&#8203;12680](cli/cli#12680)
- Respect `--exit-status` with `--log` and `--log-failed` in `run view` by [@&#8203;williammartin](https://github.com/williammartin) in [#&#8203;12679](cli/cli#12679)
- Fork with default branch only during pr create by [@&#8203;williammartin](https://github.com/williammartin) in [#&#8203;12673](cli/cli#12673)
- `gh pr edit`: Add support for Copilot as reviewer with search capability, performance and accessibility improvements by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;12567](cli/cli#12567)
- `gh pr edit`: new interactive prompt for assignee selection, performance and accessibility improvements by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;12526](cli/cli#12526)

##### 📚 Docs & Chores

- Clean up project item-list query addition changes by [@&#8203;williammartin](https://github.com/williammartin) in [#&#8203;12714](cli/cli#12714)
- `gh release upload`: Clarify `--clobber` flag deletes assets before re-uploading by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;12711](cli/cli#12711)
- Add usage examples to `gh gist edit` command by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;12710](cli/cli#12710)
- Remove feedback issue template by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;12708](cli/cli#12708)
- Migrate issue triage workflows to shared workflows by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;12677](cli/cli#12677)
- Migrate MR triage workflows to shared workflows by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;12707](cli/cli#12707)
- Add missing TODO comments for featuredetection if-statements by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;12701](cli/cli#12701)
- Add manual dispatch to bump-go workflow by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;12631](cli/cli#12631)
- typo: dont to don't by [@&#8203;cuiweixie](https://github.com/cuiweixie) in [#&#8203;12554](cli/cli#12554)
- Fix fmt.Errorf format argument in ParseFullReference by [@&#8203;mikelolasagasti](https://github.com/mikelolasagasti) in [#&#8203;12516](cli/cli#12516)
- Lint source.md by [@&#8203;Sethispr](https://github.com/Sethispr) in [#&#8203;12521](cli/cli#12521)

##### :dependabot: Dependencies

- chore(deps): bump golang.org/x/text from 0.32.0 to 0.33.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12468](cli/cli#12468)
- chore(deps): bump golang.org/x/term from 0.38.0 to 0.39.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12616](cli/cli#12616)
- Bump go to 1.25.7 by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;12630](cli/cli#12630)
- chore(deps): bump golang.org/x/crypto from 0.46.0 to 0.47.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12629](cli/cli#12629)
- chore: bump `cli/oauth` to `v1.2.2` by [@&#8203;babakks](https://github.com/babakks) in [#&#8203;12573](cli/cli#12573)
- update Go to 1.25.6 by [@&#8203;BagToad](https://github.com/BagToad) in [#&#8203;12580](cli/cli#12580)
- chore(deps): bump actions/attest-build-provenance from 3.1.0 to 3.2.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12558](cli/cli#12558)
- chore(deps): bump github.com/sigstore/rekor from 1.4.3 to 1.5.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12524](cli/cli#12524)
- chore(deps): bump github.com/theupdateframework/go-tuf/v2 from 2.3.1 to 2.4.1 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12555](cli/cli#12555)
- chore(deps): bump github.com/gdamore/tcell/v2 from 2.13.4 to 2.13.7 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12469](cli/cli#12469)
- chore(deps): bump github.com/sigstore/sigstore from 1.10.0 to 1.10.4 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12525](cli/cli#12525)
- chore(deps): bump github.com/theupdateframework/go-tuf/v2 from 2.3.0 to 2.3.1 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12515](cli/cli#12515)
- chore(deps): bump actions/download-artifact from 6 to 7 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12314](cli/cli#12314)
- chore(deps): bump actions/upload-artifact from 5 to 6 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12315](cli/cli#12315)
- chore(deps): bump goreleaser/goreleaser-action from 6.0.0 to 6.4.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;12354](cli/cli#12354)

#### New Contributors

- [@&#8203;Sethispr](https://github.com/Sethispr) made their first contribution in [#&#8203;12521](cli/cli#12521)
- [@&#8203;cuiweixie](https://github.com/cuiweixie) made their first contribution in [#&#8203;12554](cli/cli#12554)

**Full Changelog**: <cli/cli@v2.86.0...v2.87.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNC4yIiwidXBkYXRlZEluVmVyIjoiNDMuMzEuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6Om1pbm9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants