Copilot is assignable to issues and pull requests with `issue edit` and `pr edit` #10992

BagToad · 2025-05-16T18:29:50Z

This pull request introduces support for handling "assignable actors" (users and bots). The changes include new data structures, methods, and feature detection logic to accommodate this functionality.

Built from:

This improves actor type handling while fetching repository assignable actors.

… updateIssue

- Refactored AssignedActors to return display names instead of logins. - Updated related functions to ensure consistency in display names. - Enhanced comments for clarity on display name logic and actor types.

Co-authored-by: Andy Feller <andyfeller@github.com>

…-issues `gh issue edit`: actors are assignable to issues

Co-authored-by: Andy Feller <andyfeller@github.com>

…i-909-911-assign-actors-to-prs

…-prs `gh pr edit`: Assign actors to pull requests

- Added tests for handling nil and empty slices in the Copilot replacer. - Simplified test structure by removing unnecessary wantErr field.

…ee-names `issue edit`, `pr edit`: handle display names in interactive assignee editing

…ee-names-noninteractive `issue edit`, `pr edit`: Support special non-interactive (flags) assignee name `@copilot`

Copilot

Pull Request Overview

Adds support for assignable actors (e.g., bots) alongside legacy user assignees in both issue and PR edit flows, updating data models, API queries, and interactive behavior.

Introduce AssignableActor, AssignableUser, and AssignableBot types and extend RepoMetadataResult to include AssignableActors.
Update edit logic to detect host support for actor assignees and switch between assignees and assignedActors fields.
Add a special CopilotReplacer and related tests to handle the @copilot placeholder.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/cmd/pr/shared/editable.go	Extend `Editable` to track actor vs. user assignees
pkg/cmd/pr/shared/editable_http.go	Separate actor‐based assignment mutation call
pkg/cmd/pr/shared/survey.go	Switch to method calls for `AssignableUser` API
pkg/cmd/pr/shared/params.go	Add `CopilotReplacer`; update slice‐replacement logic
api/queries_repo.go	Add `AssignableActor` fetching and merge logic
api/query_builder.go	Define `assignedActors` GraphQL snippet
api/queries_pr.go & api/queries_issue.go	Include `AssignedActors` in PR/Issue types
internal/featuredetection/feature_detection.go	Add `ActorIsAssignable` feature flag
Various test files	Adjust tests for actor‐assignee flows and Copilot

pkg/cmd/pr/shared/editable.go

Copilot · 2025-05-16T18:31:57Z

api/query_builder.go

 }

+var assignedActors = shortenQuery(`
+	assignedActors(first: 10) {


The assignedActors query fetches only the first 10 actors (first: 10), whereas other list queries use larger limits (e.g., 100). Consider increasing to first: 100 to avoid missing actors in repositories with many bots/users.

Suggested change

assignedActors(first: 10) {

assignedActors(first: 100) {

Rejecting change because this is intentional (only 10 actors can be assigned).

thought: I'm honestly not opposed to Copilot suggestion as it wouldn't hurt to retrieve whatever information is available even though we know currently only 10 can be assigned.

pkg/cmd/pr/shared/params.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

andyfeller

Again, I think the stacked PRs helped work through this PR much easier! 💯

I had a handful of questions and an odd suggestion but nothing end of the world.

api/queries_issue.go

api/queries_repo.go

andyfeller · 2025-05-16T19:33:51Z

api/query_builder.go

 }

+var assignedActors = shortenQuery(`
+	assignedActors(first: 10) {


thought: I'm honestly not opposed to Copilot suggestion as it wouldn't hurt to retrieve whatever information is available even though we know currently only 10 can be assigned.

pkg/cmd/pr/edit/edit.go

andyfeller · 2025-05-16T19:54:46Z

api/query_builder.go

+		case "assignedActors":
+			q = append(q, assignedActors)


thought: one of the things I'm doing in this final PR is comparing the changes in certain files to see if there are any missing test changes.

one thing I noticed in query_builder_test.go were tests around this function:

cli/api/query_builder_test.go

Lines 51 to 90 in 53d0d5d

func TestIssueGraphQL(t *testing.T) {

tests := []struct {

name string

fields []string

want string

}{

{

name: "empty",

fields: []string(nil),

want: "",

},

{

name: "simple fields",

fields: []string{"number", "title"},

want: "number,title",

},

{

name: "fields with nested structures",

fields: []string{"author", "assignees"},

want: "author{login,...on User{id,name}},assignees(first:100){nodes{id,login,name},totalCount}",

},

{

name: "compressed query",

fields: []string{"files"},

want: "files(first: 100) {nodes {additions,deletions,path}}",

},

{

name: "projectItems",

fields: []string{"projectItems"},

want: `projectItems(first:100){nodes{id, project{id,title}, status:fieldValueByName(name: "Status") { ... on ProjectV2ItemFieldSingleSelectValue{optionId,name}}},totalCount}`,

},

}

for _, tt := range tests {

t.Run(tt.name, func(t *testing.T) {

if got := IssueGraphQL(tt.fields); got != tt.want {

t.Errorf("IssueGraphQL() = %v, want %v", got, tt.want)

}

})

}

}

I'm trying to think through when and why this is updated 🤔

andyfeller

LGTM

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.72.0` -> `v2.73.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.73.0`](https://github.com/cli/cli/releases/tag/v2.73.0): GitHub CLI 2.73.0 [Compare Source](cli/cli@v2.72.0...v2.73.0) ####

Copilot Coding Agent Support You can now assign issues to GitHub Copilot directly from `gh`, just as you would assign them to a teammate. Use `gh issue edit <number> --add-assignee @copilot` to assign the GitHub Copilot coding agent, and Copilot will work in the background to understand the issue, propose a solution, and open a pull request when it's ready for your review. If you run `gh issue edit` interactively, `Copilot (AI)` will be displayed as a potential assignee. This feature is available for GitHub Copilot Pro+ and Copilot Enterprise subscribers. For more details, refer to [the full changelog post for Copilot coding agent](https://github.blog/changelog/2025-05-19-github-copilot-coding-agent-in-public-preview/). #### What's Changed ##### ✨ Features - Copilot is assignable to issues and pull requests with `issue edit` and `pr edit` by [@BagToad](https://github.com/BagToad) in cli/cli#10992 - `gh issue edit`: actors are assignable to issues by [@BagToad](https://github.com/BagToad) in cli/cli#10960 - `gh pr edit`: Assign actors to pull requests by [@BagToad](https://github.com/BagToad) in cli/cli#10984 - `issue edit`, `pr edit`: handle display names in interactive assignee editing by [@BagToad](https://github.com/BagToad) in cli/cli#10990 - `issue edit`, `pr edit`: Support special non-interactive (flags) assignee name `@copilot` by [@BagToad](https://github.com/BagToad) in cli/cli#10991 - \[gh issue/pr comment] Add support for last comment delete for issues and MRs by [@sinansonmez](https://github.com/sinansonmez) in cli/cli#10596 - \[gh issue view] Expose `closedByPullRequestsReferences` JSON field by [@iamazeem](https://github.com/iamazeem) in cli/cli#10941 - Accessible prompter always displays selection defaults in a format readable by a screen reader by [@BagToad](https://github.com/BagToad) in cli/cli#10937 ##### 🐛 Fixes - Fix `StatusJSONResponse` usage by [@babakks](https://github.com/babakks) in cli/cli#10810 - Fix panic on `gh pr view 0` by [@nopcoder](https://github.com/nopcoder) in cli/cli#10729 - Fix flakey test for accessible prompter by [@BagToad](https://github.com/BagToad) in cli/cli#10918 - Fix accessible prompter flaky tests by [@babakks](https://github.com/babakks) in cli/cli#10977 - Handle missing archive URLs on release download by [@williammartin](https://github.com/williammartin) in cli/cli#10947 - Fix bug when removing all MR reviewers by [@babakks](https://github.com/babakks) in cli/cli#10975 ##### 📚 Docs & Chores - Feature detect v1 projects on pr view by [@williammartin](https://github.com/williammartin) in cli/cli#10821 - Feature detect v1 projects on non-interactive pr create by [@williammartin](https://github.com/williammartin) in cli/cli#10909 - Feature detect v1 projects on web mode pr create by [@williammartin](https://github.com/williammartin) in cli/cli#10911 - Feature detect v1 projects on interactive `pr create` by [@williammartin](https://github.com/williammartin) in cli/cli#10915 - Feature detect v1 projects on pr edit by [@williammartin](https://github.com/williammartin) in cli/cli#10942 - Move predicate type filtering in `gh attestation verify` by [@malancas](https://github.com/malancas) in cli/cli#10670 - Improve assertion for disabled echo mode by [@babakks](https://github.com/babakks) in cli/cli#10927 #####

Dependencies - chore(deps): bump actions/attest-build-provenance from 2.2.2 to 2.3.0 by [@dependabot](https://github.com/dependabot) in cli/cli#10886 - chore(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.6 to 2.0.7 by [@dependabot](https://github.com/dependabot) in cli/cli#10869 #### What's Changed #### New Contributors - [@sinansonmez](https://github.com/sinansonmez) made their first contribution in cli/cli#10596 - [@nopcoder](https://github.com/nopcoder) made their first contribution in cli/cli#10729 **Full Changelog**: cli/cli@v2.72.0...v2.73.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

BagToad and others added 30 commits May 7, 2025 12:23

feat(fd): add ActorIsAssignable to IssueFeatures

8ebbd1d

feat(issue edit): fetch currently assigned actors

38e52db

feat(issue edit): fetch assignable actors

ee9d169

feat(issue edit): support assigning actors to issues

0efdfed

chore(issue edit): comments cleanup

e0afc91

fix(issue edit): resolve race condition in actor assignment

218152f

refactor(issue edit): improve actor type handling

29241cb

This improves actor type handling while fetching repository assignable actors.

doc(issue): comment why assignable actors disabled

73e5589

doc(repo queries): clarify reviewer actor fetching logic

cff2fa7

refactor(issue edit): rename AssignedActors to ActorAssignees

3579282

refactor(issue edit): rename loop variable for clarity

3bed778

refactor(issue edit): add assignedActors to lookupFields

261297f

fix(issue edit): use double quotes for assignedActors

21bd797

fix(issue edit): revert rename of ActorAssignees

1e5c3c7

refactor(api): rename assignable user types and methods

dfd6007

doc(api): remove needless comment

712eeab

feat(issue edit): replacing actor assignee is done synchronously with…

08cd1dc

… updateIssue

doc(issue edit): clarify synchronous handling of assignees

5dc854c

feat(pr edit): fetch assigned actors

71f22d8

feat(pr edit): fetch assignable actors

d4832ba

feat(editable): update assigned actors to use display names

eace1e8

- Refactored AssignedActors to return display names instead of logins. - Updated related functions to ensure consistency in display names. - Enhanced comments for clarity on display name logic and actor types.

doc(api): code comment typo

da40e08

Co-authored-by: Andy Feller <andyfeller@github.com>

refactor(api): remove needless parenthesis

ea85b92

Co-authored-by: Andy Feller <andyfeller@github.com>

fix(api): correct var name capitalization

bcd47f1

Merge pull request #10960 from cli/kw/gh-cli-901-910-assign-actors-to…

999ffbd

…-issues `gh issue edit`: actors are assignable to issues

refactor(api): remove needless parenthesis

0db7ae8

Co-authored-by: Andy Feller <andyfeller@github.com>

fix(api): correct var name capitalization

6162a7c

feat(pr edit): fetch assigned actors

f559068

feat(pr edit): fetch assignable actors

d72018d

Merge branch 'kw/gh-cli-epic-900-actors-are-assignable' into kw/gh-cl…

a03c9ce

…i-909-911-assign-actors-to-prs

BagToad added 10 commits May 15, 2025 14:22

Merge pull request #10984 from cli/kw/gh-cli-909-911-assign-actors-to…

98b289d

…-prs `gh pr edit`: Assign actors to pull requests

test(editable): prompts use assignee display names

a22a1bb

doc(editable): remove needless comment

c5f2d7b

fix(params): remove needless err return

871671b

test(params): enhance Copilot replacer tests for edge cases

debf0bb

- Added tests for handling nil and empty slices in the Copilot replacer. - Simplified test structure by removing unnecessary wantErr field.

doc(issue/pr edit): doc @copilot assignee

532aa1c

Merge pull request #10990 from cli/kw/gh-cli-916-special-actor-assign…

475163a

…ee-names `issue edit`, `pr edit`: handle display names in interactive assignee editing

doc(issue/pr edit): clarify @copilot usage

748afb6

Merge pull request #10991 from cli/kw/gh-cli-917-special-actor-assign…

3a8cdda

…ee-names-noninteractive `issue edit`, `pr edit`: Support special non-interactive (flags) assignee name `@copilot`

refactor(api): use constant for Copilot login

a28e2d8

Copilot AI review requested due to automatic review settings May 16, 2025 18:29

BagToad requested a review from a team as a code owner May 16, 2025 18:29

BagToad requested a review from babakks May 16, 2025 18:29

BagToad temporarily deployed to cli-automation May 16, 2025 18:29 — with GitHub Actions Inactive

cliAutomation assigned BagToad May 16, 2025

Copilot AI reviewed May 16, 2025

View reviewed changes

BagToad and others added 3 commits May 16, 2025 12:49

Merge branch 'trunk' into kw/gh-cli-epic-900-actors-are-assignable

d932934

doc(params): incorrect func name in comment

6f19060

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(editable): include DefaultLogins in EditableAssignees clone

53d0d5d

BagToad requested review from andyfeller and williammartin May 16, 2025 18:54

andyfeller reviewed May 16, 2025

View reviewed changes

BagToad added 2 commits May 16, 2025 14:57

refactor(api): change CopilotActorLogin to constant

e0f3f0f

refactor(api): inline struct definitions in RepoAssignableActors

0788a01

BagToad changed the title ~~[WIP] issue edit, pr edit: Actors are assignable~~ issue edit, pr edit: Actors are assignable May 16, 2025

andyfeller approved these changes May 19, 2025

View reviewed changes

BagToad changed the title ~~issue edit, pr edit: Actors are assignable~~ Copilot is assignable to issues and pull requests with issue edit and pr edit May 19, 2025

BagToad merged commit e0d7ad7 into trunk May 19, 2025
16 checks passed

BagToad deleted the kw/gh-cli-epic-900-actors-are-assignable branch May 19, 2025 18:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Copilot is assignable to issues and pull requests with `issue edit` and `pr edit` #10992

Copilot is assignable to issues and pull requests with `issue edit` and `pr edit` #10992

Uh oh!

BagToad commented May 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI May 16, 2025

Uh oh!

BagToad May 16, 2025

Uh oh!

andyfeller May 16, 2025

Uh oh!

Uh oh!

andyfeller left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andyfeller May 16, 2025

Uh oh!

Uh oh!

andyfeller May 16, 2025

Uh oh!

andyfeller left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	func TestIssueGraphQL(t *testing.T) {
	tests := []struct {
	name string
	fields []string
	want string
	}{
	{
	name: "empty",
	fields: []string(nil),
	want: "",
	},
	{
	name: "simple fields",
	fields: []string{"number", "title"},
	want: "number,title",
	},
	{
	name: "fields with nested structures",
	fields: []string{"author", "assignees"},
	want: "author{login,...on User{id,name}},assignees(first:100){nodes{id,login,name},totalCount}",
	},
	{
	name: "compressed query",
	fields: []string{"files"},
	want: "files(first: 100) {nodes {additions,deletions,path}}",
	},
	{
	name: "projectItems",
	fields: []string{"projectItems"},
	want: `projectItems(first:100){nodes{id, project{id,title}, status:fieldValueByName(name: "Status") { ... on ProjectV2ItemFieldSingleSelectValue{optionId,name}}},totalCount}`,
	},
	}
	for _, tt := range tests {
	t.Run(tt.name, func(t *testing.T) {
	if got := IssueGraphQL(tt.fields); got != tt.want {
	t.Errorf("IssueGraphQL() = %v, want %v", got, tt.want)
	}
	})
	}
	}

Copilot is assignable to issues and pull requests with issue edit and pr edit #10992

Copilot is assignable to issues and pull requests with issue edit and pr edit #10992

Uh oh!

Conversation

BagToad commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI May 16, 2025

Choose a reason for hiding this comment

Uh oh!

BagToad May 16, 2025

Choose a reason for hiding this comment

Uh oh!

andyfeller May 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andyfeller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andyfeller May 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andyfeller May 16, 2025

Choose a reason for hiding this comment

Uh oh!

andyfeller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot is assignable to issues and pull requests with `issue edit` and `pr edit` #10992

Copilot is assignable to issues and pull requests with `issue edit` and `pr edit` #10992

BagToad commented May 16, 2025 •

edited

Loading