`gh issue edit`: actors are assignable to issues #10960

BagToad · 2025-05-10T05:26:27Z

Description

This introduces support for handling "Actor" assignees (e.g., bots) in addition to user assignees for issues. The changes include updates to feature detection, GraphQL queries, and associated tests to accommodate this new functionality.

These changes cover both interactive and non-interactive (flags) flows.

Note

This intentionally does not merge into trunk, as part of a stacked PR workflow.

Acceptance Criteria

Given I have an issue where an Actor is assignable and
Given I am authenticated with a GitHub host that supports the Actor type.
When I run gh issue edit <issuenum> and select to edit Assignees
Then I receive a list of assignees that includes assignable Actors, and the Actors already assigned to the issue are pre-selected.
When I select one or more Actors from the list, and proceed
Then I see those selected Actors assigned to the issue

❯ gh issue edit 1 
? What would you like to edit? Assignees
? Assignees  [Use arrows to move, space to select, <right> to all, <left> to none, type to filter]
> [ ]  ActorToad
  [x]  BagToad

# Note: showing the above was pre-selected ☝️ before selecting ActorToad

? Assignees  [Use arrows to move, space to select, <right> to all, <left> to none, type to filter]
> [x]  ActorToad
  [x]  BagToad

? Submit? Yes
https://github.com/BagToad/reponame/issues/1

❯ gh issue view 1
some title#1
Open • BagToad opened about 15 days ago • 0 comments
Assignees: BagToad, ActorToad

Given I have an issue where an Actor is assignable and
Given I am authenticated with a GitHub host that supports the Actor type.
When I run gh issue edit <issuenum> --add-assignee <actorname>...
Then I see the specified Actor(s) are assigned to the issue

Given I have an issue where an Actor is assigned already
Given I am authenticated with a GitHub host that supports the Actor type.
When I run gh issue edit <issuenum> --remove-assignee <actorname>...
Then I see the specified Actor(s) are unassigned from the issue

❯ gh issue edit 1 --add-assignee ActorToad
https://github.com/BagToad/reponame/issues/1

❯ gh issue view 1
some title#1
Open • BagToad opened about 15 days ago • 0 comments
Assignees: BagToad, ActorToad

❯ gh issue edit 1 --remove-assignee ActorToad
https://github.com/BagToad/reponame/issues/1

❯ gh issue view 1
some title#1
Open • BagToad opened about 15 days ago • 0 comments
Assignees: BagToad

Copilot

Pull Request Overview

Support for assigning “Actor” types (e.g., bots) to issues by extending models, feature detection, GraphQL queries, and tests.

Introduce EditableAssignees to distinguish actor vs. user assignees in interactive and flags flows
Add RepoAssignableActors and update RepoMetadataInput/Result to fetch and merge actor assignees
Update editRun logic, API mutations, and tests to handle the new assignedActors field

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/cmd/pr/shared/editable_http.go	Added replaceActorAssigneesForEditable mutation
pkg/cmd/pr/shared/editable.go	Introduced EditableAssignees and updated FetchOptions
pkg/cmd/pr/edit/edit_test.go	Switched tests to use EditableAssignees
pkg/cmd/issue/edit/edit_test.go	Updated issue edit tests and added TestActorIsAssignable
pkg/cmd/issue/edit/edit.go	Detect ActorIsAssignable and append assignedActors field
internal/featuredetection/feature_detection.go	Added ActorIsAssignable flag in IssueFeatures
api/queries_repo.go	Implemented RepoAssignableActors and extended RepoMetadata
api/queries_issue.go	Added ActorAssignees type and AssignedActors mapping

Comments suppressed due to low confidence (1)

api/queries_repo.go:1237

Add unit tests for RepoAssignableActors covering cases where suggestedActors includes Bot entries, to ensure both User and Bot nodes are returned correctly.

func RepoAssignableActors(client *Client, repo ghrepo.Interface) ([]RepoAssignee, error) {

api/queries_repo.go

internal/featuredetection/feature_detection.go

api/queries_repo.go

This improves actor type handling while fetching repository assignable actors.

andyfeller

Sorry for a partial review as I get caught up to speed on the implications of actors versus assignees; will review the rest of the PR tomorrow 🙇

pkg/cmd/issue/edit/edit.go

api/queries_issue.go

api/queries_repo.go

pkg/cmd/issue/edit/edit.go

pkg/cmd/pr/shared/editable_http.go

pkg/cmd/pr/edit/edit_test.go

pkg/cmd/issue/edit/edit_test.go

williammartin

Given I have an issue where an Actor is assignable and
Given I am authenticated with a GitHub host that supports the Actor type.
When I run gh issue edit <issuenum> and select to edit Assignees
Then I receive a list of assignees that includes assignable Actors, and the Actors already assigned to the issue are pre-selected.
When I select one or more Actors from the list, and proceed
Then I see those selected Actors assigned to the issue

@BagToad, have you tried editing an issue where an Actor is already assigned and seeing that it is still assigned in the prompter? I think this doesn't work both from reading the code and trying it out.

Specifically, I'm calling out this line:

Then I receive a list of assignees that includes assignable Actors, and the Actors already assigned to the issue are pre-selected.

Relevant code that probably shouldn't be using assignableUsers:

cli/pkg/cmd/pr/shared/survey.go

Lines 203 to 205 in 17af24e

    
           for _, u := range metadataResult.AssignableUsers { 
        
           	assignees = append(assignees, u.DisplayName()) 
        
           }

BagToad · 2025-05-14T15:10:39Z

@BagToad, have you tried editing an issue where an Actor is already assigned and seeing that it is still assigned in the prompter? I think this doesn't work both from reading the code and trying it out.

@williammartin This should work, and does in my tests.

The code where this happens is here, as far as I understand:

cli/pkg/cmd/issue/edit/edit.go

Lines 269 to 273 in 712eeab

    
           if editable.Assignees.ActorAssignees { 
        
           	editable.Assignees.Default = issue.AssignedActors.Logins() 
        
           } else { 
        
           	editable.Assignees.Default = issue.Assignees.Logins() 
        
           }

williammartin · 2025-05-14T15:30:27Z

Confirming that what I saw in #10960 (review) was the result of a branch that had regressed but is now fixed.

… updateIssue

andyfeller

First, I really appreciate the effort to align the actor work around new types as this looks much easier to manage and understand! ✨

I don't see anything that would really block this from continuing these efforts beyond various questions and nits.

I do wonder about the sealed types and the complications that raises with testing, though. Again, it isn't enough to block this going into the feature branch.

api/queries_issue.go

api/queries_repo.go

andyfeller · 2025-05-14T20:06:17Z

api/queries_repo.go

+			user := struct {
+				Id    string
+				Login string
+				Name  string
+			}{}


@williammartin : what are your thoughts of working around the sealed interface, preventing us from leveraging one of the declared types for this?

It's a good question. Gut feeling is that I don't have a problem with it. If it mattered a lot we could implement https://pkg.go.dev/encoding/json#Unmarshaler on AssignableUser.

api/query_builder.go

pkg/cmd/pr/shared/editable_http.go

Co-authored-by: Andy Feller <andyfeller@github.com>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.72.0` -> `v2.73.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.73.0`](https://github.com/cli/cli/releases/tag/v2.73.0): GitHub CLI 2.73.0 [Compare Source](cli/cli@v2.72.0...v2.73.0) ####

Copilot Coding Agent Support You can now assign issues to GitHub Copilot directly from `gh`, just as you would assign them to a teammate. Use `gh issue edit <number> --add-assignee @copilot` to assign the GitHub Copilot coding agent, and Copilot will work in the background to understand the issue, propose a solution, and open a pull request when it's ready for your review. If you run `gh issue edit` interactively, `Copilot (AI)` will be displayed as a potential assignee. This feature is available for GitHub Copilot Pro+ and Copilot Enterprise subscribers. For more details, refer to [the full changelog post for Copilot coding agent](https://github.blog/changelog/2025-05-19-github-copilot-coding-agent-in-public-preview/). #### What's Changed ##### ✨ Features - Copilot is assignable to issues and pull requests with `issue edit` and `pr edit` by [@BagToad](https://github.com/BagToad) in cli/cli#10992 - `gh issue edit`: actors are assignable to issues by [@BagToad](https://github.com/BagToad) in cli/cli#10960 - `gh pr edit`: Assign actors to pull requests by [@BagToad](https://github.com/BagToad) in cli/cli#10984 - `issue edit`, `pr edit`: handle display names in interactive assignee editing by [@BagToad](https://github.com/BagToad) in cli/cli#10990 - `issue edit`, `pr edit`: Support special non-interactive (flags) assignee name `@copilot` by [@BagToad](https://github.com/BagToad) in cli/cli#10991 - \[gh issue/pr comment] Add support for last comment delete for issues and MRs by [@sinansonmez](https://github.com/sinansonmez) in cli/cli#10596 - \[gh issue view] Expose `closedByPullRequestsReferences` JSON field by [@iamazeem](https://github.com/iamazeem) in cli/cli#10941 - Accessible prompter always displays selection defaults in a format readable by a screen reader by [@BagToad](https://github.com/BagToad) in cli/cli#10937 ##### 🐛 Fixes - Fix `StatusJSONResponse` usage by [@babakks](https://github.com/babakks) in cli/cli#10810 - Fix panic on `gh pr view 0` by [@nopcoder](https://github.com/nopcoder) in cli/cli#10729 - Fix flakey test for accessible prompter by [@BagToad](https://github.com/BagToad) in cli/cli#10918 - Fix accessible prompter flaky tests by [@babakks](https://github.com/babakks) in cli/cli#10977 - Handle missing archive URLs on release download by [@williammartin](https://github.com/williammartin) in cli/cli#10947 - Fix bug when removing all MR reviewers by [@babakks](https://github.com/babakks) in cli/cli#10975 ##### 📚 Docs & Chores - Feature detect v1 projects on pr view by [@williammartin](https://github.com/williammartin) in cli/cli#10821 - Feature detect v1 projects on non-interactive pr create by [@williammartin](https://github.com/williammartin) in cli/cli#10909 - Feature detect v1 projects on web mode pr create by [@williammartin](https://github.com/williammartin) in cli/cli#10911 - Feature detect v1 projects on interactive `pr create` by [@williammartin](https://github.com/williammartin) in cli/cli#10915 - Feature detect v1 projects on pr edit by [@williammartin](https://github.com/williammartin) in cli/cli#10942 - Move predicate type filtering in `gh attestation verify` by [@malancas](https://github.com/malancas) in cli/cli#10670 - Improve assertion for disabled echo mode by [@babakks](https://github.com/babakks) in cli/cli#10927 #####

Dependencies - chore(deps): bump actions/attest-build-provenance from 2.2.2 to 2.3.0 by [@dependabot](https://github.com/dependabot) in cli/cli#10886 - chore(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.6 to 2.0.7 by [@dependabot](https://github.com/dependabot) in cli/cli#10869 #### What's Changed #### New Contributors - [@sinansonmez](https://github.com/sinansonmez) made their first contribution in cli/cli#10596 - [@nopcoder](https://github.com/nopcoder) made their first contribution in cli/cli#10729 **Full Changelog**: cli/cli@v2.72.0...v2.73.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

BagToad added 6 commits May 7, 2025 12:23

feat(fd): add ActorIsAssignable to IssueFeatures

8ebbd1d

feat(issue edit): fetch currently assigned actors

38e52db

feat(issue edit): fetch assignable actors

ee9d169

feat(issue edit): support assigning actors to issues

0efdfed

chore(issue edit): comments cleanup

e0afc91

fix(issue edit): resolve race condition in actor assignment

218152f

BagToad temporarily deployed to cli-automation May 10, 2025 05:26 — with GitHub Actions Inactive

BagToad marked this pull request as ready for review May 10, 2025 05:31

BagToad requested a review from a team as a code owner May 10, 2025 05:31

BagToad requested review from williammartin and removed request for a team May 10, 2025 05:31

BagToad temporarily deployed to cli-automation May 10, 2025 05:31 — with GitHub Actions Inactive

cliAutomation assigned BagToad May 10, 2025

BagToad requested review from andyfeller and Copilot May 10, 2025 05:33

Copilot AI reviewed May 10, 2025

View reviewed changes

api/queries_repo.go Outdated Show resolved Hide resolved

williammartin reviewed May 12, 2025

View reviewed changes

internal/featuredetection/feature_detection.go Outdated Show resolved Hide resolved

andyfeller reviewed May 12, 2025

View reviewed changes

api/queries_repo.go Show resolved Hide resolved

BagToad added 2 commits May 12, 2025 11:34

refactor(issue edit): improve actor type handling

29241cb

This improves actor type handling while fetching repository assignable actors.

doc(issue): comment why assignable actors disabled

73e5589

BagToad changed the title ~~gh issue actors are assignable to issues~~ gh issue: actors are assignable to issues May 12, 2025

doc(repo queries): clarify reviewer actor fetching logic

cff2fa7

andyfeller added the discuss Feature changes that require discussion primarily among the GitHub CLI team label May 12, 2025

andyfeller temporarily deployed to cli-discuss-automation May 12, 2025 18:29 — with GitHub Actions Inactive

andyfeller requested changes May 12, 2025

View reviewed changes

BagToad added 2 commits May 13, 2025 07:09

refactor(issue edit): rename AssignedActors to ActorAssignees

3579282

refactor(issue edit): rename loop variable for clarity

3bed778

andyfeller reviewed May 13, 2025

View reviewed changes

refactor(issue edit): add assignedActors to lookupFields

261297f

BagToad requested a review from andyfeller May 13, 2025 14:15

BagToad requested a review from williammartin May 13, 2025 14:15

BagToad added 2 commits May 13, 2025 11:45

fix(issue edit): use double quotes for assignedActors

21bd797

fix(issue edit): revert rename of ActorAssignees

1e5c3c7

williammartin reviewed May 14, 2025

View reviewed changes

BagToad added 2 commits May 14, 2025 08:53

refactor(api): rename assignable user types and methods

dfd6007

doc(api): remove needless comment

712eeab

BagToad changed the title ~~gh issue: actors are assignable to issues~~ gh issue edit: actors are assignable to issues May 14, 2025

BagToad mentioned this pull request May 14, 2025

gh pr edit: Assign actors to pull requests #10984

Merged

BagToad added 2 commits May 14, 2025 11:43

feat(issue edit): replacing actor assignee is done synchronously with…

08cd1dc

… updateIssue

doc(issue edit): clarify synchronous handling of assignees

5dc854c

andyfeller approved these changes May 14, 2025

View reviewed changes

BagToad and others added 3 commits May 15, 2025 08:33

doc(api): code comment typo

da40e08

Co-authored-by: Andy Feller <andyfeller@github.com>

refactor(api): remove needless parenthesis

ea85b92

Co-authored-by: Andy Feller <andyfeller@github.com>

fix(api): correct var name capitalization

bcd47f1

BagToad merged commit 999ffbd into kw/gh-cli-epic-900-actors-are-assignable May 15, 2025
14 checks passed

BagToad deleted the kw/gh-cli-901-910-assign-actors-to-issues branch May 15, 2025 15:24

BagToad mentioned this pull request May 16, 2025

Copilot is assignable to issues and pull requests with issue edit and pr edit #10992

Merged

renovate bot mentioned this pull request Jul 14, 2025

chore(deps): update all dependencies nolte/workstation#66

Merged

	for _, u := range metadataResult.AssignableUsers {
	assignees = append(assignees, u.DisplayName())
	}

gh issue edit: actors are assignable to issues #10960

gh issue edit: actors are assignable to issues #10960

Uh oh!

Conversation

BagToad commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Acceptance Criteria

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andyfeller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

williammartin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BagToad commented May 14, 2025

Uh oh!

williammartin commented May 14, 2025

Uh oh!

andyfeller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andyfeller May 14, 2025

Choose a reason for hiding this comment

Uh oh!

williammartin May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

`gh issue edit`: actors are assignable to issues #10960

`gh issue edit`: actors are assignable to issues #10960

BagToad commented May 10, 2025 •

edited

Loading

williammartin left a comment •

edited

Loading