Skip to content

[embedded_envoy_test] More fixes#44749

Merged
sayboras merged 1 commit intocilium:mainfrom
nezdolik:embedded-envoy-test-fix
Mar 12, 2026
Merged

[embedded_envoy_test] More fixes#44749
sayboras merged 1 commit intocilium:mainfrom
nezdolik:embedded-envoy-test-fix

Conversation

@nezdolik
Copy link
Copy Markdown
Contributor

@nezdolik nezdolik commented Mar 12, 2026 •
edited
Loading

When running embedded envoy test locally, there were 2 problems:

  1. envoy process fails during init phase:
[2026-03-12 10:57:14.079][3935362][critical][main] error `: Proto constraint validation failed (DownstreamConnectionsConfigValidationError.MaxActiveDownstreamConnections: value must be greater than 0)` initializing config '  /tmp/envoy_go_test3330713178/envoy/bootstrap.pb'
[2026-03-12 10:57:14.079][3935362][info][main] exiting
: Proto constraint validation failed (DownstreamConnectionsConfigValidationError.MaxActiveDownstreamConnections: value must be greater than 0)
  1. Xds server segfaults on response as metrics is not initialized in AckingResourceMutator

@nezdolik nezdolik requested a review from a team as a code owner March 12, 2026 11:21
@nezdolik nezdolik requested a review from sayboras March 12, 2026 11:21
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 12, 2026
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Mar 12, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 12, 2026
@nezdolik
[embedded_envoy_test] Set maxActiveDownstreamConnections in config
1406be8 
Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@isovalent.com>
@nezdolik nezdolik force-pushed the embedded-envoy-test-fix branch from 3921f1a to 1406be8 Compare March 12, 2026 11:35
@nezdolik nezdolik changed the title [embedded_envoy_test] Set maxActiveDownstreamConnections in config [embedded_envoy_test] More fixes Mar 12, 2026
@sayboras sayboras enabled auto-merge March 12, 2026 12:10
@sayboras
Copy link
Copy Markdown
Member

sayboras commented Mar 12, 2026

/test

@sayboras sayboras added this pull request to the merge queue Mar 12, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 12, 2026
Merged via the queue into cilium:main with commit 3203d0c Mar 12, 2026
79 checks passed
nezdolik added a commit to nezdolik/community that referenced this pull request Mar 13, 2026
@nezdolik
Add nezdolik to envoy team
ed83249 
cilium/cilium#44749
cilium/cilium#43887
cilium/cilium#42359
cilium/cilium#42223
cilium/cilium#42232

Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
@nezdolik nezdolik mentioned this pull request Mar 13, 2026
Merged
nezdolik added a commit to nezdolik/community that referenced this pull request Mar 13, 2026
@nezdolik
Add nezdolik to envoy team
2256107 
cilium/cilium#44749
cilium/cilium#43887
cilium/cilium#42359
cilium/cilium#42223
cilium/cilium#42232

Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
nezdolik added a commit to nezdolik/community that referenced this pull request Mar 13, 2026
@nezdolik
Add nezdolik to envoy team
91aa7f9 
cilium/cilium#44749
cilium/cilium#43887
cilium/cilium#42359
cilium/cilium#42223
cilium/cilium#42232

Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
joestringer pushed a commit to cilium/community that referenced this pull request Mar 13, 2026
@nezdolik @joestringer
Add nezdolik to envoy team
9f68fa8 
cilium/cilium#44749
cilium/cilium#43887
cilium/cilium#42359
cilium/cilium#42223
cilium/cilium#42232

Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrajahalme jrajahalme jrajahalme approved these changes

@sayboras sayboras sayboras approved these changes

Assignees

No one assigned

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nezdolik @sayboras @jrajahalme @msune