helm: Switch to numeric target port for cilium-envoy svc#42232
Merged
tklauser merged 1 commit intocilium:mainfrom Oct 17, 2025
Merged
helm: Switch to numeric target port for cilium-envoy svc#42232tklauser merged 1 commit intocilium:mainfrom
tklauser merged 1 commit intocilium:mainfrom
Conversation
|
Commit f840fba does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
f840fba to
eb00b46
Compare
nickolaev
approved these changes
Oct 17, 2025
sayboras
approved these changes
Oct 17, 2025
Contributor
|
/test |
eb00b46 to
378f662
Compare
Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@isovalent.com>
378f662 to
29de2eb
Compare
Contributor
|
/test |
Artyop
approved these changes
Oct 17, 2025
joamaki
approved these changes
Oct 17, 2025
nezdolik
added a commit
to nezdolik/community
that referenced
this pull request
Mar 13, 2026
cilium/cilium#44749 cilium/cilium#43887 cilium/cilium#42359 cilium/cilium#42223 cilium/cilium#42232 Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
nezdolik
added a commit
to nezdolik/community
that referenced
this pull request
Mar 13, 2026
cilium/cilium#44749 cilium/cilium#43887 cilium/cilium#42359 cilium/cilium#42223 cilium/cilium#42232 Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
nezdolik
added a commit
to nezdolik/community
that referenced
this pull request
Mar 13, 2026
cilium/cilium#44749 cilium/cilium#43887 cilium/cilium#42359 cilium/cilium#42223 cilium/cilium#42232 Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
joestringer
pushed a commit
to cilium/community
that referenced
this pull request
Mar 13, 2026
cilium/cilium#44749 cilium/cilium#43887 cilium/cilium#42359 cilium/cilium#42223 cilium/cilium#42232 Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
This change switches to using numeric port instead of named port in cilium envoy svc. Verified that change does not break metrics reporting and is backwards compatible. The reasoning behind the change is to make cilium envoy metrics still available when port is not explicitly declared in cilium-envoy pod spec (e.g. to avoid k8s scheduling conflict in more advanced rollout scenarios).
Fixes: #issue-number